Looks fine to me.
I was wondering, whether it is a little bit more instinctive to return a
string with the type number for unknown and private algorithm in
KerberosKey.getAlgorithm(). For example:
unknown - kid-2014
private - kid-(2014)
Thanks,
Xuelei
On 4/8/2014 10:37 AM, Weijun Wang
There is already getKeyType() and toString(). Also I don't think
kid-2014 is useful. If people really want to inspect the result, I
expect they would fall into the default or else block anyway.
--Max
On 4/9/2014 7:57, Xuelei Fan wrote:
Looks fine to me.
I was wondering, whether it is a
On 4/9/2014 8:53 AM, Weijun Wang wrote:
There is already getKeyType() and toString().
;-) They should not lower the standards to design another good method.
Also I don't think
kid-2014 is useful. If people really want to inspect the result, I
expect they would fall into the default or else
On 4/9/2014 9:15, Xuelei Fan wrote:
On 4/9/2014 8:53 AM, Weijun Wang wrote:
There is already getKeyType() and toString().
;-) They should not lower the standards to design another good method.
I just meant different methods serve for different purposes.
Also I don't think
kid-2014 is
Yes, that is still my preference.
OK.
Thanks,
Xuelei
On 4/9/2014 9:50 AM, Weijun Wang wrote:
On 4/9/2014 9:15, Xuelei Fan wrote:
On 4/9/2014 8:53 AM, Weijun Wang wrote:
There is already getKeyType() and toString().
;-) They should not lower the standards to design another good method.
Hi All
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8035986/webrev.00/
It's about using IANA names in KerberosKey instead of old non-standard
names.
Thanks
Max
