RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
Hello! We've got a request to fix javadoc for SecureRandom, so that the example code will read byte[] bytes = new byte[20]; instead of byte bytes[] = new byte[20]; I took opportunity to make all array declarations throughout security-lib source code more of Java-style. Would you please

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Seán Coffey
Looks good to me.. and is much easier to read now! Regards, Sean. On 08/07/2015 16:35, Ivan Gerasimov wrote: Hello! We've got a request to fix javadoc for SecureRandom, so that the example code will read byte[] bytes = new byte[20]; instead of byte bytes[] = new byte[20]; I took

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: http://cr.openjdk.java.net/~igerasim/8130022/01/webrev/ Would you please take

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Ivan Gerasimov
On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: http://cr.openjdk.java.net/~igerasim/8130022/01/webrev/ Would you please take

Re: RFR 8130022: Use Java-style array declarations consistently

2015-07-08 Thread Seán Coffey
On 08/07/2015 18:14, Ivan Gerasimov wrote: On 08.07.2015 18:57, Seán Coffey wrote: Looks good to me.. and is much easier to read now! Thanks Seán for review! I've missed some portion of update int the previous webrev. Now, sending the whole changeset: