Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-16 Thread Valerie Peng
On Mon, 16 May 2022 13:28:13 GMT, Sean Mullan wrote: >> With this modification of 2nd sentence. The whole paragraph becomes: >> >> * The returned parameters may be the same that were used to >> initialize >> * this signature, or may contain additional default or random parameter >>

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-16 Thread Sean Mullan
On Fri, 13 May 2022 20:58:16 GMT, Valerie Peng wrote: >> src/java.base/share/classes/java/security/Signature.java line 1012: >> >>> 1010: * values used by the underlying signature scheme. If the required >>> 1011: * parameters were not supplied and can be generated by the >>> signatur

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-13 Thread Valerie Peng
On Fri, 13 May 2022 20:29:11 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix newline. > > src/java.base/share/classes/java/security/Signature.java line 1012: > >> 1010: * values used by t

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-13 Thread Sean Mullan
On Fri, 13 May 2022 19:35:35 GMT, Valerie Peng wrote: >> This is to update the method javadoc of >> java.security.Signature.getParameters() with the missing `@throws >> UnsupportedOperationException`. In addition, the wording on the returned >> parameters are updated to match those in Cipher a

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-13 Thread Valerie Peng
> This is to update the method javadoc of > java.security.Signature.getParameters() with the missing `@throws > UnsupportedOperationException`. In addition, the wording on the returned > parameters are updated to match those in Cipher and CipherSpi classes. > > CSR will be filed later. > > Th