Looks good.
Be sure to check in the closed version when you get your changes
finished. Also, check to see if anyone else will be checking in signed
jar files. I should have a changeset coming within the next week or so.
Thanks,
Brad
On 4/3/2013 4:31 PM, Anthony Scarpino wrote:
Updated
Updated code review with regression test.
http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.02/
Tony
Minor typos that don't affect program execution (comments/javadoc) are
ok to not do unit tests, but even through this is a typo, I think this
still needs a test.
Brad
On 3/28/2013 2:51 PM, Anthony Scarpino wrote:
I had left the regression test out of this as it was a typo rather than
a code
I had left the regression test out of this as it was a typo rather than
a code logic issue or something someone could rebroken. Are you ok if
this goes back without a test?
Tony
On 03/28/2013 02:46 PM, Brad Wetmore wrote:
There is no regression test. I created one which relies on reflection
There is no regression test. I created one which relies on reflection,
which is one way to test this problem. Feel free to create another, but
that one is ready to go.
Please see the attachment in the bug, and you'll probably want to update
the copyright date.
Brad
On 3/28/2013 2:29 PM,
Just realized, there are no regression tests here.
Simplest is to probably do as much setup as you can, then
java.security.Security.removeProvider("SunJCE"), then issue the calls
that call into these changes. They should all pass in the new version,
and fail in the old.
Brad
On 3/28/2013
Hi all,
I have a very simple code review request. It's a typo bug.
8001596 Incorrect condition check in PBKDF2KeyImpl.JAVA
https://jbs.oracle.com/bugs/browse/JDK-8001596
http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.01/
thanks
Tony
