[9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2014-11-14 Thread Vincent Ryan
Please review this fix to check for pending exceptions in JNI: Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 Webrev: http://cr.openjdk.java.net/~vinnie/8034031/webrev.00/ Thanks.

[9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2014-11-14 Thread Vincent Ryan
Please review this fix to check for pending exceptions in JNI: Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 Webrev: http://cr.openjdk.java.net/~vinnie/8034031/webrev.00/ Thanks.

Re: [9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2014-11-14 Thread Alan Bateman
On 14/11/2014 11:08, Vincent Ryan wrote: Please review this fix to check for pending exceptions in JNI: Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 Webrev: http://cr.openjdk.java.net/~vinnie/8034031/webrev.00/ This looks oka

Re: [9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2014-11-14 Thread Wang Weijun
The last label has a trailing semicolon. Otherwise good. --Max > On Nov 14, 2014, at 18:58, Vincent Ryan wrote: > > Please review this fix to check for pending exceptions in JNI: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 > Webrev: http://cr.openjdk.java.net/~vinnie/8034031/webr

Re: [9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2014-11-14 Thread Vincent Ryan
Thanks Max. The trailing semicolon is needed to satisfy the compiler (because of the macro that follows). On 14 Nov 2014, at 13:31, Wang Weijun wrote: > The last label has a trailing semicolon. Otherwise good. > > --Max > >> On Nov 14, 2014, at 18:58, Vincent Ryan wrote: >> >> Please review

Re: RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

2014-11-14 Thread Wang Weijun
Webrev withdrawn. I'd like to make more changes. Thanks Max > On Nov 14, 2014, at 10:38, Wang Weijun wrote: > > Hi All > > This is a doc change only bug. Fix at > > http://cr.openjdk.java.net/~weijun/8061253/webrev.00/ > > Please take a review. > > Thanks > Max >

Re: A fully fledged TLS Extensions API ?

2014-11-14 Thread Bradford Wetmore
Simone, Your note was good timing. ALPN and HTTP/2 is on our radar for 9, and we're starting to look at options now, maybe even using some type of general extension API. ALPN is pretty straightforward and can be done easily, but there are advantages to having a full extensions API. We're a

Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-11-14 Thread Valerie Peng
Max, Most looks fine, just some questions. - Kinit.java: line 56, it should be "sun.security.krb5.internal.tools.Kinit"? - Kinit.java: for the switch block from 135 - 142: add a default case to catch illegal values? - Kinit.java: line 163, doesn't the credentials cache exist already? - KrbAsR