On 12/16/2014 07:12 PM, Vincent Ryan wrote:
I’ve generated a new webrev to address your comments below:
http://cr.openjdk.java.net/~vinnie/805/webrev.04/
Thanks.
On 16 Dec 2014, at 21:11, Sean Mullan wrote:
Here are my comments on the latest webrev:
* General
- for the engineProb
On 17 Dec 2014, at 18:59, Sean Mullan wrote:
> On 12/16/2014 07:12 PM, Vincent Ryan wrote:
>> I’ve generated a new webrev to address your comments below:
>> http://cr.openjdk.java.net/~vinnie/805/webrev.04/
>>
>> Thanks.
>>
>>
>> On 16 Dec 2014, at 21:11, Sean Mullan wrote:
>>
>>> He
Hi, Brad,
Can you please review this straightforward Ucrypto fix? This is about
adding aliases to the AES and RSA ciphers of OracleUcrypto provider.
Webrev: http://cr.openjdk.java.net/~valeriep/8043349/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8043349
Thanks,
Valerie
I think this is ok.
I have a recollection our Cipher.getInstance() provider selection
mechanism (getTransforms()) allows for missing options:
"AES//NoPadding" "AES/ECB/" But it's been a while since I've looked at
this. These ucrypto values look like they must be completely specified.
Is t
Thanks for the review~
Well, as for allowing the missing options, I am not sure how useful or
how frequently people use them. As for me, I find them a bit too
ambiguous to my liking. I think there are other more useful bugs to fix
than spending time on this. So far, no bug report regarding sup
FYI I’ve updated the webrev to include the changes below:
http://cr.openjdk.java.net/~vinnie/805/webrev.05/
On 17 Dec 2014, at 20:08, Vincent Ryan wrote:
> On 17 Dec 2014, at 18:59, Sean Mullan wrote:
>
>> On 12/16/2014 07:12 PM, Vincent Ryan wrote:
>>> I’ve generated a new webrev to
> On Dec 17, 2014, at 07:32, Matthew Hall wrote:
>
>>> Many StackOverflows exist of people doing it manually to "work around" this
>>> limitation.
>>
>> In fact, I searched for "create empty keystore" on stackoverflow and didn't
>> notice such a requirement.
>
> The ones I ran across were fo
Looks fine to me.
Sorry for the delay of the code review.
Xuelei
On 12/11/2014 11:20 AM, Valerie Peng wrote:
>
> Still looking for a reviewer for this fix...
>
> Thanks,
> Valerie
>
> On 8/22/2014 1:50 PM, Valerie Peng wrote:
>> Ping again. Anyone has time to review?
>>
>> The webrev has been
> On Dec 18, 2014, at 07:58, Vincent Ryan wrote:
>
> FYI I’ve updated the webrev to include the changes below:
>http://cr.openjdk.java.net/~vinnie/805/webrev.05/
PKCS12KeyStore.PKCS12_HEADER_PATTERNS.
Is there a possibility for this?
30 82 -- -- 02 01 03 30 81 -- 06 09 2A 86 48 86 F7
