Re: RFR 8087157: PKCS11 provider not instantiated with security manager

2015-06-16 Thread Sean Mullan
On 06/15/2015 04:54 PM, Valerie Peng wrote: Sean, Given how trivial this is, I initially covered it in the fix for 7191662. However, fix for 7191662 took longer than anticipated to go in and now SQE has filed a bug for this. Thus, I separated this out into a separate webrev. Can u please take a

Re: RFR: 8046943: RSA Acceleration

2015-06-16 Thread Andrew Haley
On 06/15/2015 05:58 PM, Andrew Haley wrote: >>> 3. I fused squaring and multiplication into a single >>> >> montgomeryMultiply method. ... >> > >> > I don't agree with fusing them together. I think there should two >> > separate intrinsics. For one, SPARC has a montsqr and montmul >> > instr

RFR: 8072692: Improve performance of SecurityManager.checkPackageAccess

2015-06-16 Thread Sean Mullan
This is the sixth in a series of fixes for JEP 232 (Improve Secure Application Performance) [1]. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8072692/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8072692 This fix adds several optimizations to the package matching algorithm use

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-16 Thread Mandy Chung
I skimmed it and looks okay to me. Thanks for separating this build work and avoid interfering the jimage refresh work. Mandy > On Jun 15, 2015, at 4:58 PM, Valerie Peng wrote: > > > It seems that the jimage refresh change may still take some time, so we will > end up removing the makefile

Re: [9] RFR: 8074784: Additional tests for XML DSig API

2015-06-16 Thread Sean Mullan
On 05/20/2015 04:16 PM, Artem Smotrakov wrote: Hi Sean, Yes, at first, I thought about updating the existing tests in test/javax/xml/crypto/dsig directory. But then I noticed that both GenerationTests and ValidationTests has ~30 test cases. And new Detached.java test contains >30 test cases. If

Re: RFR: 8072692: Improve performance of SecurityManager.checkPackageAccess

2015-06-16 Thread Thomas Lußnig
Hi, two points that come directly to my mind when i checked the code: 1) An Error in the description. +// If plast >= plen then restrictedPkg is longer than pkg by at +// least one char. This means pkg cannot start with restrictedPkg, +// since restrictedPkg w

Re: RFR: 8072692: Improve performance of SecurityManager.checkPackageAccess

2015-06-16 Thread Daniel Fuchs
On 16/06/15 18:49, Thomas Lußnig wrote: Hi, two points that come directly to my mind when i checked the code: 1) An Error in the description. +// If plast >= plen then restrictedPkg is longer than pkg by at +// least one char. This means pkg cannot start with restricted

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-16 Thread Sean Mullan
On 06/15/2015 07:58 PM, Valerie Peng wrote: It seems that the jimage refresh change may still take some time, so we will end up removing the makefile related changes and then deferring the ServiceLoader related changes to Jake workspace. Here is the latest webrev (Security source/test changes o

Re: RFR: 8072692: Improve performance of SecurityManager.checkPackageAccess

2015-06-16 Thread Weijun Wang
1478 final int plast = restrictedPkg.length() - 1; Why is it named plast? 1494//- we check that restrictedPkg.length is pkg.length + 1, 1495//- we check that restrictedPkg starts with pkg, 1496//- and we check that the last character in restrictedPkg 1497/

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-16 Thread Valerie Peng
It's to make the runtime configuration of 3rd party PKCS11 provider easier on non-Solaris systems. With this entry, callers can simply do Security.getProvider("SunPKCS11") and then call Provider.configure with their own configuration file. Otherwise, they will have to use reflection, e.g. Cl