RFR 8146377: test/sun/security/tools/jarsigner/concise_jarsigner.sh failing

2016-01-04 Thread Wang Weijun
Hi Please review the fix of https://bugs.openjdk.java.net/browse/JDK-8146377. Some years have more days than 365 and the test fails. The fix is simply diff --git a/test/sun/security/tools/jarsigner/concise_jarsigner.sh b/test/sun/security/tools/jarsigner/concise_jarsigner.sh --- a/test/sun/secu

Re: RFR 8146377: test/sun/security/tools/jarsigner/concise_jarsigner.sh failing

2016-01-04 Thread Xuelei Fan
An interesting bug. Looks fine to me. Xuelei On 1/1/2016 1:26 AM, Wang Weijun wrote: > Hi > > Please review the fix of https://bugs.openjdk.java.net/browse/JDK-8146377. > Some years have more days than 365 and the test fails. The fix is simply > > diff --git a/test/sun/security/tools/jarsigne

Re: RFR 8146377: test/sun/security/tools/jarsigner/concise_jarsigner.sh failing

2016-01-04 Thread Wang Weijun
> On Jan 4, 2016, at 4:19 PM, Xuelei Fan wrote: > > An interesting bug. Looks fine to me. Yes, I could have closed it as "Not Reproducible" and wait for another 4 years to fix it. --Max > > Xuelei > > On 1/1/2016 1:26 AM, Wang Weijun wrote: >> Hi >> >> Please review the fix of https://bu

Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-04 Thread Wang Weijun
I have no more comment. --Max > On Jan 3, 2016, at 3:48 PM, Sibabrata Sahoo > wrote: > > Updated the bug title and description. > > Thanks, > Siba > > -Original Message- > From: Wang Weijun > Sent: Sunday, January 03, 2016 1:02 PM > To: Sibabrata Sahoo > Cc: Mandy Chung; Valerie Pen

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-04 Thread Sibabrata Sahoo
Hi Valerie, If everything looks fine in the current version of webrev then can you please help me push the changes to JAKE repo. Thanks, Siba -Original Message- From: Wang Weijun Sent: Monday, January 04, 2016 2:36 PM To: Sibabrata Sahoo Cc: Mandy Chung; Valerie Peng; jigsaw-...@openjd

RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/8145544/00/ Note: as in other areas some tests that

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Sean Mullan
On 01/04/2016 09:02 AM, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/814554

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Wang Weijun
I am OK with the change for krb5 in both src and test. Thanks Max > On Jan 4, 2016, at 10:02 PM, Chris Hegarty wrote: > > sun.misc.VM provides a low-level interface for a small number > of specific operations with the VM. In preparation for JEP 260, > this class should be moved out of sun.misc

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
On 04/01/16 14:12, Sean Mullan wrote: On 01/04/2016 09:02 AM, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. ht

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Alan Bateman
On 04/01/2016 14:02, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http://cr.openjdk.java.net/~chegar/8145544

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Sean Mullan
On 01/04/2016 09:14 AM, Chris Hegarty wrote: Note: as in other areas some tests that require access to internal APIs have been updated to use types from a more stable package, sun.security.x509. Not sure what you mean - which tests do you mean and why is sun.security.x509 related to this issue?

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

2016-01-04 Thread Chris Hegarty
On 04/01/16 14:16, Alan Bateman wrote: On 04/01/2016 14:02, Chris Hegarty wrote: sun.misc.VM provides a low-level interface for a small number of specific operations with the VM. In preparation for JEP 260, this class should be moved out of sun.misc and located in a non-exported package [. http

Re: RFR: 8129560- CKR_ARGUMENTS_BAD - private exponent needs to comply with FIPS 186-4

2016-01-04 Thread Sean Mullan
On 12/20/2015 11:42 PM, Bhanu Gopularam wrote: Hi Sean, The present fix solves the test issue which is happening in newer Solaris version viz., 11.3/12 which has FIPS guidelines as a prerequisite. With your permission I shall leave the JDK-8074580 (test stabilization issue) in current state, a

Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-04 Thread Valerie Peng
Well, for Jake repo, it will have to be either Mandy or Sean (Mullan). I can't push to that repo... Valerie On 1/4/2016 1:13 AM, Sibabrata Sahoo wrote: Hi Valerie, If everything looks fine in the current version of webrev then can you please help me push the changes to JAKE repo. Thanks, Sib

Re: Design and impl review: JEP 273: DRBG-Based SecureRandom Implementations

2016-01-04 Thread Sean Mullan
Here are some more comments on the API: * EntropyInput: 29 * An interface of a source of entropy input. "interface" is implied, so you can just say "A source of entropy input." Also, I think this interface should be called "EntropySource". To me, "Input" means the byte array that is alread

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2016-01-04 Thread Mark Sheppard
Hi, as per feedback below webrev has been updated http://cr.openjdk.java.net/~msheppar/8134577/webrev.06/ change summary: * List nameServices replaced with Nameservice nameService * references to nameServices removed * private interface NameService added, with two implementation PlatformN

Re: Design and impl review: JEP 273: DRBG-Based SecureRandom Implementations

2016-01-04 Thread Wang Weijun
> On Jan 5, 2016, at 6:59 AM, Sean Mullan wrote: > > Here are some more comments on the API: > > * EntropyInput: > > 29 * An interface of a source of entropy input. > > "interface" is implied, so you can just say "A source of entropy input." > Also, I think this interface should be called