Looks fine to me. Thanks!
Xuelei
> On Jun 7, 2016, at 2:45 PM, Sibabrata Sahoo
> wrote:
>
> Hi Xuelei,
>
> Please find the updated webrev:
> http://cr.openjdk.java.net/~ssahoo/8157896/webrev.01/
>
> As suggested, I have increased the timeout for (3072 256) to 700.
>
> Thanks,
> Siba
>
>
Hi,
there is some lingering concern that this and related changes make it
that much easier to accidentally leak the system Properties object
outside of core modules. By wrapping access to the system Properties
object in a class residing in a non-exported package we disallow this at
little to
Simple fix/test.
We missed copying the ALPN values from the SSLServerSocket to the SSLSocket.
The test is essentially SSLSocketAlpnTest.java but setting the
SSLParameters on SSLServerSocket instead of SSLSocket.
https://bugs.openjdk.java.net/browse/JDK-8158978
http://cr.openjdk.java.
> So I think it is not working.
Thanks for letting us know, and providing a reproducible test case. I
have filed:
JDK-8158978: ALPN not working when values are set directly
on SSLServerSocket
and a code review will follow shortly.
BTW, your code didn't actually start
Hi Claes,
What's the necessary to get all system properties for just one specific
one? Can you explain more about the necessary to make the change?
Thanks,
Xuelei
On 6/8/2016 3:44 AM, Claes Redestad wrote:
> Hi,
>
> there is some lingering concern that this and related changes make it
> that m
Looks fine to me.
Thanks,
Xuelei
On 6/8/2016 4:13 AM, Bradford Wetmore wrote:
>
> Simple fix/test.
>
> We missed copying the ALPN values from the SSLServerSocket to the
> SSLSocket.
>
> The test is essentially SSLSocketAlpnTest.java but setting the
> SSLParameters on SSLServerSocket instead of
