Re: RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http [v2]

2020-12-01 Thread Patrick Concannon
On Mon, 30 Nov 2020 13:04:11 GMT, Kartik Ohri wrote: >> Hi! >> Kindly review this patch to replace switch statements with switch >> expressions (where it makes sense) in the http client modules. The rationale >> is to improve readability of the code. >> Regards, >> Kartik > > Kartik Ohri has r

Re: RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http

2020-12-01 Thread Daniel Fuchs
On Tue, 1 Dec 2020 01:51:35 GMT, John Jiang wrote: > Do we have clear guideline or requirement for using this new lang feature? > We know there are a lot of old switch-case blocks in the existing codes, > including source codes and test codes. @johnshajiang I don't think we have any global guide

RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
Certain TLS ALPN values can't be properly read or written by the SunJSSE provider. This is due to the choice of Strings as the API interface and the undocumented internal use of the UTF-8 Character Set which converts characters larger than U+7F into multi-byte arrays that may not be expected

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Thu, 26 Nov 2020 20:26:36 GMT, Xue-Lei Andrew Fan wrote: >> Certain TLS ALPN values can't be properly read or written by the SunJSSE >> provider. This is due to the choice of Strings as the API interface and the >> undocumented internal use of the UTF-8 Character Set which converts >> chara

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Daniel Fuchs
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Thu, 26 Nov 2020 10:33:26 GMT, Daniel Fuchs wrote: >> Certain TLS ALPN values can't be properly read or written by the SunJSSE >> provider. This is due to the choice of Strings as the API interface and the >> undocumented internal use of the UTF-8 Character Set which converts >> characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

RFR: 8242332: Add SHA3 support to SunPKCS11 provider

2020-12-01 Thread Valerie Peng
Could someone please help review this RFE? SunPKCS11 provider is updated with SHA-3 support, including MessageDigest, Hmac Mac, DSA/RSA/RSASSA-PSS/ECDSA Signature, and Hmac KeyGenerator. As SHA-3 can be used as drop-in replacement for SHA-2 which are already supported by SunPKCS11 provider, the

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Valerie Peng
On Thu, 26 Nov 2020 02:14:40 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with five > additional commits since the last revision: > > - test updates > - test check mixup > - Overlap protectio

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Valerie Peng
On Thu, 26 Nov 2020 02:14:40 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with five > additional commits since the last revision: > > - test updates > - test check mixup > - Overlap protectio

Re: RFR: 8242332: Add SHA3 support to SunPKCS11 provider

2020-12-01 Thread Valerie Peng
On Tue, 1 Dec 2020 21:51:41 GMT, Valerie Peng wrote: > Could someone please help review this RFE? SunPKCS11 provider is updated with > SHA-3 support, including MessageDigest, Hmac Mac, DSA/RSA/RSASSA-PSS/ECDSA > Signature, and Hmac KeyGenerator. > > As SHA-3 can be used as drop-in replacement

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Anthony Scarpino
On Tue, 1 Dec 2020 22:42:54 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Up

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Anthony Scarpino
On Tue, 1 Dec 2020 22:44:44 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Up

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Anthony Scarpino
On Tue, 1 Dec 2020 22:53:10 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Up

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Anthony Scarpino
On Tue, 1 Dec 2020 23:14:19 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Up

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

2020-12-01 Thread Anthony Scarpino
On Wed, 2 Dec 2020 00:02:52 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Up

Integrated: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-01 Thread Anthony Scarpino
On Thu, 26 Nov 2020 02:18:00 GMT, Anthony Scarpino wrote: >> The latest update should address all outstanding comments. The biggest >> change was to the test, which had major reorganization and created tests >> that increments data sizes for update and doFinal ops byte-by-byte to check >> fo

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-01 Thread Anthony Scarpino
> 8253821: Improve ByteBuffer performance with GCM Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision: comments v4 - Changes: - all: https://git.openjdk.java.net/jdk/pull/411/files - new: https://git.openjdk.java.net