removal of the existing TEST.properties files look fine.
>
> Please also solicit feedback from the security libs team as their area is
> affected.
>
> Roger, FYI the serial filter tests are updated as part of this changeset.
>
> Cheers,
>
> -Joe
>
> On 12/23/2019 8
ires_names
Thanks,
-- Igor
> On Jan 14, 2020, at 2:17 PM, Sean Mullan wrote:
>
> dropping core-libs-dev and hotspot-dev
>
> On 1/14/20 12:03 PM, Igor Ignatyev wrote:
>> Joe and Roger, thank you for your reviews.
>> security-libs guys, could you please take a look?
>
Hi Felix,
I have suggested the exact opposite change[1-3] to fix the same problem.
[1] https://bugs.openjdk.java.net/browse/JDK-8181391
[2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048012.html
[3] http://cr.openjdk.java.net/~iignatyev//8181391/webrev.00/index.html
Thanks,
-
> On Jun 1, 2017, at 1:20 AM, Chris Hegarty wrote:
>
> Igor,
>
>> On 1 Jun 2017, at 04:32, Igor Ignatyev wrote:
>>
>> Hi Felix,
>>
>> I have suggested the exact opposite change[1-3] to fix the same problem.
>
> I’m sorry, but this is al
they will work stable till someone refactors them and extract some new classes.
that is to say, it's nearly impossible to have all explicit @build actions.
Cheers,
-- Igor
> On Jun 1, 2017, at 3:37 PM, Ioi Lam wrote:
>
>
>
> On 6/1/17 1:17 PM, Igor Ignatyev wrote:
>>&
http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html
> 81 lines changed: 37 ins; 23 del; 21 mod;
Hi all,
could you please review the fix which improves and refactors
DoPrivAccompliceTest.java test?
the test had several issues:
- it did not fail if the java spawned by JavaToolUti
t; "explicit" is reasonable for me. But "explicit" should not be restricted
> as "explicit all, including dependencies", as it is not productive or even
> realistic in the long term.
> Thanks,
> Felix
> On 2017/6/2 7:58, Igor Ignatyev wrote:
>>&g
> On Jun 2, 2017, at 9:14 AM, Ioi Lam wrote:
>
> On 6/2/17 8:44 AM, Ioi Lam wrote:
>>
>> On 6/2/17 6:40 AM, Chris Hegarty wrote:
>>> On 02/06/17 00:14, Ioi Lam wrote:
...
The gem is hidden in the compile.0.jta file. It contains something like:
-sourcepath :/jdk/f
I have measured how much time it takes to run :tier1 w/ and and w/o the fix
which removes @build for jdk.test.lib.** classes[1-2]:
- w/o 8181391, i.e. w/ @build: real 33m4.624s, user 111m56.758s, sys
6m24.022s. [3] is a breakdown for jtreg actions
- w/ 8181391, i.e. w/o @build: real 32m17.259s,
33m39.697s
user112m5.722s
sys 6m26.973s
[2]
compile: 903.9
build: 846.53
testng: 5515.98
junit: 674.429
shell: 885.103
main: 6973.12
clean: 0.001
driver: 9.125
> On Jun 2, 2017, at 6:45 PM, Igor Ignatyev wrote:
>
> I have measured how much time it takes to run :tier1 w/ an
Hi all,
could you please review the patch which moves `ClassFileInstaller` class to
`jdk.test.lib.helpers` package?
to reduce changes in the tests, `ClassFileInstaller` in the default package is
kept w/ just `main` method that calls `jdk.test.lib.helpers.
ClassFileInstaller::main`.
from JBS
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/
On Fri, 12 Mar 2021 02:08:09 GMT, Mikhailo Seledtsov
wrote:
>> Hi all,
>>
>> could you please review the patch which moves `ClassFileInstaller` class to
>> `jdk.test.lib.helpers` package?
>> to reduce changes in the tests, `ClassFileInstaller` in the default package
>> is kept w/ just `main`
Hi all,
could you please review this dull patch that replaces `ClassFileInstaller` w/
`jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
ensure we won't get split testlibrary, and removes
`jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used).
from J
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and
ssFileInstaller` is nowhere to be found, hence we
>> get NCDFE.
>
> testing:
> - [x] `grep ' ClassFileInstaller[^.]`
> - [ ] tier1-3
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with one additional
commit since the last revision:
ssFileInstaller` is nowhere to be found, hence we
>> get NCDFE.
>
> testing:
> - [x] `grep ' ClassFileInstaller[^.]`
> - [ ] tier1-3
>
> Thanks,
> -- Igor
Igor Ignatyev has refreshed the contents of this pull request, and previous
commits have been removed. The
On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains
On Sat, 13 Mar 2021 14:20:20 GMT, Daniel D. Daugherty
wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> I
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the following substitutions:
- `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
- `s/sun.hotspot.par
On Thu, 29 Jul 2021 01:30:37 GMT, Vladimir Kozlov wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>
g`
>
> testing: tier1-4
>
> Thanks,
> -- Igor
Igor Ignatyev has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains 12 new commits
sinc
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the
g`
>
> testing: tier1-4
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with two additional
commits since the last revision:
- copyright update
- fixed typo in ClassFileInstaller
-
Changes:
- all: https://git.openjdk.java.net/jdk17/p
On Mon, 2 Aug 2021 15:56:39 GMT, Vladimir Kozlov wrote:
> I agree with these revised changes for JDK 17.
Thanks for your review, Vladimir.
I'll rerun my testing before integrating (just for good luck).
-- Igor
-
PR: https://git.openjdk.java.net/jdk17/pull/290
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following subs
28 matches
Mail list logo
