[9] RFR: 8075301: Tests for sun.security.krb5.principal system property

2015-06-29 Thread Sibabrata Sahoo
Hello, Please review this fix for 9. The test uses JAAS authentication over Kerberos. The kerberos5 principal name can be specified in the configuration entry by using the option principal. The principal can also be set using the system property sun.security.krb5.principal. This property

RE: [9] RFR: 8075301: Tests for sun.security.krb5.principal system property

2015-06-30 Thread Sibabrata Sahoo
] Thanks, Siba -Original Message- From: Weijun Wang Sent: Tuesday, June 30, 2015 7:45 AM To: Sibabrata Sahoo; Security Libs OpenJDK Subject: Re: [9] RFR: 8075301: Tests for sun.security.krb5.principal system property Hi Siba There is one case not covered: 1. sun.security.krb5.pri

[12] RFR: 8211787: javax/net/ssl/TLSCommon/TLSTest.java throws java.net.SocketTimeoutException: Read timed out

2018-11-14 Thread Sibabrata Sahoo
Hi Xuelei, Please review a minor fix for, JBS: https://bugs.openjdk.java.net/browse/JDK-8211787 Webrev: http://cr.openjdk.java.net/~ssahoo/8211787/webrev.00/ The original intention to "setSoTimeout()" is on serverSocket where the server will fail with timeout if it exceed certain amount

[13]RFR:8224650:Add tests to support X25519 and X448 in TLS

2019-06-21 Thread Sibabrata Sahoo
Hi Xuelei/Brad, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8224650 Webrev: http://cr.openjdk.java.net/~ssahoo/8224650/webrev.00/ This is a small Test inherited from "SSLSocketTemplate" and reuse most part of it. The only difference is, it uses supported

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-11-30 Thread Sibabrata Sahoo
Here is the updated webrev: http://cr.openjdk.java.net/~asmotrak/siba/8130360/webrev.02/ I have one question: What should be the behavior when the older version of 3rd party JCE provider jar file(without service descriptor "META-INF/services/*" & working with <= JDK8) configured by "java.securi

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-11-30 Thread Sibabrata Sahoo
nt: Monday, November 30, 2015 4:54 PM To: Sibabrata Sahoo; [email protected]; [email protected] Subject: Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs On 30/11/2015 11:13, Sibabrata Sahoo wrote: > Here i

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-08 Thread Sibabrata Sahoo
quot; file should have the provider configuration entry as ProviderName while in case of ClassPath the entry should hold the full class name. Thanks, Siba -Original Message- From: Valerie Peng Sent: Tuesday, December 08, 2015 4:46 AM To: Sibabrata Sahoo Cc: Alan Bateman; security-dev@openjd

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-09 Thread Sibabrata Sahoo
- Sign jar functionality removed. Thanks, Siba -Original Message- From: Valerie Peng Sent: Wednesday, December 09, 2015 5:37 AM To: Sibabrata Sahoo Cc: [email protected]; [email protected]; Alan Bateman Subject: Re: [9] RFR:8130360: Add tests to verify 3rd party security

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-19 Thread Sibabrata Sahoo
/security/auth/login/modules/src/" and all its subfolders need to be removed. - Test converted to use TestNG framework. Thanks, Siba -Original Message----- From: Mandy Chung Sent: Wednesday, December 09, 2015 11:55 PM To: Sibabrata Sahoo Cc: Valerie Peng; [email protected]; se

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-19 Thread Sibabrata Sahoo
Hi Mandy/Max, Here is the updated webrev with very minor change over previous: http://cr.openjdk.java.net/~asmotrak/siba/8130360/webrev.04/ Thanks Siba -Original Message- From: Sibabrata Sahoo Sent: Sunday, December 20, 2015 1:34 AM To: Mandy Chung; Weijun Wang Cc: Valerie Peng

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-21 Thread Sibabrata Sahoo
. SecurityProviderModularTest and JaasModularClientTest. Thanks, Siba -Original Message- From: Wang Weijun Sent: Monday, December 21, 2015 7:20 AM To: Sibabrata Sahoo Cc: Mandy Chung; Valerie Peng; [email protected]; [email protected] Subject: Re: [9] RFR:8130360: Add tests to verify 3rd

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-02 Thread Sibabrata Sahoo
nuary 02, 2016 3:11 PM To: Sibabrata Sahoo Cc: Mandy Chung; Valerie Peng; [email protected]; OpenJDK Subject: Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs Looks better. One question: the bug description mentions

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-02 Thread Sibabrata Sahoo
Updated the bug title and description. Thanks, Siba -Original Message- From: Wang Weijun Sent: Sunday, January 03, 2016 1:02 PM To: Sibabrata Sahoo Cc: Mandy Chung; Valerie Peng; [email protected]; OpenJDK Subject: Re: [9] RFR:8130360: Add tests to verify 3rd party security

RE: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2016-01-04 Thread Sibabrata Sahoo
Hi Valerie, If everything looks fine in the current version of webrev then can you please help me push the changes to JAKE repo. Thanks, Siba -Original Message- From: Wang Weijun Sent: Monday, January 04, 2016 2:36 PM To: Sibabrata Sahoo Cc: Mandy Chung; Valerie Peng; jigsaw

[9] RFR: 8150512:Update test for jdk.security.provider.preferred security property.

2016-02-25 Thread Sibabrata Sahoo
Hello, Please review the updated test to verify "jdk.security.provider.preferred" security property in all platform. Bug: https://bugs.openjdk.java.net/browse/JDK-8150512 Webrev: http://cr.openjdk.java.net/~ssahoo/8150512/webrev.00/ These test were initially planned to run on Solaris

RE: [9] RFR: 8150512:Update test for jdk.security.provider.preferred security property.

2016-03-15 Thread Sibabrata Sahoo
Hi Anthony, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8150512/webrev.01/ Following comments associated. Thanks, Siba --- Here are my comments... - PreferredProviderTest.java:62-70 You appear to be missing SHA1 and SHA-224. They should be added to the

[9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-08 Thread Sibabrata Sahoo
Hello, Please review the tests for "JDK-8141039:Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations". Bug: https://bugs.openjdk.java.net/browse/JDK-8141039 Webrev: http://cr.openjdk.java.net/~ssahoo/8141039/webrev.00/ The tests covers the new DRBG API wit

RE: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-11 Thread Sibabrata Sahoo
e it accordingly. Thanks, Siba -Original Message- From: Wang Weijun Sent: Tuesday, May 10, 2016 1:14 PM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations For all:

RE: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-16 Thread Sibabrata Sahoo
andom/ ". - Removed all reference to MoreDrbgParameters and EntropySource. Thanks, Siba -Original Message- From: Wang Weijun Sent: Thursday, May 12, 2016 9:14 AM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [9] RFR: 8141039: Test Task: Develop new tests f

RE: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-17 Thread Sibabrata Sahoo
urity/SecureRandom ". - Removed reference to MoreDrbgParameters from ApiTest.java Thanks, Siba -Original Message- From: Wang Weijun Sent: Monday, May 16, 2016 6:36 PM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [9] RFR: 8141039: Test Task: Develop new tests f

RE: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-19 Thread Sibabrata Sahoo
RBG. So I am keeping the file unchanged. Thanks, Siba -Original Message- From: Wang Weijun Sent: Wednesday, May 18, 2016 1:37 PM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementa

RE: [9] RFR: 8141039: Test Task: Develop new tests for JEP 273: DRBG-Based SecureRandom Implementations

2016-05-19 Thread Sibabrata Sahoo
Hi Max, Here is the updated webrev: http://cr.openjdk.java.net/~ssahoo/8141039/webrev.05/ Can you please help me push the change. Thanks, Siba -Original Message- From: Wang Weijun Sent: Thursday, May 19, 2016 1:19 PM To: Sibabrata Sahoo Cc: [email protected] Subject: Re

[9] RFR: 8157417: Some of SecureRandom test might get timed out in linux.

2016-05-20 Thread Sibabrata Sahoo
Hi, Please review the following fix for SecureRandom test which might cause timeout in Linux. webrev: http://cr.openjdk.java.net/~ssahoo/8157417/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8157417 The change includes: - Added "-Djava.security.egd=file:/dev/urand

RE: [9] RFR: 8157417: Some of SecureRandom test might get timed out in linux.

2016-05-20 Thread Sibabrata Sahoo
I missed to include one more test. Here is the updated one: http://cr.openjdk.java.net/~ssahoo/8157417/webrev.01/ sun/security/provider/SeedGenerator/SeedGeneratorChoice.java might also fail in Linux without the fix provided. Thanks, Siba From: Sibabrata Sahoo Sent: Friday, May 20

[9] RFR: 8157896: TestDSAGenParameterSpec.java test fails with timeout

2016-05-31 Thread Sibabrata Sahoo
Hi, Please review the fix for the following JBS bugs, JBS: https://bugs.openjdk.java.net/browse/JDK-8157896 https://bugs.openjdk.java.net/browse/JDK-8157898 webrev: http://cr.openjdk.java.net/~ssahoo/8157896/webrev.00/ Description: These Tests takes a lots of time to generat

RE: [9] RFR: 8157896: TestDSAGenParameterSpec.java test fails with timeout

2016-06-06 Thread Sibabrata Sahoo
Hi Xuelei, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8157896/webrev.01/ As suggested, I have increased the timeout for (3072 256) to 700. Thanks, Siba -Original Message- From: Xuelei Fan Sent: Saturday, June 04, 2016 6:02 AM To: Sibabrata Sahoo; Valerie Peng

[9] RFR: 8159861: sun/security/tools/keytool/DefaultSignatureAlgorithm.java timeout

2016-07-04 Thread Sibabrata Sahoo
Hi, Please review this patch for "8159861: sun/security/tools/keytool/DefaultSignatureAlgorithm.java timeout" JBS: https://bugs.openjdk.java.net/browse/JDK-8159861 Webrev: http://cr.openjdk.java.net/~ssahoo/8159861/webrev.00/ Description: The test generates several set of keypair amo

[9] RFR: 8160341: Remove intermittent key from TestDSAGenParameterSpec.java

2016-07-04 Thread Sibabrata Sahoo
Hi, Please review this patch for "8160341: Remove intermittent key from TestDSAGenParameterSpec.java" JBS: https://bugs.openjdk.java.net/browse/JDK-8160341 Webrev: http://cr.openjdk.java.net/~ssahoo/8160341/webrev.00/ Description: Removing intermittent keyword from the test. Than

[9] RFR: 8160624: sun/security/tools/keytool/printssl.sh failed with "Socket closed"

2016-07-04 Thread Sibabrata Sahoo
Hi, Please review this patch for "8160624: sun/security/tools/keytool/printssl.sh failed with "Socket closed" JBS: https://bugs.openjdk.java.net/browse/JDK-8160624 Webrev: http://cr.openjdk.java.net/~ssahoo/8160624/webrev.00/ Description: The test is for "keytool should be able to im

[9] RFR: 8158116: com/sun/crypto/provider/KeyAgreement/SupportedDHParamGens.java failed with timeout

2016-07-04 Thread Sibabrata Sahoo
Hi, Please review this patch for "8158116: com/sun/crypto/provider/KeyAgreement/SupportedDHParamGens.java failed with timeout" JBS: https://bugs.openjdk.java.net/browse/JDK-8158116 Webrev: http://cr.openjdk.java.net/~ssahoo/8158116/webrev.00/ Description: This JBS bug does not have

[9] RFR: 8160210: javax/net/ssl/HttpsURLConnection/Equals.java failed with "SSL peer shut down incorrectly"

2016-07-05 Thread Sibabrata Sahoo
Hi, Please review the patch for "8160210: javax/net/ssl/HttpsURLConnection/Equals.java failed with "SSL peer shut down incorrectly"" JBS: https://bugs.openjdk.java.net/browse/JDK-8160210 Webrev: http://cr.openjdk.java.net/~ssahoo/8160210/webrev.00/ Description: This is a rare failur

[9] RFR: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]"

2016-07-05 Thread Sibabrata Sahoo
Hi, Please review the patch for "8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]"" JBS: https://bugs.openjdk.java.net/browse/JDK-8079441 Webrev: http://cr.openjdk.java.net/~ssahoo/8079441/webrev.00/ Description: This is a rare failure

[9] RFR: 8160940: Enable debug log in javax/net/ssl/HttpsURLConnection/Equals.java to track JDK-8160210

2016-07-07 Thread Sibabrata Sahoo
al Message- From: Xuelei Fan Sent: Tuesday, July 05, 2016 6:03 PM To: Sibabrata Sahoo; [email protected] Subject: Re: [9] RFR: 8160210: javax/net/ssl/HttpsURLConnection/Equals.java failed with "SSL peer shut down incorrectly" You may also want to dump the SSL record so t

[9] RFR: 8151654: Additional modular test for "auth.login.defaultCallbackHandler" property

2016-07-14 Thread Sibabrata Sahoo
Hi, Please review the following patch for "Additional modular test for "auth.login.defaultCallbackHandler" property". JBS: https://bugs.openjdk.java.net/browse/JDK-8151654 Webrev: http://cr.openjdk.java.net/~ssahoo/8151654/webrev.00/ Description: A custom callback handler for JAAS ca

RE: [9] RFR: 8151654: Additional modular test for "auth.login.defaultCallbackHandler" property

2016-07-22 Thread Sibabrata Sahoo
sage- From: Wang Weijun Sent: Sunday, July 17, 2016 1:12 PM To: Sibabrata Sahoo Cc: [email protected]; Mandy Chung; Valerie Peng Subject: Re: [9] RFR: 8151654: Additional modular test for "auth.login.defaultCallbackHandler" property Why change C_BUILD_DIR to C_BLD_DI

[9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto"

2016-08-05 Thread Sibabrata Sahoo
Hi, Please review the patch for "deprivilege java.xml.crypto, java.security.jgss, jdk.security.jgss and jdk.security.auth" modules. JBS: https://bugs.openjdk.java.net/browse/JDK-8159964 Webrev: http://cr.openjdk.java.net/~ssahoo/8159964/webrev.00/ Description: This includes a new Tes

RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto"

2016-08-05 Thread Sibabrata Sahoo
Hi Max, Here is the updated webrev: http://cr.openjdk.java.net/~ssahoo/8159964/webrev.01/ Thanks, Siba -Original Message- From: Weijun Wang Sent: Friday, August 05, 2016 4:19 PM To: Sibabrata Sahoo; [email protected]; Valerie Peng Subject: Re: [9] RFR: 8159964: Update

RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto"

2016-08-08 Thread Sibabrata Sahoo
Ping.. -Original Message- From: Sibabrata Sahoo Sent: Friday, August 05, 2016 7:28 PM To: Weijun Wang; [email protected]; Valerie Peng Subject: RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto" Hi Max, Here is t

RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto"

2016-08-10 Thread Sibabrata Sahoo
.net/~ssahoo/8159964/webrev.02/ Thanks, Siba -Original Message- From: Wang Weijun Sent: Tuesday, August 09, 2016 1:21 PM To: Sibabrata Sahoo Cc: [email protected]; Valerie Peng Subject: Re: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 De

[9] RFR: 8153146 & 8087144 for sun/security/krb5/auto/MaxRetries.java

2016-08-15 Thread Sibabrata Sahoo
Hi, Please review the patch for 2 issues on "sun/security/krb5/auto/MaxRetries.java". JBS: https://bugs.openjdk.java.net/browse/JDK-8153146 https://bugs.openjdk.java.net/browse/JDK-8087144 Webrev: http://cr.openjdk.java.net/~ssahoo/8087144/webrev.00/ Description: MaxRetries

[9] RFR: 8006690: sun/security/krb5/auto/BadKdc* tests fails intermittently

2016-08-23 Thread Sibabrata Sahoo
Hi, Please review the patch for intermittent failures in "sun/security/krb5/auto/BadKdc*" JBS: https://bugs.openjdk.java.net/browse/JDK-8006690 Webrev: http://cr.openjdk.java.net/~ssahoo/8006690/webrev.00/ Description: Some times when the test machine is slow the number of retry for

[9] RFR: 8015595: Test sun/security/krb5/auto/Unreachable.java fails with Timeout error

2016-08-24 Thread Sibabrata Sahoo
Hi, Please review the patch for "sun/security/krb5/auto/Unreachable.java fails with Timeout error" JBS: https://bugs.openjdk.java.net/browse/JDK-8015595 Webrev: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.00/ Description: When a KDC port is unreachable, Kerberos login module de

RE: [9] RFR: 8015595: Test sun/security/krb5/auto/Unreachable.java fails with Timeout error

2016-08-26 Thread Sibabrata Sahoo
warning. 2) Removed the test from ProblemList.txt for MAC OS because of #1. 3) Uses only one KDC port in the configuration file. 4) Removed static "unreachable.krb5.conf" as the Test creates the file during runtime. Thanks, Siba From: Sibabrata Sahoo Sent:

RE: [9] RFR: 8015595: Test sun/security/krb5/auto/Unreachable.java fails with Timeout error

2016-08-29 Thread Sibabrata Sahoo
Hi Max, Please find the updated webrev addressing all comments bellow: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.01/ Thanks, Siba -Original Message- From: Weijun Wang Sent: Monday, August 29, 2016 6:36 AM To: Sibabrata Sahoo; [email protected] Subject: Re: [9] RFR

RE: [9] RFR: 8015595: Test sun/security/krb5/auto/Unreachable.java fails with Timeout error

2016-08-29 Thread Sibabrata Sahoo
Hi Max, Here is updated webrev: http://cr.openjdk.java.net/~ssahoo/8015595/webrev.02/ Addressed all the following comments. Thanks, Siba -Original Message- From: Weijun Wang Sent: Monday, August 29, 2016 6:14 PM To: Sibabrata Sahoo; [email protected] Subject: Re: [9] RFR

[9] RFR: 8164922: sun/security/provider/SecureRandom/AutoReseed.java failed with timeout in Ubuntu Linux.

2016-08-29 Thread Sibabrata Sahoo
Hi, Please review the patch for "sun/security/provider/SecureRandom/AutoReseed.java failed with timeout" JBS: https://bugs.openjdk.java.net/browse/JDK-8164922 Webrev: http://cr.openjdk.java.net/~ssahoo/8164922/webrev.00/ Description: The Test was blocked while generating seed. I have

RE: [9] RFR: 8164922: sun/security/provider/SecureRandom/AutoReseed.java failed with timeout in Ubuntu Linux.

2016-08-30 Thread Sibabrata Sahoo
: Tuesday, August 30, 2016 1:40 PM To: Sibabrata Sahoo; [email protected] Subject: Re: [9] RFR: 8164922: sun/security/provider/SecureRandom/AutoReseed.java failed with timeout in Ubuntu Linux. Please just use othervm, and remove the finally block. If oldegd is null the code change will

[9] RFR: 8156054: Test Task: Develop new tests for JEP C155: Remove FilePermission Pathname Canonicalization

2016-09-13 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8156054 Webrev: http://cr.openjdk.java.net/~ssahoo/8156054/webrev.00/ Description: It checks equals(), implies() and hashCode () of FilePermission when "jdk.io.permissionsUseCanonicalPath" set and un-set.

[9] RFR: 8165825: Remove the intermittent keyword from sun/security/krb5/auto/Unreachable.java

2016-09-13 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8165825 Webrev: http://cr.openjdk.java.net/~ssahoo/8165825/webrev.00/ Description: This is a simple fix for removing intermittent keyword from sun/security/krb5/auto/Unreachable.java file. Thanks, Si

[9] RFR: 8165660: Remove the intermittent keyword from sun/security/krb5/auto/MaxRetries.java

2016-09-13 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8165660 Webrev: http://cr.openjdk.java.net/~ssahoo/8165660/webrev.00/ Description: This is a simple fix for removing intermittent keyword from sun/security/krb5/auto/MaxRetries.java file. Thanks,

RE: [9] RFR: 8156054: Test Task: Develop new tests for JEP C155: Remove FilePermission Pathname Canonicalization

2016-09-13 Thread Sibabrata Sahoo
Hi Max, Here is the updated webrev: http://cr.openjdk.java.net/~ssahoo/8156054/webrev.01/ Thanks, Siba -Original Message- From: Weijun Wang Sent: Tuesday, September 13, 2016 4:25 PM To: Sibabrata Sahoo; [email protected] Subject: Re: [9] RFR: 8156054: Test Task: Develop

RE: [9] RFR: 8156054: Test Task: Develop new tests for JEP C155: Remove FilePermission Pathname Canonicalization

2016-09-14 Thread Sibabrata Sahoo
Hi Artem, I think building a String value from the actual result and displaying it against expected in the Log output will be more convenient here. Thanks, Siba From: Artem Smotrakov Sent: Tuesday, September 13, 2016 10:54 PM To: Sibabrata Sahoo; Weijun Wang; security-dev

[9] RFR 8170247: java/security/SecureRandom/ApiTest fails when run with unlimited policy.

2016-11-30 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8170247 Webrev: http://cr.openjdk.java.net/~ssahoo/8170247/webrev.00/ Description: The Test was failing to handle the expected failure for invalid parameters, when the SecureRandom parameter size is > algo

[9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file = recursive initialization

2016-12-02 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8168423 Webrev: http://cr.openjdk.java.net/~ssahoo/8168423/webrev.00/ Description: This webrev address all possible cases for Classloader with SecurityManager having combination of valid/malformed policy

[9] RFR 8161232: AsyncSSLSocketClose.java test fails timeout.

2016-12-20 Thread Sibabrata Sahoo
Hi, Please review the following patch, JBS: https://bugs.openjdk.java.net/browse/JDK-8161232 Webrev: http://cr.openjdk.java.net/~ssahoo/8161232/webrev.00/ Description: It was reported the Test was failing with timeout consistently on macOS. There is no log available anymore and the i

RE: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Sibabrata Sahoo
Hi Adam/Sean, This patch is waiting for your review. Thanks, Siba From: Sibabrata Sahoo Sent: Friday, December 02, 2016 6:56 PM To: Sean Mullan; [email protected] Subject: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file

RE: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-02-07 Thread Sibabrata Sahoo
LoaderTest.java, the code comments has been removed from @summary section. But it retains the same at line: 91-102. Thanks, Siba -Original Message- From: Sean Mullan Sent: Friday, January 27, 2017 12:07 AM To: Sibabrata Sahoo; Adam Petcher; [email protected] Subject: Re: [9] RFR

RE: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-02-08 Thread Sibabrata Sahoo
repository, in revision 16548 Regarding the following comment on " grant codeBase "file:./jars/*" ", we have already discussed and we are fine here to not make any change. Thanks, Siba -Original Message- From: Sean Mullan Sent: Wednesday, February 08, 2017 10:00 PM To: S

RE: RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with java.lang.Exception: Does not match

2017-06-05 Thread Sibabrata Sahoo
Change looks fine to me. But I am not the reviewer yet. Thanks, Siba -Original Message- From: Weijun Wang Sent: Tuesday, June 06, 2017 11:23 AM To: Security Dev OpenJDK Cc: Gustavo Galimberti; Sibabrata Sahoo Subject: RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with

[10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-07-15 Thread Sibabrata Sahoo
Hi, Please review the patch for the following, JBS: https://bugs.openjdk.java.net/browse/JDK-8183310 Webrev: http://cr.openjdk.java.net/~ssahoo/8183310/webrev.00/ Change description: The code has been changed significantly for cleaning up existing code and to simplify it. During clea

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-07-25 Thread Sibabrata Sahoo
Hi, This patch is pending for your review. Thanks, Siba From: Sibabrata Sahoo Sent: Saturday, July 15, 2017 4:00 PM To: Weijun Wang; Valerie Peng; [email protected] Subject: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better Hi

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-22 Thread Sibabrata Sahoo
additional Test case for regular jars in modulepath and modular jars in classpath, which verifies how the type get resolved. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, August 02, 2017 3:53 PM To: Sibabrata Sahoo Cc: Valerie Peng; [email protected] Subjec

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Sibabrata Sahoo
Hi Max, I have splitted the @run to convert each run to consume minimum time to avoid any timeout for rare cases. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, August 23, 2017 1:43 PM To: Sibabrata Sahoo Cc: Valerie Peng; [email protected] Subject: Re

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Sibabrata Sahoo
: Sibabrata Sahoo Cc: Valerie Peng; [email protected] Subject: Re: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better Then maybe you can also make setup() a separate @run. --Max > On Aug 23, 2017, at 4:17 PM, Sibabrata Sahoo > wrote: >

[11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-10 Thread Sibabrata Sahoo
Hi, Please review the change for the following patch, JBS: https://bugs.openjdk.java.net/browse/JDK-8194486 Webrev: http://cr.openjdk.java.net/~ssahoo/8194486/webrev.00/ Description: There are several failure occurred recently because the name service used by these Tests were not det

RE: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-10 Thread Sibabrata Sahoo
I will remove the commented lines. I think, it should be fine, if I do not submit the webrev again. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, January 10, 2018 9:07 PM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [11] RFR: 8194486: Several

RE: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-17 Thread Sibabrata Sahoo
ollowing 2 Test files inside the same folder. ReplayCacheExpunge.java ReplayCachePrecise.java Thanks, Siba -Original Message- From: Weijun Wang Sent: Thursday, January 11, 2018 11:33 AM To: Sibabrata Sahoo Cc: [email protected] Subject: Re: [11] RFR: 8194486: Several krb5 te

RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448

2018-03-26 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8184359 Webrev: http://cr.openjdk.java.net/~ssahoo/8184359/webrev.00/ All the Test files uses KeyAgreement, KeyPairGenerator, Several KeySpecs from SunJCE library to Test DiffieHellman, ECDH and XDH with cu

RE: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448

2018-04-02 Thread Sibabrata Sahoo
Hi Sean, My comments In-lined.. Thanks, Siba -Original Message- From: Sean Mullan Sent: Saturday, March 31, 2018 12:13 AM To: Sibabrata Sahoo ; Adam Petcher ; [email protected] Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and

RE: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448

2018-04-09 Thread Sibabrata Sahoo
y methods from Convert.java are using the library instead of defining it's own. 4) MultiThreadTest.java generates two key pairs and do two key agreement operations. Thanks, Siba -Original Message- From: Sean Mullan Sent: Thursday, April 05, 2018 8:46 PM To: Sibabrata

RE: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448

2018-04-16 Thread Sibabrata Sahoo
Sean Mullan Sent: Wednesday, April 11, 2018 1:42 AM To: Sibabrata Sahoo ; Adam Petcher ; [email protected] Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves: curve25519 and curve448 On 4/9/18 10:13 AM, Sibabrata Sahoo wrote: > Here is the new patch address

[11] RFR: JDK-8205111: Develop new Test to verify different key types for supported TLS protocols.

2018-06-20 Thread Sibabrata Sahoo
Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8205111 Webrev: http://cr.openjdk.java.net/~ssahoo/8205111/webrev.00/ Change: This Test file verifies all TLS protocols with the supported keytypes. Thanks, Siba

RE: [11] RFR: JDK-8205111: Develop new Test to verify different key types for supported TLS protocols.

2018-06-26 Thread Sibabrata Sahoo
ded to have the flexibility to change the parameter(Cipher) which are not in order(shuffled). Thanks, Siba -Original Message- From: Xuelei Fan Sent: Thursday, June 21, 2018 7:28 PM To: Sibabrata Sahoo ; [email protected] Subject: Re: [11] RFR: JDK-8205111: Develop new Test to v

[11] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure

2018-06-28 Thread Sibabrata Sahoo
Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8205653 Webrev: http://cr.openjdk.java.net/~ssahoo/8205653/webrev.00/ Change: The Test has been upgraded to address the following 2 cases, Add protocol support for TLSv1.3. The change is done in the config

RE: [11] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure

2018-06-28 Thread Sibabrata Sahoo
Hi Daniel, I am not a member of HYPERLINK "mailto:[email protected]"[email protected]. So the review posted is waiting for moderator's approval. Thanks, Siba From: Sibabrata Sahoo Sent: Thursday, June 28, 2018 8:40 PM To: [email protected]

RE: [11] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure

2018-06-28 Thread Sibabrata Sahoo
Resending the email after subscribing to HYPERLINK "mailto:[email protected]"[email protected] Thanks, Siba From: Sibabrata Sahoo Sent: Thursday, June 28, 2018 8:40 PM To: HYPERLINK "mailto:[email protected]"[email protected]; HYPERLINK

RE: [11] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure

2018-06-29 Thread Sibabrata Sahoo
May I get the approval from [email protected]. Thanks, Siba -Original Message- From: Xuelei Fan Sent: Thursday, June 28, 2018 9:27 PM To: Daniel Fuchs ; Sibabrata Sahoo ; [email protected]; [email protected]; [email protected]

[11] RFR: 8206355: SSLSessionImpl.getLocalPrincipal() throws NPE

2018-07-04 Thread Sibabrata Sahoo
Hi, Please review the change for the following patch, JBS: https://bugs.openjdk.java.net/browse/JDK-8206355 Webrev: http://cr.openjdk.java.net/~ssahoo/8206355/webrev.00/ It fixes SSLSessionImpl.getLocalPrincipal() implementation when client side authentication is not enabled. Than

[11] RFR: 8208496: New Test to verify concurrent behavior for TLS.

2018-08-02 Thread Sibabrata Sahoo
Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8208496 Webrev: http://cr.openjdk.java.net/~ssahoo/8208496/webrev.00/ This is a new Test which test concurrent behavior of TLS. It uses 50 client thread to access a single server port concurrently an

RE: [11] RFR: 8208496: New Test to verify concurrent behavior for TLS.

2018-08-03 Thread Sibabrata Sahoo
: Sibabrata Sahoo Cc: Xue-Lei Fan ; [email protected] Subject: Re: [11] RFR: 8208496: New Test to verify concurrent behavior for TLS. Hi Siba, Would it be better to check how many connections the server accepts? In your case, the server must accept 50 (no more no less) connections; otherwise

RE: [11] RFR: 8208496: New Test to verify concurrent behavior for TLS.

2018-08-03 Thread Sibabrata Sahoo
serverSocket.close() and serverSocket.accept() are not declared synchronized in java/net/ServerSocket.java. Thanks, Siba -Original Message- From: Xuelei Fan Sent: Friday, August 03, 2018 10:38 PM To: Sibabrata Sahoo ; John Jiang Cc: [email protected] Subject: Re: [11] RFR

RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

2022-03-09 Thread Sibabrata Sahoo
Domain value for system property jdk.https.negotiate.cbt is case-insensitive now. Included Test has been updated to address the change. - Commit messages: - 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive Changes: https://git.openjdk.j

Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v2]

2022-03-09 Thread Sibabrata Sahoo
> Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update HttpsC

Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v3]

2022-03-22 Thread Sibabrata Sahoo
> Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive [v2]

2022-03-22 Thread Sibabrata Sahoo
On Tue, 15 Mar 2022 19:46:09 GMT, Weijun Wang wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update HttpsCB.java > > src/java.base/share/clas

Integrated: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

2022-03-22 Thread Sibabrata Sahoo
On Wed, 9 Mar 2022 15:03:31 GMT, Sibabrata Sahoo wrote: > Domain value for system property jdk.https.negotiate.cbt is case-insensitive > now. Included Test has been updated to address the change. This pull request has now been integrated. Changeset: 86015e15 Author:Sibabrata Saho

RFR: 8281717: Cover logout method for several LoginModule

2022-03-24 Thread Sibabrata Sahoo
Added coverage to logout method. - Commit messages: - 8281717: Cover logout method for several LoginModule Changes: https://git.openjdk.java.net/jdk/pull/7940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7940&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8281717: Cover logout method for several LoginModule [v2]

2022-03-28 Thread Sibabrata Sahoo
> Added coverage to logout method. Sibabrata Sahoo has updated the pull request incrementally with two additional commits since the last revision: - Update AllPlatforms.java - Update AllPlatforms.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/7940/files -

Re: RFR: 8281717: Cover logout method for several LoginModule [v2]

2022-03-28 Thread Sibabrata Sahoo
On Thu, 24 Mar 2022 23:02:47 GMT, Rajan Halade wrote: >> Sibabrata Sahoo has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update AllPlatforms.java >> - Update AllPlatforms.java > > t

Re: RFR: 8281717: Cover logout method for several LoginModule [v3]

2022-03-28 Thread Sibabrata Sahoo
> Added coverage to logout method. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update AllPlatforms.java Updated exception handling to ignore the case where the running platform doesn't match the test case. In t

Re: RFR: 8284641: Doc errors in sun.security.ssl.SSLSessionContextImpl

2022-04-10 Thread Sibabrata Sahoo
On Mon, 11 Apr 2022 04:02:44 GMT, John Jiang wrote: > JDK-8228396 turned stateless resumption on by default, but the JavaDoc was > not modified accordingly. > And a "{" is missing for @systemProperty > jdk.tls.server.enableSessionTicketExtension. Marked as reviewed by ssahoo (Committer).

RFR: 8209935: Test to cover CodeSource.getCodeSigners()

2022-04-18 Thread Sibabrata Sahoo
A Test updated to cover the getCodeSigners. - Commit messages: - Update Implies.java - 8209935: Test to cover CodeSource.getCodeSigners() Changes: https://git.openjdk.java.net/jdk/pull/8286/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8286&range=00 Issue: https://

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v2]

2022-04-18 Thread Sibabrata Sahoo
On Mon, 18 Apr 2022 13:22:35 GMT, Sibabrata Sahoo wrote: >> A Test updated to cover the getCodeSigners. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update Implies.java All comments addresse

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v2]

2022-04-18 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update Implies.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/8286/files - new: ht

RFR: 8286969: Add a new test library API to execute kinit in SecurityTools.java

2022-05-18 Thread Sibabrata Sahoo
A new API to execute kinit. - Commit messages: - 8286969: Add a new test library API to execute kinit in SecurityTools.java Changes: https://git.openjdk.java.net/jdk/pull/8775/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8775&range=00 Issue: https://bugs.openjdk.ja

Integrated: 8286969: Add a new test library API to execute kinit in SecurityTools.java

2022-05-18 Thread Sibabrata Sahoo
On Wed, 18 May 2022 16:19:40 GMT, Sibabrata Sahoo wrote: > A new API to execute kinit. This pull request has now been integrated. Changeset: dbda0e2b Author: Sibabrata Sahoo URL: https://git.openjdk.java.net/jdk/commit/dbda0e2bda5d8ba86f068684941a05387947d993 Stats: 12 lines

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v3]

2022-06-08 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the l

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-08 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: 8209935: Test to cover CodeSource.getCodeSigners() - Changes: - all: https://git.openjdk.java.net/jdk/pull/8286/fi

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sibabrata Sahoo
On Thu, 9 Jun 2022 21:12:26 GMT, Sean Mullan wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8209935: Test to cover CodeSource.getCodeSigners() > > test/jdk/java/security/Code

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v5]

2022-06-09 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with two additional commits since the last revision: - 8209935: Test to cover CodeSource.getCodeSigners() - 8209935: Test to cover CodeSource.getCodeSigners() - Chan

  1   2   >