RE: [EXTERNAL] Re: Is there a KEM (Key Encapsulation Mechanism) architecture being proposed for the JCA?

2022-08-19 Thread John Gray
Thanks David for your Support. I have been developing cryptographic algorithms in our Entrust Java toolkit since the early 2000’s, so between us we have a lot of years of experience using the JCA. 😊 Mike, a KEM is not a Cipher. I think of it as a kind of middle ground between a Key Agreem

Re: Is there a KEM (Key Encapsulation Mechanism) architecture being proposed for the JCA?

2022-08-19 Thread David Hook
Hi Mike, KEMs can be used for key wrapping - we've actually implemented support for this too. But they are not actually key wrapping ciphers. Here's a simple example of using Kyber for key wrapping in BC: SecretKey key =new SecretKeySpec(keyBytes,"AES"); w1.init(Cipher.WRAP_MODE, kp.getPubli

Re: RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v6]

2022-08-19 Thread Valerie Peng
On Fri, 19 Aug 2022 08:40:39 GMT, Josef Eisl wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated to address review comments. > > src/java.base/share/classes/java/security/Provider.java line 1276: > >> 1274:

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v16]

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >

Re: Is there a KEM (Key Encapsulation Mechanism) architecture being proposed for the JCA?

2022-08-19 Thread Mike StJohns
Hi This implemented as part of Javax.crypto.Cipher. See the Java doc for the wrap and unwrap methods. Mike Sent from my iPad > On Aug 19, 2022, at 12:56, John Gray wrote: > >  We are starting to make use of the new PQ algorithms adopted by NIST for > prototyping and development of standa

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 20:29:18 GMT, Jayashree Huttanagoudar wrote: > I have included your suggestions for the test case. > Since we are using `PrintStream` the `flush` is automatically called itseems > so I didn't see any exception trace in the .jtr file when the test case fails. This is because

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v16]

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-19 Thread Jayashree Huttanagoudar
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v16]

2022-08-19 Thread Jayashree Huttanagoudar
> Could you please review the changes? > This patch is to address : > https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision: Address review comments

Integrated: 8292683: Remove BadKeyUsageTest.java from Problem List

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 19:01:10 GMT, Weijun Wang wrote: > Sigh. I removed the test file itself long time ago but forgot to remove a > line on it in the problem list. This pull request has now been integrated. Changeset: df5209e7 Author:Weijun Wang URL: https://git.openjdk.org/jdk/comm

Integrated: 8292676: Remove two kerberos tests from problem list

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 15:13:34 GMT, Weijun Wang wrote: > The two tests are no longer manual and should be removed from the problem > list. This pull request has now been integrated. Changeset: 235151ea Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/235151ead89f9102e3a57ba

Re: RFR: 8292676: Remove two kerberos tests from problem list

2022-08-19 Thread Hai-May Chao
On Fri, 19 Aug 2022 15:13:34 GMT, Weijun Wang wrote: > The two tests are no longer manual and should be removed from the problem > list. Marked as reviewed by hchao (Committer). Looks good. - PR: https://git.openjdk.org/jdk/pull/9943

Integrated: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

2022-08-19 Thread Weijun Wang
On Fri, 19 Aug 2022 18:47:40 GMT, Weijun Wang wrote: > The final version of the CSR at https://bugs.openjdk.org/browse/JDK-8290119 > uses `@implNote` for the new text, but the code change was not updated before > the integration. This pull request has now been integrated. Changeset: 74d3330e

Re: RFR: 8292683: Remove BadKeyUsageTest.java from Problem List

2022-08-19 Thread Hai-May Chao
On Fri, 19 Aug 2022 19:01:10 GMT, Weijun Wang wrote: > Sigh. I removed the test file itself long time ago but forgot to remove a > line on it in the problem list. Marked as reviewed by hchao (Committer). Looks good. - PR: https://git.openjdk.org/jdk/pull/9951

Re: RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

2022-08-19 Thread Hai-May Chao
On Fri, 19 Aug 2022 18:47:40 GMT, Weijun Wang wrote: > The final version of the CSR at https://bugs.openjdk.org/browse/JDK-8290119 > uses `@implNote` for the new text, but the code change was not updated before > the integration. Marked as reviewed by hchao (Committer). Looks good. -

Re: RFR: 8292683: Remove BadKeyUsageTest.java from Problem List

2022-08-19 Thread Xue-Lei Andrew Fan
On Fri, 19 Aug 2022 19:01:10 GMT, Weijun Wang wrote: > Sigh. I removed the test file itself long time ago but forgot to remove a > line on it in the problem list. Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9951

RFR: 8292683: Remove BadKeyUsageTest.java from Problem List

2022-08-19 Thread Weijun Wang
Sigh. I removed the test file itself long time ago but forgot to remove a line on it in the problem list. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/9951/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9951&range=00 Issue: https://bugs.openjdk.

Re: RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

2022-08-19 Thread Xue-Lei Andrew Fan
On Fri, 19 Aug 2022 18:47:40 GMT, Weijun Wang wrote: > The final version of the CSR at https://bugs.openjdk.org/browse/JDK-8290119 > uses `@implNote` for the new text, but the code change was not updated before > the integration. Per the CSR, this is a straightforward update to me. --

RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

2022-08-19 Thread Weijun Wang
The final version of the CSR at https://bugs.openjdk.org/browse/JDK-8290119 uses `@implNote` for the new text, but the code change was not updated before the integration. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/9949/files Webrev: https://webrevs.ope

RFR: 8292681: Add JMH for ProtectionDomain

2022-08-19 Thread Eric Caspole
Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed for this test and will be useful for future class loading JMH too. - Commit messages: - 8292681: Add JMH for ProtectionDomain Ch

Re: Is there a KEM (Key Encapsulation Mechanism) architecture being proposed for the JCA?

2022-08-19 Thread David Hook
I'd like to just add a supporting comment on this by showing what we've currently done. At the moment KEM usage in the JCA is provided in the BC API by doing the following: // key pair generation     KeyPairGenerator kpg = KeyPairGenerator.getInstance("Kyber", "BCPQC");     kpg.i

Is there a KEM (Key Encapsulation Mechanism) architecture being proposed for the JCA?

2022-08-19 Thread John Gray
We are starting to make use of the new PQ algorithms adopted by NIST for prototyping and development of standards. In particular we are working on a composite KEM standard: See: https://datatracker.ietf.org/doc/draft-ounsworth-pq-composite-kem/ However, there is no KEM interface in the JCA (

Re: RFR: 8292676: Remove two kerberos tests from problem list

2022-08-19 Thread Xue-Lei Andrew Fan
On Fri, 19 Aug 2022 15:13:34 GMT, Weijun Wang wrote: > The two tests are no longer manual and should be removed from the problem > list. Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9943

Re: RFR: 8292676: Remove two kerberos tests from problem list

2022-08-19 Thread Mark Powers
On Fri, 19 Aug 2022 15:13:34 GMT, Weijun Wang wrote: > The two tests are no longer manual and should be removed from the problem > list. Looks good to me. - PR: https://git.openjdk.org/jdk/pull/9943

RFR: 8292676: Remove two kerberos tests from problem list

2022-08-19 Thread Weijun Wang
The two tests are no longer manual and should be removed from the problem list. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/9943/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292676 St

Re: RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v15]

2022-08-19 Thread Jayashree Huttanagoudar
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar wrote: >> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one >

Re: RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v6]

2022-08-19 Thread Josef Eisl
On Wed, 8 Dec 2021 00:18:44 GMT, Valerie Peng wrote: >> It is observed that when running crypto benchmark with large number of >> threads, a lot of time is spent on the synchronized block inside the >> Provider.getService() method. The cause for this is that >> Provider.getService() method fir