On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar <d...@openjdk.org> wrote:
>> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request incrementally with one > additional commit since the last revision: > > Address review comments Some more comments. test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java line 27: > 25: * @test > 26: * @bug 8215916 > 27: * @summary This Sample application attempts to authenticate a user Update the summary. test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java line 85: > 83: throw new RuntimeException(); > 84: } else { > 85: System.out.printf("-- call stack is -- %n%s%n", s); I'd rather print out the call stack if the test fails. Who would want to read the test output if it succeeds? ------------- PR: https://git.openjdk.org/jdk/pull/9159