Re: RFR: 8281236: (D)TLS key exchange named groups [v4]

2022-12-05 Thread Xue-Lei Andrew Fan
> This update is to support key exchange named groups customization for > individual (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.org/browse/JDK-8291950 > RFE: https://bugs.openjdk.org/browse/JDK-8281236 > Release-note: https://bugs.openjdk.org/browse/JDK-8291975

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Alan Bateman
On Tue, 6 Dec 2022 07:08:55 GMT, Jaikiran Pai wrote: > Furthermore, I think in its current form it means that this will > load/instantiate any `JdkConsoleProvider` implementations that are accessible > to the thread context classloader but may not have been from the module > configured

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jaikiran Pai
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Jamil Nimeh
On Mon, 5 Dec 2022 22:05:51 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v4]

2022-12-05 Thread Anthony Scarpino
> I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > method during decryption. A temporary buffer was used

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Anthony Scarpino
On Mon, 5 Dec 2022 22:05:51 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Volodymyr Paprotski
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Volodymyr Paprotski
> There is now an intrinsic for Poly1305, which is only enabled on the > `engineUpdate([]byte)` path. This PR adds intrinsic support > `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). > > Fuzzing test expanded to also include ByteBuffer payloads. > > Performance is now matched: >

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Anthony Scarpino
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-05 Thread Sean Mullan
On Mon, 5 Dec 2022 17:56:49 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jim Laskey
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v4]

2022-12-05 Thread Naoto Sato
On Sun, 4 Dec 2022 17:09:15 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed the expected behavior when the SecurityManager is enabled > > src/java.base/share/classes/java/io/Console.java

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-05 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java >

Re: RFR: 8298045: Fix hidden but significant trailing whitespace in properties files for core-libs code

2022-12-05 Thread Justin Lu
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly)

Re: RFR: 8295803: Console should be usable in jshell and other environments [v6]

2022-12-05 Thread Jim Laskey
On Mon, 5 Dec 2022 18:33:10 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v4]

2022-12-05 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8293412 Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Jamil Nimeh
On Mon, 5 Dec 2022 18:22:00 GMT, Sandhya Viswanathan wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove comment > > @valeriepeng Could you please take a look at this PR? @sviswa7 I will be looking at

Re: RFR: 8295803: Console should be usable in jshell and other environments [v6]

2022-12-05 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8295803: Console should be usable in jshell and other environments [v5]

2022-12-05 Thread Naoto Sato
> This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on > `jdk.internal.le` terminal by default, or jshell implementation if

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Sandhya Viswanathan
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-05 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v2]

2022-12-05 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

RFR: 8298108: Add a regression test for JDK-8297684

2022-12-05 Thread Severin Gehwolf
Please review this test addition as it would have helped discover a regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced and subsequently backported. What's more, it might help discover similar issues going forward. Thoughts? Testing: Manually produced a build without

Re: RFR: 8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException

2022-12-05 Thread Sean Mullan
On Thu, 1 Dec 2022 16:37:48 GMT, Daniel JeliƄski wrote: > This patch fixes the exceptions that may occur when merging IP address > NameConstraints from different certificates in a chain. > > The included test reports 3 exceptions without the fix, passes with the fix > applied. > > Tiers 1-3