On Mon, 5 Dec 2022 17:56:49 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues going forward. Thoughts? >> >> Testing: Manually produced a build without >> [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). Test fails >> without the fix, passes after. > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused Path arg for test invocation A regression test was added as part of the fix for https://bugs.openjdk.org/browse/JDK-8280890. See the commit log for more details: https://github.com/openjdk/jdk/commit/a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d#diff-6de8303e80bab41e34a29b272cff64a68d3b255f0f147ee16ef21680abf7f41a Since this is a different way of testing the same underlying issue and the problem shows up in more than one way, I agree it is a good idea to add another regression test. However, I would put in the same test directory as 8280890: test/jdk/java/security/SignedJar ------------- PR: https://git.openjdk.org/jdk/pull/11515
