Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Integrated: 8304264: Debug messages always show up for NativeGSS

2023-03-15 Thread Weijun Wang
On Wed, 15 Mar 2023 13:44:09 GMT, Weijun Wang wrote: > Only call `debug()` when `DEBUG` is set. This pull request has now been integrated. Changeset: be08a256 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/be08a256ab8abab63ec9070342fb5ee46f00219b Stats: 61 lines in 5

Re: RFR: 8304264: Debug messages always show up for NativeGSS

2023-03-15 Thread Weijun Wang
On Wed, 15 Mar 2023 16:56:40 GMT, Sean Mullan wrote: > Is this debug property documented anywhere? If not, perhaps we should add it > to the Troubleshooting guide. We can add it to the "Accessing Native GSS-API" page. There is an existing "Troubleshooting" but it's inside the part about using

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Naoto Sato
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-15 Thread Aliaksei Dubrouski
On Wed, 15 Mar 2023 18:08:20 GMT, Cesar Soares Lucas wrote: > I may be wrong here but my take on this is that there is nothing at the > language level that prevents the compiler from optimizing the code and moving > the allocation inside the "If". In fact, GRAAL might as well be doing this as

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-15 Thread Cesar Soares Lucas
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote: > This change will move the instantiation of BadPaddingException into the > branch of the if statement where it is thrown. This will decrease the > overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated > work item for p

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v3]

2023-03-15 Thread Cesar Soares Lucas
> Can I please get reviews for this PR to add support for the rematerialization > of scalar-replaced objects that participate in allocation merges? > > The most common and frequent use of NonEscaping Phis merging object > allocations is for debugging information. The two graphs below show number

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Wed, 15 Mar 2023 14:51:49 GMT, Weijun Wang wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requireme

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-15 Thread Aliaksei Dubrouski
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote: > This change will move the instantiation of BadPaddingException into the > branch of the if statement where it is thrown. This will decrease the > overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated > work item for p

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Valerie Peng
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

Integrated: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

2023-03-15 Thread Matthew Donovan
On Tue, 14 Feb 2023 12:17:39 GMT, Matthew Donovan wrote: > * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in > one base class (SSLContextTemplate) > * Updated TLS/SSL tests to extend SSLSocketTemplate where possible. > * Updated SSLEngineTemplate to accommodate changes

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-15 Thread Valerie Peng
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote: > This change will move the instantiation of BadPaddingException into the > branch of the if statement where it is thrown. This will decrease the > overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated > work item for p

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v2]

2023-03-15 Thread Cesar Soares Lucas
> Can I please get reviews for this PR to add support for the rematerialization > of scalar-replaced objects that participate in allocation merges? > > The most common and frequent use of NonEscaping Phis merging object > allocations is for debugging information. The two graphs below show number

Re: RFR: 8304264: Debug messages always show up for NativeGSS

2023-03-15 Thread Sean Mullan
On Wed, 15 Mar 2023 13:44:09 GMT, Weijun Wang wrote: > Only call `debug()` when `DEBUG` is set. Is this debug property documented anywhere? If not, perhaps we should add it to the Troubleshooting guide. - Marked as reviewed by mullan (Reviewer). PR: https://git.openjdk.org/jdk/pu

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Archie L . Cobbs
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Jonathan Gibbons
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
This PR converts Unicode sequences to UTF-8 native in .properties file. (Excluding the Unicode space and tab sequence). The conversion was done using native2ascii. In addition, the build logic is adjusted to support reading in the .properties files as UTF-8 during the conversion from .propertie

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support readin

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-03-15 Thread Daniel JeliƄski
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote: > This change will move the instantiation of BadPaddingException into the > branch of the if statement where it is thrown. This will decrease the > overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated > work item for p

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

2023-03-15 Thread Weijun Wang
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote: > We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goa

RFR: 8304264: Debug messages always show up for NativeGSS

2023-03-15 Thread Weijun Wang
Only call `debug()` when `DEBUG` is set. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/13043/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13043&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304264 Stats: 61 lines in 5 files changed: 29