Re: RFR: 8308711: Develop additional Tests for KEM implementation [v2]

2023-05-30 Thread Sibabrata Sahoo
> Additional Tests for KEM API. Sibabrata Sahoo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: -

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v25]

2023-05-30 Thread Daniel JeliƄski
On Tue, 30 May 2023 19:24:09 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - undo import changes > - undo import changes

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v25]

2023-05-30 Thread Bradford Wetmore
On Tue, 30 May 2023 19:24:09 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - undo import changes > - undo import changes

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-05-30 Thread Valerie Peng
On Sat, 27 May 2023 06:24:36 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-05-30 Thread Valerie Peng
On Sat, 27 May 2023 06:24:36 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-05-30 Thread Valerie Peng
On Sat, 27 May 2023 06:24:36 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v25]

2023-05-30 Thread Xue-Lei Andrew Fan
On Tue, 30 May 2023 19:24:09 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - undo import changes > - undo import changes My

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v3]

2023-05-30 Thread Valerie Peng
On Tue, 23 May 2023 14:00:30 GMT, Sean Mullan wrote: >> We found several more cases of passwords and encoded keys not cleared that >> were addressed in out Iteration # 2 commit. These cases were both in Java >> and native code. We still have doubts about the effectiveness and need for >>

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v25]

2023-05-30 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with two additional commits since the last revision: - undo import changes - undo import changes - Changes: - all:

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v24]

2023-05-30 Thread Kevin Driver
On Tue, 30 May 2023 15:23:39 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 26 additional >> commits

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Sean Mullan
On Tue, 30 May 2023 16:47:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments take 2 Marked as reviewed by mullan (Reviewer).

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-30 Thread Valerie Peng
On Wed, 24 May 2023 19:23:39 GMT, Martin Balao wrote: >> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line >> 71: >> >>> 69: private Mac prf; >>> 70: @SuppressWarnings("serial") >>> 71: private Cleaner.Cleanable cleaner; >> >> why not directly mark

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-30 Thread Valerie Peng
On Thu, 25 May 2023 23:58:00 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java >> line 213: >> >>> 211: sb.append(Constants.INDENT); >>> 212: sb.append("pParameter:"); >>> 213: sb.append(Constants.NEWLINE);

Integrated: 8297885: misc sun/security/pkcs11 tests timed out

2023-05-30 Thread Valerie Peng
On Sat, 27 May 2023 01:49:22 GMT, Valerie Peng wrote: > Increase the timeout value of the "LargeDSAKey,java" test to address the > intermittent test failure(s). As for the other mentioned test failures, the > execution time fluctuates even less, so leaving them alone for now. > > Thanks in

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Hai-May Chao
On Tue, 30 May 2023 16:47:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments take 2

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-30 Thread Mark Powers
On Tue, 30 May 2023 15:09:59 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean's additional comments > > I don't see my comments resolved in the latest commit. Did you not push them > yet?

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Sean's additional comments take 2 - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new:

Integrated: 8297878: KEM: Implementation

2023-05-30 Thread Weijun Wang
On Fri, 31 Mar 2023 02:25:04 GMT, Weijun Wang wrote: > The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. This pull request has now been integrated. Changeset: 6b90b051 Author:Weijun Wang URL:

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-30 Thread Weijun Wang
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > }

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-30 Thread Mat Carter
On Tue, 30 May 2023 14:32:53 GMT, Weijun Wang wrote: >> Added ability to load keystores from SST files on Windows. Example usage: >> >> KeyStore keyStore = KeyStore.getInstance("Windows-SST"); >> try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >>keyStore.load(fis,

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v24]

2023-05-30 Thread Sean Mullan
On Tue, 30 May 2023 14:59:11 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v24]

2023-05-30 Thread Sean Mullan
On Tue, 30 May 2023 14:59:11 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-30 Thread Sean Mullan
On Fri, 26 May 2023 23:24:38 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments I don't see my comments resolved in the latest

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v24]

2023-05-30 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 26 additional commits

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v23]

2023-05-30 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: wrapping - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - new:

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v21]

2023-05-30 Thread Kevin Driver
On Fri, 26 May 2023 23:00:40 GMT, Bradford Wetmore wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 23 additional >>

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v22]

2023-05-30 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: addressed remaining code review comments - Changes: - all:

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-30 Thread Weijun Wang
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > }

Re: RFR: 8297878: KEM: Implementation [v21]

2023-05-30 Thread Weijun Wang
> The KEM API and DHKEM impl. Note that this PR uses new methods in > https://github.com/openjdk/jdk/pull/13250. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: New and old SunJCE entries in class comment - Changes: -

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-30 Thread Sean Mullan
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > }

Re: RFR: 8290005: com/sun/jndi/ldap/LdapCBPropertiesTest.java failling with NullPointerException [v3]

2023-05-30 Thread Matthew Donovan
On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan wrote: >> In this PR, I added methods to the TransportContext class to synchronize >> access to the handshakeContext field. I also updated locations in the code >> that rely on the handshakeContext field to not be null to use the >>

Re: RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v6]

2023-05-30 Thread Christoph Langer
On Sat, 27 May 2023 22:47:53 GMT, Weijun Wang wrote: > I think you can finalize the CSR now. Thx for the hint, done. - PR Comment: https://git.openjdk.org/jdk/pull/13945#issuecomment-1568048939

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-30 Thread Alexey Ushakov
On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit