On Thu, 10 Aug 2023 23:46:25 GMT, Valerie Peng wrote:
> >
>
> Hmm, does the test fail with the changes in this PR or without? Are you also
> using NSS and which version?
It fails with and w/o this patch, looks like related to the
https://bugs.openjdk.org/browse/JDK-8232153
-
PR
JGSS is implemented in the JVM in 2 levels: the standard Java security provider
for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS login
module for Kerberos in com.sun.security.auth.module.Krb5LoginModule. The
problem is that in this hierarchy, the login module doesn't go throug
On Fri, 11 Aug 2023 16:17:23 GMT, Matthew Donovan wrote:
>> Daniel Jeliński has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix exception handling
>> - Fix indentation
>
> test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDecodeBadPoin
> Please review this patch that ensures that all exceptions thrown by SSLEngine
> delegated tasks are translated to alerts.
>
> All exceptions should already be translated to SSLExceptions and alerts by
> the time we exit from context.dispatch; these exceptions are rethrown by
> `conContext.fat
On Fri, 11 Aug 2023 20:15:59 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes the scope of 2 local variables to make
>> sure they are in scope when they are used.
>>
>> The patch additionally fixes one `c++11-narrowing` Clang warning by
>> explicitly casting string size (`siz
> Please review this patch that fixes the scope of 2 local variables to make
> sure they are in scope when they are used.
>
> The patch additionally fixes one `c++11-narrowing` Clang warning by
> explicitly casting string size (`size_t`) to `DWORD`.
Daniel Jeliński has updated the pull request
On Fri, 11 Aug 2023 16:53:41 GMT, Mark Powers wrote:
>> Please review this patch that fixes the scope of 2 local variables to make
>> sure they are in scope when they are used.
>>
>> The patch additionally fixes one `c++11-narrowing` Clang warning by
>> explicitly casting string size (`size_t`
On Fri, 11 Aug 2023 17:23:52 GMT, Ben Perez wrote:
> Removed PKCS7.verify() since no other code in JDK calls it.
Update the copyright to include 2023.
-
Changes requested by mullan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15251#pullrequestreview-1574196255
> Fixing the bug as stated would cause compatibility issues. E.g. the
> `addProvider` function always adds new providers at position 0 and therefore
> would always throw an error. Instead of changing how the function handles
> indices, we instead have left an `@implNote`
Ben Perez has updated t
Removed PKCS7.verify() since no other code in JDK calls it.
-
Commit messages:
- removed verify method that takes no arguments
Changes: https://git.openjdk.org/jdk/pull/15251/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15251&range=00
Issue: https://bugs.openjdk.org/bro
> Fixing the bug as stated would cause compatibility issues. E.g. the
> `addProvider` function always adds new providers at position 0 and therefore
> would always throw an error. Instead of changing how the function handles
> indices, we instead have left an `@implNote`
Ben Perez has updated t
On Fri, 11 Aug 2023 06:36:42 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes the scope of 2 local variables to make
> sure they are in scope when they are used.
>
> The patch additionally fixes one `c++11-narrowing` Clang warning by
> explicitly casting string size (`size_t`)
On Fri, 4 Aug 2023 08:17:39 GMT, Daniel Jeliński wrote:
> Please review this patch that ensures that all exceptions thrown by SSLEngine
> delegated tasks are translated to alerts.
>
> All exceptions should already be translated to SSLExceptions and alerts by
> the time we exit from context.dis
On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng wrote:
> This change addresses the scenario where a certificate is first stored as
> part of a certificate chain and then stored again as a certificate
> corresponding to a PrivateKey entry. Newer version of NSS errors out with
> CKR_GENERAL_ERROR
Please review this patch that fixes the scope of 2 local variables to make sure
they are in scope when they are used.
The patch additionally fixes one `c++11-narrowing` Clang warning by explicitly
casting string size (`size_t`) to `DWORD`.
-
Commit messages:
- Fix variable scope
On Wed, 9 Aug 2023 06:30:08 GMT, Thomas Stuefe wrote:
>> This is a weird one, but in awt we #define malloc Do_Not_Use_Malloc... And
>> so on. Without this reordering awt_ole.h (which includes comdef.h) also uses
>> the redefined malloc somewhere (I could not find where in comip.h that it's
>>
16 matches
Mail list logo
