Re: RFR: JDK-8328501 Incorrect @since` tags for java security interfaces [v3]

2024-04-09 Thread Weijun Wang
On Tue, 9 Apr 2024 23:19:53 GMT, Jonathan Gibbons wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year to 2024 > > [wangweij](https://github.com/wangweij) commented [3 weeks > ago](https://github

Re: RFR: JDK-8328501 Incorrect @since` tags for java security interfaces [v3]

2024-04-09 Thread Jonathan Gibbons
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Valerie Peng
On Tue, 9 Apr 2024 18:34:52 GMT, Mark Powers wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to match CSR for disableLegacy -> allowLegacy name change > > src/jdk.crypto.cryptoki/share/classes/sun/security/p

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Valerie Peng
On Tue, 9 Apr 2024 18:37:44 GMT, Mark Powers wrote: > What about testing? I tested the change manually by changing some behavior to simulate the case. However, this cannot be done by regression test since NSS does not have legacy mechanisms. - PR Comment: https://git.openjdk.org/

Integrated: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0

2024-04-09 Thread Valerie Peng
On Wed, 3 Apr 2024 01:11:47 GMT, Valerie Peng wrote: > This PR fixes a problem regarding the usage of dlerror() where an earlier > error message causes a premature error out. Added extra code to clear out > earlier error message and made minor code refactoring. > > No regression test as this c

Re: RFR: JDK-8328501 Incorrect @since` tags for java security interfaces [v3]

2024-04-09 Thread Pavel Rappo
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v12]

2024-04-09 Thread Weijun Wang
On Fri, 5 Apr 2024 06:31:16 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations in

Integrated: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-09 Thread Ben Perez
On Mon, 1 Apr 2024 17:39:07 GMT, Ben Perez wrote: > Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions This pull request has now been integrated. Changeset: 316361b9 Author:Ben Perez Committer: Sean Mullan URL: https://git.openjdk.org/

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v3]

2024-04-09 Thread Ben Perez
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Added Authority Information Access OID - Changes: - all: https://git.open

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v3]

2024-04-09 Thread Sean Mullan
On Tue, 9 Apr 2024 19:59:37 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added Authority Informatio

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Mark Powers
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote: >> Existing legacy mechanism check disables mechanism(s) when the support is >> partial, e.g. supports decryption but not encryption, or supports >> verification but not signing. Some mechanisms can be used for both >> encryption/decryption

Re: Key Missing Feature for IoT

2024-04-09 Thread Sean Mullan
On 4/9/24 9:24 AM, Simon Bernard wrote: Thx for detail answers. Yes. I don't want you to spend months on a contribution only to have us decide it is not something we want to include in the JDK. I really appreciate that. Yes, but PSK introduces security issues that need to be considered. We

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v4]

2024-04-09 Thread Weijun Wang
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: Key Missing Feature for IoT

2024-04-09 Thread Simon Bernard
Thx for detail answers. Yes. I don't want you to spend months on a contribution only to have us decide it is not something we want to include in the JDK. I really appreciate that. Yes, but PSK introduces security issues that need to be considered. We would have to be very careful about how we

Re: Key Missing Feature for IoT

2024-04-09 Thread Sean Mullan
Hi Simon, On 4/8/24 10:12 AM, Simon Bernard wrote: Hi Sean,  Thx for warning me about that.  I understand that maybe this is too soon for contributing code ? and also that finally this not so sure that you want to integrate (D)TLS feature that I mentioned previously as Key IoT features.

RFR: 8329948: Remove string template feature

2024-04-09 Thread Maurizio Cimadamore
This PR removes support for the string template feature from the Java compiler and the Java SE API, as discussed here: https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html - Commit messages: - Drop spurious changes - Merge branch 'master' into template_remo