On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial
On Wed, 24 Jan 2024 17:57:38 GMT, Oli Gillespie wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1560:
>>
>>> 1558: final boolean supportsParameter;
>>> 1559: final String constructorParameterClassName;
>>> 1560: private volatile Class
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Small space optimization.
Thanks for the updates.
On Wed, 10 Jan 2024 17:41:41 GMT, Raffaello Giulietti
wrote:
>> The spec is silent about methods being 'native'; it would generally be
>> impractical to implement native methods for these purposes, but a native
>> method can implement the behavior.
>
> @RogerRiggs The checks are agnostic
On Tue, 19 Dec 2023 15:58:10 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 185:
>>
>>> 183: commitEvent(PRIV_METH_NON_STATIC,
>>> 184: m + " must be non-static to be effective");
>>> 185:
On Wed, 10 Jan 2024 15:43:46 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changes according to reviewers feedback.
On Tue, 9 Jan 2024 10:41:31 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 53:
>>
>>> 51: private static final Class[] READ_OBJECT_NO_DATA_PARAM_TYPES =
>>> {};
>>> 52: private static final Class[]
On Wed, 10 Jan 2024 14:58:37 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 3998:
>>
>>> 3996: int i = ArraysSupport.mismatch(m1, m2, len1);
>>> 3997: if (i != -1)
>>> 3998: return Integer.compareUnsigned(m1[i], m2[i])
On Wed, 10 Jan 2024 11:27:53 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger,
On Tue, 2 Jan 2024 14:37:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger,
On Mon, 8 Jan 2024 13:48:06 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the
On Thu, 21 Dec 2023 09:53:10 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Corrected @Label of event and of field.
On Wed, 20 Dec 2023 14:28:39 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes according to reviewer's comments.
>
> It would also be useful/interesting
On Wed, 20 Dec 2023 15:01:02 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 113:
>>
>>> 111: if (longFromStatic(f) == null) {
>>> 112: commitEvent(SUID_CONVERTIBLE_TO_LONG,
>>> 113:
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changes according to reviewer's comments.
It would
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changes according to reviewer's comments.
On Wed, 20 Dec 2023 08:29:19 GMT, Daniel Fuchs wrote:
>> You could define them with an Enum but use the ordinal as the value for JFR.
>
> Same remark here about finality as
> https://github.com/openjdk/jdk/pull/17129#discussion_r1432400888. public
> statics should be final.
I'd also remove
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Better name for a label, corrected name of removed
On Tue, 19 Dec 2023 17:41:57 GMT, Raffaello Giulietti
wrote:
>> Users (not OpenJDK developers) don't know what the error code means. I think
>> it's better to not have them. This is how other events work. If you want to
>> guard against changes, I would export the package to the test.
>
>
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It
On Wed, 18 Oct 2023 16:39:47 GMT, Alan Bateman wrote:
> We have to be very careful with proposals like this as it means code outside
> of java.lang having access to the underlying bytes. I think other
> alternatives needs to be explored to avoid this and related concerns.
Yes, adding another
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are
>> duplicates, We need to move
>> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the
>> jdk.internal.util package, and modify these classes to public class, so
On Tue, 12 Sep 2023 14:13:06 GMT, 温绍锦 wrote:
> The title has been updated, please help update the title of JIRA
The description needs an update too.
-
PR Comment: https://git.openjdk.org/jdk/pull/15651#issuecomment-1715814638
On Tue, 12 Sep 2023 13:05:19 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Mon, 11 Sep 2023 16:36:55 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143:
>>
>>> 141: * code after loop unrolling.
>>> 142: */
>>> 143: public static int stringSize(int x) {
>>
>> I suggest splitting the moves of `stringSize`
On Mon, 11 Sep 2023 15:57:22 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Sun, 10 Sep 2023 17:59:10 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Sun, 10 Sep 2023 16:15:01 GMT, 温绍锦 wrote:
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is
On Mon, 4 Sep 2023 11:01:23 GMT, Leo Korinth wrote:
> What do you prefer? Do you have a better alternative? Do someone still think
> the current code is good? I think what we have today is inferior to all these
> improvements, and I would like to make it harder to develop bad test ca
The
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright
>
> I don't think this is the best change across so many files.
> It gives
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Tue, 8 Aug 2023 16:17:44 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so
On Thu, 13 Jul 2023 22:57:49 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so
On Thu, 13 Jul 2023 08:51:23 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so
On Thu, 6 Jul 2023 19:10:14 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
On Wed, 5 Jul 2023 20:52:56 GMT, Pavel Rappo wrote:
>> Are you sure? I just checked lines 91-92 and I'd say the change looks
>> correct.
>
>> The original `<=` was correct, the number of bits in the input array must be
>> less than the requested length of the BitArray. The constructors also
On Wed, 5 Jul 2023 14:52:22 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so
On Tue, 27 Jun 2023 07:45:34 GMT, Glavo wrote:
>> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>>
>> Reasons:
>>
>> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
>> creating a new shortcut can make writing shorter;
>> * Since all possible values
On Tue, 27 Jun 2023 07:45:34 GMT, Glavo wrote:
>> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>>
>> Reasons:
>>
>> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
>> creating a new shortcut can make writing shorter;
>> * Since all possible values
On Mon, 19 Jun 2023 16:11:12 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 66:
>>
>>> 64: ostream.println("Unrecognized security subcommand. See
>>> \"java -X\" for help");
>>> 65: ostream.println("Printing all
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 65:
> 63: import java.text.MessageFormat;
> 64: import
On Thu, 18 May 2023 19:14:02 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Address reviewer
On Wed, 17 May 2023 20:51:29 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated
On Sun, 14 May 2023 05:50:20 GMT, Tagir F. Valeev wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308016: Remove ellipses ("...") from snippets
>
> src/java.base/share/classes/java/io/RandomAccessFile.java
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
>
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
On Wed, 5 Apr 2023 08:37:27 GMT, Alan Bateman wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> -
On Wed, 5 Apr 2023 08:39:35 GMT, Alan Bateman wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> -
With the addition of `jdk.internal.util.OperatingSystem` references to the
system property `os.name` can be replaced.
This PR exports jdk.internal.util to:
- java.prefs,
- java.security.jgss,
- java.smartcardio,
- jdk.charsets,
- jdk.net,
- jdk.zipfs
-
Commit messages:
- In
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on
On Tue, 17 Jan 2023 17:12:05 GMT, Matthew Donovan wrote:
>> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version
>> numbers.
>> - Removed IllegalRecordVersion.java from ProblemList.txt
>>
>> Tested with jdk_security and jdk_security3 test groups.
>
> Matthew Donovan
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote:
>> Went through the jdk and found a few more places where
>> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc
>> methods could be replaced with a plain call to `java.util.Arrays`
>> equivalents. This patch addresses
On Mon, 16 Jan 2023 15:06:25 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> src/java.base/share/classes/java/lang/CharSequence.java line 76:
>
>> 74: *
>>
On Fri, 9 Dec 2022 12:23:04 GMT, Matthias Baesken wrote:
> Hi Roger , the new proposed version JNU_CHECK_EXCEPTION_DO is now almost as
> lengthy as the original coding, Is it really worth it introducing a macro
> when it gets so lengthy ?
Its easier to understand the flow and cleanup being
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
Good idea, though perhaps the return (and value if any) could be explicit in
the macro
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
The existing (and new) macro naming doesn't make clear that it always returns
from the
On Wed, 30 Nov 2022 08:03:50 GMT, Per Minborg wrote:
>> During the work of another PR (https://github.com/openjdk/jdk/pull/11260),
>> several improvement areas were identified. These are now adressed in this
>> separate PR proposing the use of more modern Java constructs as well as
>>
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Mon, 28 Nov 2022 22:56:27 GMT, Roger Riggs wrote:
> The accessFlags() methods added (in JDK 20, the current release) to
> java.lang.Class, java.lang.reflect.Executable, and java.lang.reflect.Field
> assume the access flags are from the current/most recent class file format
The accessFlags() methods added (in JDK 20, the current release) to
java.lang.Class, java.lang.reflect.Executable, and java.lang.reflect.Field
assume the access flags are from the current/most recent class file format
version. For current and past class file format versions there are few
On Thu, 24 Nov 2022 08:19:17 GMT, Per Minborg wrote:
> This PR proposes adding `@Serial` annotations to certain fields participating
> in serialisation.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11347
On Tue, 22 Nov 2022 16:26:30 GMT, Weijun Wang wrote:
> With the introduction of Virtual Threads, the current subject is no longer
> guaranteed to be inherited in a new thread. Remove this requirement until we
> find another way to implement `Subject::current`.
LGTM, dropping the inaccurate
On Fri, 14 Oct 2022 17:27:34 GMT, Aleksei Efimov wrote:
>> src/java.base/share/conf/security/java.security line 1388:
>>
>>> 1386: # are unused.
>>> 1387: #
>>> 1388: # Each class name pattern is matched against the factory class name
>>> to allow or disallow its
>>
>> It appears that for
On Thu, 13 Oct 2022 12:34:47 GMT, Jaikiran Pai wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change checkInput to be the global filter centric
>
> src/java.base/share/conf/security/java.security line 1408:
>
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more
On Wed, 5 Oct 2022 15:23:43 GMT, Aleksei Efimov wrote:
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular
On Mon, 19 Sep 2022 17:54:57 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291974
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added test
As mentioned earlier in the comments...
This is a completely
On Fri, 17 Jun 2022 12:24:50 GMT, Claes Redestad wrote:
>> - Reduce forks, iteration, runtime to reduce runtime while maintaining high
>> data quality on typical benchmarking hosts.
>>
>> Reduces runtime from estimated 10+ hours to 54 minutes.
>
> Claes Redestad has updated the pull request
On Wed, 13 Jul 2022 15:11:25 GMT, Сергей Цыпанов wrote:
>> We can skip bounds check and null check for Charset in case we use the array
>> entirely and the Charset is either default one or proven to be non-null.
>>
>> Benchmark results:
>>
>> before
>>
>> Benchmark
On Fri, 8 Jul 2022 07:37:36 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/lang/String.java line 1429:
>>
>>> 1427: */
>>> 1428: public String(byte[] bytes, int offset, int length) {
>>> 1429: this(bytes, offset, length, Charset.defaultCharset(),
>>>
On Thu, 7 Jul 2022 10:21:06 GMT, Сергей Цыпанов wrote:
> We can skip bounds check and null check for Charset in case we use the array
> entirely and the Charset is either default one or proven to be non-null.
>
> Benchmark results:
>
> before
>
> Benchmark
On Fri, 1 Jul 2022 08:31:28 GMT, Xue-Lei Andrew Fan wrote:
> Could someone in Oracle help me run Mach 5 testing?
The CI Passed for Tiers 1-3.
-
PR: https://git.openjdk.org/jdk/pull/8979
On Fri, 1 Jul 2022 08:40:06 GMT, Daniel Fuchs wrote:
>> @dfuch Taking a reference as parameter could simplify the use of ForceGC.
>> I though about this idea as well, when I had to check lambada expressions in
>> each call. I would like to do it in the future so that this PR could focus
>>
On Thu, 30 Jun 2022 18:39:48 GMT, Xue-Lei Andrew Fan wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 58:
>>
>>> 56: Reference.reachabilityFence(ref);
>>> 57:
>>> 58: for (int retries = (int)(timeout / 200); retries >= 0;
>>> retries--) {
>>
>> The logic around the
On Thu, 30 Jun 2022 18:44:30 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
On Thu, 30 Jun 2022 18:24:14 GMT, Xue-Lei Andrew Fan wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 70:
>>
>>> 68: // But it is fine. For most cases, the 1st GC is
>>> sufficient
>>> 69: // to trigger and complete the cleanup.
>>> 70:
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
On Thu, 16 Jun 2022 15:55:00 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>>
91 matches
Mail list logo
