On Tue, 2 Sep 2025 13:11:04 GMT, Volkan Yazici wrote:
> Recently merged JDK-8356439, renaming `JavaLangAccess::*NoRepl` methods, has
> conflicting changes with JDK-8362893 slightly preceding it. Back out
> JDK-8356439 by reverting eea50fbc1b2.
Marked as reviewed by syan (Committer).
-
On Thu, 21 Aug 2025 09:10:26 GMT, Leo Korinth wrote:
>> Yes, this PR change the default timeoutFactor when the tested JVM options do
>> not contains '-Xcomp', and at the same time also multiplies 4 of the timeout
>> value defined in some tests.
>>
>> So after this PR, the tests which the timeo
4, after this PR the new
>> default is 120 * 1
>
> @sendaoYan this PR changes the default timeoutFactor and so also has to
> change quite a number of implicit and explicit timeouts. But that doesn't
> mean that test configs that already set their own timeoutFactor should adjust
&
t timeout = 120
> * 10 = 1200 but new default = 120 * 2.5 = 300!).
>
> However I see the concern of @sendaoYan because individual tests may now get
> much larger timeout values when run with the non-default timeoutFactor
> because they have been adjusted for the new default. I don
On Mon, 18 Aug 2025 09:15:29 GMT, Leo Korinth wrote:
>> It is unclear to me if the author meant this to be `2.5` more than normal or
>> `10` more than JTREG default, or a `multiplier that seems to work`. It does
>> not bother me _more_ if it is a `10` then a `2.5`, as it needs to have a
>> val
On Fri, 15 Aug 2025 23:10:20 GMT, Mikhail Yankelevich
wrote:
> missing skip exceptions:
> test/jdk/sun/security/pkcs11/tls/TestPRF.java
> test/jdk/sun/security/pkcs11/tls/TestPremaster.java
> test/jdk/sun/security/pkcs11/tls/TestMasterSecret.java
> test/jdk/sun/security/pkcs11/tls/TestKeyMateria
On Fri, 15 Aug 2025 17:13:53 GMT, Mikhail Yankelevich
wrote:
> Replaced skip messages with skip exceptions
LGTM
-
Marked as reviewed by syan (Committer).
PR Review: https://git.openjdk.org/jdk/pull/26804#pullrequestreview-3127048387
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 8 Jul 2025 16:15:49 GMT, Mikhail Yankelevich
wrote:
> - Adjusted timings to prevent timeouts with `Fastdebug` and `-Xcomp`
> - Split tests into parallel runs, reducing execution time by almost three-fold
> - Replaced wildcard imports
> - Specified the loopback address
> - Enabled logs fo
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich
wrote:
>> Provider is now added to the Security before the test
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> removed unneeded check
test/jdk/sun/security/pkc
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 26 Dec 2024 02:14:21 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [6c591854](https://github.com/openjdk/jdk/commit/6c59185475eeca83153f085eba27cc0b3acf9bb4)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Wed, 22 Jan 2025 22:12:15 GMT, Kevin Rushforth wrote:
> @sendaoYan This PR should be closed. It does not meet the criteria for
> backporting to JDK 24 now that we are in RDP2.
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/22883#issuecomment-2608653641
Hi all,
This pull request contains a backport of commit
[6c591854](https://github.com/openjdk/jdk/commit/6c59185475eeca83153f085eba27cc0b3acf9bb4)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by SendaoYan on 25 Dec 2024 and was
On Sun, 8 Dec 2024 11:50:13 GMT, SendaoYan wrote:
> Hi all,
> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and
> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile
> warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug
On Sun, 22 Dec 2024 02:38:31 GMT, SendaoYan wrote:
>> Hi all,
>> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and
>> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile
>> warning `'dprintf' macro redefined` by clang17/l
On Mon, 23 Dec 2024 21:30:51 GMT, Kim Barrett wrote:
> Looks good to me, but you should get reviews from folks directly involved in
> the relevant areas.
Okey, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/22630#issuecomment-2560575583
On Mon, 23 Dec 2024 21:28:41 GMT, Kim Barrett wrote:
>> SendaoYan has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
nux-x64 with release build
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-x64 with fastdebug build
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with release build
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with fastdebug
> build
SendaoYan has updated
On Sat, 21 Dec 2024 16:11:56 GMT, Kim Barrett wrote:
>> src/java.smartcardio/share/native/libj2pcsc/pcsc.c line 48:
>>
>>> 46: #define dprintf3(s, p1, p2, p3) printf(s, p1, p2, p3)
>>> 47: #else
>>> 48: #undef dprintf // GNU, POSIX.1-2008
>>
>> Shouldn't this be before the `#ifdef J2PSC_DEBUG`?
nux-x64 with release build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with fastdebug build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with release build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with fastdebug
> build
SendaoYan has updated
with release build
> - [ ] jtreg tests(include tier1/2/3) on linux-x64 with fastdebug build
> - [ ] jtreg tests(include tier1/2/3) on linux-aarch64 with release build
> - [ ] jtreg tests(include tier1/2/3) on linux-aarch64 with fastdebug build
SendaoYan has updated the pull request
Hi all,
File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and
src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile
warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug configure.
This PR undefine `dprintf` before define dprintf macro, to avoid deplic
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini
wrote:
> The following tests in CAInterop.java for Google test domain are currently
> failing:
>
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
> security/infra/java/security/cert/CertP
On Sat, 2 Nov 2024 13:31:35 GMT, SendaoYan wrote:
> Hi all,
> Test
> `test/hotspot/jtreg/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java`
> fails on linux-riscv64, the expected output is:
> `warning: AES instructions are not available on this CPU`
> or:
> `wa
On Sat, 2 Nov 2024 13:31:35 GMT, SendaoYan wrote:
> Hi all,
> Test
> `test/hotspot/jtreg/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java`
> fails on linux-riscv64, the expected output is:
> `warning: AES instructions are not available on this CPU`
> or:
> `wa
Hi all,
Test
`test/hotspot/jtreg/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java`
fails on linux-riscv64, the expected output is:
`warning: AES instructions are not available on this CPU`
or:
`warning: AES intrinsics are not available on this CPU`
But the actual output on linux-riscv
On Sat, 5 Oct 2024 07:49:37 GMT, SendaoYan wrote:
> Hi all,
> This PR fix some typos bugs for RISC-V, and a typo bug in test directory.
> Trivial fix, no risk.
This pull request has now been integrated.
Changeset: 50426b38
Author:SendaoYan
URL:
https://git.openjdk.org/j
On Sat, 5 Oct 2024 07:49:37 GMT, SendaoYan wrote:
> Hi all,
> This PR fix some typos bugs for RISC-V, and a typo bug in test directory.
> Trivial fix, no risk.
Thanks all for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/21368#issuecomment-2395419393
On Sun, 6 Oct 2024 05:06:31 GMT, Julian Waters wrote:
>> Hi all,
>> This PR fix some typos bugs for RISC-V, and a typo bug in test directory.
>> Trivial fix, no risk.
>
> src/hotspot/cpu/riscv/methodHandles_riscv.cpp line 447:
>
>> 445: }
>> 446: }
>> 447:
>
> This whitespace deletion
Hi all,
This PR fix some typos bugs for RISC-V, and a typo bug in test directory.
Trivial fix, no risk.
-
Commit messages:
- 8337713: RISC-V: fix typos in macroAssembler_riscv.cpp
Changes: https://git.openjdk.org/jdk/pull/21368/files
Webrev: https://webrevs.openjdk.org/?repo=jd
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote:
> Hi all,
> The testcase
> `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca`
> run Error, because the `@run` set conflicted with `/manual` and `/timeout`.
&
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote:
> Hi all,
> The testcase
> `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca`
> run Error, because the `@run` set conflicted with `/manual` and `/timeout`.
&
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote:
> Hi all,
> The testcase
> `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca`
> run Error, because the `@run` set conflicted with `/manual` and `/timeout`.
&
Hi all,
The testcase
`test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca`
run Error, because the `@run` set conflicted with `/manual` and `/timeout`. I
think the `/timeout` not needed for manual test.
Only this testcase has this
On Sat, 18 May 2024 12:34:39 GMT, SendaoYan wrote:
> Hi all,
> Before `CAInterop.java#globalsigne46` imtermittent
> [failure](https://bugs.openjdk.org/browse/JDK-8332433) has been resolved,
> mark the test as intermittent.
This pull request has been closed without bein
On Sat, 18 May 2024 12:34:39 GMT, SendaoYan wrote:
> Hi all,
> Before `CAInterop.java#globalsigne46` imtermittent
> [failure](https://bugs.openjdk.org/browse/JDK-8332433) has been resolved,
> mark the test as intermittent.
Since
`test/jdk/security/infra/java/security/cert/CertP
On Sat, 22 Jun 2024 08:07:54 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Sat, 22 Jun 2024 08:07:54 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Sat, 22 Jun 2024 08:07:54 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
Hi all,
This pull request contains a backport of commit
[8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was
rev
On Wed, 19 Jun 2024 15:36:44 GMT, Christoph Langer wrote:
> Looks like this PR can be closed. The underlying issue has been resolved by
> the CA.
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/19694#issuecomment-2179040063
On Thu, 13 Jun 2024 12:32:58 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
> report failure as failed to validate, before the validate issue has been
> fixed, should we problem li
On Fri, 14 Jun 2024 00:58:30 GMT, SendaoYan wrote:
>> Thanks for the approved.
>
>> @sendaoYan As a best practice, it would be useful to first understand why
>> the test is not working before putting it on the ProblemList. Depending on
>> the severity of the problem
On Thu, 13 Jun 2024 01:20:55 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we p
On Sat, 18 May 2024 12:34:39 GMT, SendaoYan wrote:
> Hi all,
> Before `CAInterop.java#globalsigne46` imtermittent
> [failure](https://bugs.openjdk.org/browse/JDK-8332433) has been resolved,
> mark the test as intermittent.
Hi, can anyone take look this PR.
-
PR Co
On Thu, 13 Jun 2024 12:32:58 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
> report failure as failed to validate, before the validate issue has been
> fixed, should we problem li
On Thu, 13 Jun 2024 14:38:08 GMT, SendaoYan wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'jbs8334106' of github.com:sendaoYan/jdk-ysd into jbs8334106
>> -
On Thu, 13 Jun 2024 12:21:23 GMT, SendaoYan wrote:
>> Hi all,
>> Test
>> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
>> report failure as `failed to validate`, before the validate issue has been
>> fix
Hi all,
Test
`security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
report failure as failed to validate, before the validate issue has been
fixed, should we problem list the testcase.
-
Commit messages:
- 8333938: Exclude CAInterop
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we problem list the testcase.
SendaoYan has updated t
On Thu, 13 Jun 2024 09:21:41 GMT, Christoph Langer wrote:
> let's wait a bit with integration before the security folks had a chance to
> look at this...
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/19685#issuecomment-2165126505
On Thu, 13 Jun 2024 01:20:55 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we p
Hi all,
Test
`security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
report failure as `failed to validate`, before the validate issue has been
fixed, should we problem list the testcase.
-
Commit messages:
- Merge branch 'openjdk:ma
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally wit
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
This pull request has now been integrated.
Changeset: d130d2f4
Author:SendaoYa
On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang wrote:
>> No, it's an extra newline. A file should end with a newline but one is
>> enough.
>
> As confusing as they are, unfortunately GitHub UI does not render extra
> trailing newlines. This is the only one I could find with grepWin.
I find the ex
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally wit
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
delete extra empty trailing bla
On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Thanks for the review.
Thanks all for the review.
-
PR Comment: https:/
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
> /label build
Thanks.
-
PR Comment: https://git.openjdk.org/jdk/
Hi all,
This PR several extra empty spaces and extra empty lines in several
Makefiles. It's trivial fix, no risk.
Thanks.
-
Commit messages:
- 8333477: Delete extra empty spaces in Makefiles
Changes: https://git.openjdk.org/jdk/pull/19537/files
Webrev: https://webrevs.openjdk.
On Sat, 18 May 2024 12:44:52 GMT, Weijun Wang wrote:
> Is there a related bug on the intermittent failure?
I have reportd the itermittent failure
[JDK-8332433](https://bugs.openjdk.org/browse/JDK-8332433), and
[JDK-8316138](https://bugs.openjdk.org/browse/JDK-8316138) is subtask of
JDK-833243
Hi all,
Before `CAInterop.java#globalsigne46` imtermittent failure has been resolved,
mark the test as intermittent.
-
Commit messages:
- 8332492: Mark CAInterop.java#globalsigne46 as intermittent
Changes: https://git.openjdk.org/jdk/pull/19291/files
Webrev: https://webrevs.ope
On Thu, 1 Feb 2024 03:08:52 GMT, Fei Yang wrote:
> Looks good and trivial.
@RealFYang @jnimeh Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/17646#issuecomment-2043998825
On Wed, 31 Jan 2024 08:19:55 GMT, SendaoYan wrote:
> 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect
> comment information
This pull request has now been integrated.
Changeset: 432756b6
Author:SendaoYan
Committer: Fei Yang
URL:
On Wed, 31 Jan 2024 17:48:19 GMT, Jamil Nimeh wrote:
> Looks good, but please label the JBS bug with noreg-trivial.
Done
-
PR Comment: https://git.openjdk.org/jdk/pull/17646#issuecomment-1920357757
8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect
comment information
-
Commit messages:
- 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java
incorrect comment information
Changes: https://git.openjdk.org/jdk/pull/17646/files
Webrev: h
71 matches
Mail list logo
