On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang <li...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete extra empty trailing blank line in >> test/jdk/java/rmi/reliability/benchmark/bench/Makefile > > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1: > >> 1: # > > This file change is dubious: > 1. It does not have any trailing whitespace that can fail the skara checks. > 2. If the duplicate blank lines in the end of this Makefile is indeed > problematic (as fixed here), please fix the only other occasion in the JDK, > which is the Makefile in the parent directory. (Checked with `\n$^\n$\Z` > pattern in all Makefiles) > > Recommended actions: Either > 1. Revert changes in this file; > 2. Also update `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` to > remove the trailing blank line. Thanks for the suggestion, the trailing blank line of `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` has been removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1630767547
