On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote:
> The test is failing currently and the JBS issue could not be resolved since
> about a month, so let's exclude the test for now.
What is the point of stalling this PR? The test causes test errors, so it
should be problemlisted. And if
On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote:
> The test is failing currently and the JBS issue could not be resolved since
> about a month, so let's exclude the test for now.
+1
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 17 Nov 2023 14:04:07 GMT, Julian Waters wrote:
> > Can you please describe the problem you are trying to solve, and why you
> > think it is worth solving. You describe the thought process you went
> > through while doing the patch and possibly some other, older patch. As it
> > is, rea
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues
>> with them properly this time, by simply deleting the labels and duplicating
>> the code w
On Thu, 26 Oct 2023 14:19:32 GMT, Andrew John Hughes wrote:
>>> > Hi @gnu-andrew,
>>> > in your last example, why does it look for both arm and x64 packages? And
>>> > why for kFreeBsd? I see you have both hardcoded, why?
>>> > I would expect it only to attempt and pick up the architecture and O
On Wed, 30 Aug 2023 01:06:01 GMT, Andrew John Hughes wrote:
>> Changes look fine. I submitted a mach5 test job just in case. Will approve
>> once the test job passes.
>> BTW, I added a noreg-other label since there is no regression test for this
>> change.
>
>> Changes look fine. I submitted a
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote:
> There is a long standing limitation in the UNIX smartcardio implementation
> which means it will only look for the `pcsclite` library in two locations;
> `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned
> li
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote:
> There is a long standing limitation in the UNIX smartcardio implementation
> which means it will only look for the `pcsclite` library in two locations;
> `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned
> li
On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote:
>> I wrote this code ages ago. I'm not sure what's weird or suspicious about
>> it, though. The comment at the file's beginning explains this code's
>> motivation.
>>
>> The buffer was never thought to be used for something different than HA
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Wed, 9 Aug 2023 04:00:03 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.cpp line 2888:
>>
>>> 2886: LONG WINAPI topLevelUnhandledExceptionFilter(struct
>>> _EXCEPTION_POINTERS* exceptionInfo) {
>>> 2887: if (!InterceptOSException) {
>>> 2888: DWORD exception_code =
>>>
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Mon, 7 Aug 2023 08:14:41 GMT, Julian Waters wrote:
>> There are currently only 2 possible types of HMODULE and char/uint8_t for T
>> at the moment. Weirdly enough only line 126 errors out without the cast
>> while line 114, despite having the same problem, doesn't, but I added the
>> cast t
On Wed, 7 Dec 2022 16:27:43 GMT, Roger Riggs wrote:
>
> Good idea, though perhaps the return (and value if any) could be explicit in
> the macro invocation, instead of implicit (plus arg). A single macro would
> suffice, instead of multiples.
>
> Usage Example:
>
> ```
> JNU_CHECK_EXCEPT
On Mon, 14 Nov 2022 04:14:24 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
18 matches
Mail list logo
