Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-28 Thread Bradford Wetmore
On Thu, 28 Sep 2023 05:57:58 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 1278: >> >>> 1276: throw >>> context.conContext.fatal(Alert.INTERNAL_ERROR, >>> 1277: "Unhandled excep

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-27 Thread Daniel Jeliński
On Thu, 28 Sep 2023 00:54:32 GMT, Bradford Wetmore wrote: >> Daniel Jeliński has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix exception handling >> - Fix indentation > > src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.ja

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-27 Thread Bradford Wetmore
On Fri, 11 Aug 2023 21:22:02 GMT, Daniel Jeliński wrote: >> test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDecodeBadPoint.java line 40: >> >>> 38: public class SSLEngineDecodeBadPoint { >>> 39: static final byte[] clientHello = HexFormat.of().parseHex( >>> 40: "160303013a010001

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-27 Thread Bradford Wetmore
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-27 Thread Daniel Jeliński
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-26 Thread Jamil Nimeh
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-06 Thread Daniel Jeliński
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-08-15 Thread Matthew Donovan
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-08-11 Thread Daniel Jeliński
On Fri, 11 Aug 2023 16:17:23 GMT, Matthew Donovan wrote: >> Daniel Jeliński has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix exception handling >> - Fix indentation > > test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDecodeBadPoin

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-08-11 Thread Daniel Jeliński
> Please review this patch that ensures that all exceptions thrown by SSLEngine > delegated tasks are translated to alerts. > > All exceptions should already be translated to SSLExceptions and alerts by > the time we exit from context.dispatch; these exceptions are rethrown by > `conContext.fat