Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-11-01 Thread Xue-Lei Andrew Fan
On Tue, 1 Nov 2022 22:59:14 GMT, Mark Powers wrote: > > Anyone from Oracle can help me to run Mach5 testing, just in case I missed > > something? > > Do you have any specific mach5 tests in mind? Please have tier 1 and tier2 covered. Thanks! - PR: https://git.openjdk.org/jdk/pul

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-11-01 Thread Mark Powers
On Mon, 31 Oct 2022 17:33:57 GMT, Xue-Lei Andrew Fan wrote: > Anyone from Oracle can help me to run Mach5 testing, just in case I missed > something? Do you have any specific mach5 tests in mind? - PR: https://git.openjdk.org/jdk/pull/10893

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-11-01 Thread Xue-Lei Andrew Fan
On Tue, 1 Nov 2022 17:43:22 GMT, Mark Powers wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove tailing whitespaces > > src/jdk.crypto.ec/share/classes/sun/security/ec/ECOperations.java line 588: > >> 58

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-11-01 Thread Mark Powers
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Oct 2022 20:29:23 GMT, Sean Mullan wrote: > Can you please wait a few days on integrating this? I would like @ferakocz > and/or @mcpowers to also look at this. Sure. I'd appreciate if the review could be done by the end of this week. - PR: https://git.openjdk.org/jdk/p

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Sean Mullan
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Xue-Lei Andrew Fan
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread John Jiang
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Xue-Lei Andrew Fan
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Oct 2022 07:08:54 GMT, Daniel Jeliński wrote: > It would be nice to add a test / consistency check, verifying that: The current tests could be used to verify the tables. As the fields are private, it is not easy to add a test. But I will try in the follow-up change that hardcodes

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-31 Thread Daniel Jeliński
On Fri, 28 Oct 2022 18:05:30 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The EC point multiplication for secp256r1 could be improved for better >> performance, by using more efficient algorithm and pre-computation. >> Improvement for other curves are si

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-30 Thread Daniel Jeliński
On Fri, 28 Oct 2022 14:39:34 GMT, Xue-Lei Andrew Fan wrote: >> src/jdk.crypto.ec/share/classes/sun/security/ec/ECOperations.java line 628: >> >>> 626: ProjectivePoint.Mutable m = >>> 627: multiplier.pointMultiply(s); >>> 628:

Re: RFR: 8295011: EC point multiplication improvement for secp256r1 [v3]

2022-10-28 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The EC point multiplication for secp256r1 could be improved for better > performance, by using more efficient algorithm and pre-computation. > Improvement for other curves are similar, but will be addressed in separated > PRs. > > The basic idea