Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-30 Thread Valerie Peng
On Wed, 24 May 2023 19:23:39 GMT, Martin Balao wrote: >> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line >> 71: >> >>> 69: private Mac prf; >>> 70: @SuppressWarnings("serial") >>> 71: private Cleaner.Cleanable cleaner; >> >> why not directly mark "cleane

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-30 Thread Valerie Peng
On Thu, 25 May 2023 23:58:00 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java >> line 213: >> >>> 211: sb.append(Constants.INDENT); >>> 212: sb.append("pParameter:"); >>> 213: sb.append(Constants.NEWLINE); >>

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Fri, 26 May 2023 22:17:01 GMT, Martin Balao wrote: >> Good point. As I see it, the problem is not in the random source itself but >> in the values. There are a couple of P11PBECipher::engineInit paths in which >> P11PBECipher initialization succeeds but the pbes2Params does not have the >>

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 23:26:06 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PBECipher.java >> line 112: >> >>> 110: return pbes2Params.getAlgorithmParameters( >>> 111: blkSize, pbeAlg, P11Util.getSunJceProvider(), >>> 112:

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 20:23:19 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 23:44:44 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PBECipher.java >> line 214: >> >>> 212: protected int engineGetKeySize(Key key) >>> 213: throws InvalidKeyException { >>> 214: return cipher.engineGetKey

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 20:22:03 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 19:30:36 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Thu, 25 May 2023 00:11:54 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Martin Balao
On Wed, 24 May 2023 23:35:55 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-25 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Martin Balao
On Wed, 24 May 2023 19:56:54 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Martin Balao
On Wed, 24 May 2023 18:36:34 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-24 Thread Valerie Peng
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-23 Thread Martin Balao
> We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goals and guidelines of > [JDK-8301553](https://bugs.open