On Thu, 25 May 2023 20:22:03 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3)
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Util.java line
> 93:
>
>> 91: while (passwordBytes.hasRemaining()) {
>> 92: encPassword[i] = (char) (passwordBytes.get() & 0xFF);
>> 93: passwordBytes.put(i++, (byte) 0);
>
> nit: add a comment // for erasing bytes in 'passwordBytes'
Good
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1206095317
