> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>
> Still haven't made the attributes set immutable but at least it is populated
> before an entry is added to `entries` and it will never be modified later.
>
> I tried the newly added `AttributesMultiThread.java`
On Mon, 2 Oct 2023 20:00:03 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rewrite method comment
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1435:
>
>> 1433:
>>
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote:
> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>
> Still haven't made the attributes set immutable but at least it is populated
> before an entry is added to `entries` and it will never be modified later.
>
>
On Tue, 26 Sep 2023 15:04:44 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 1270:
>>
>>> 1268: }
>>> 1269: Entry entry = entries.get(alias.toLowerCase(Locale.ENGLISH));
>>> 1270: return
On Tue, 26 Sep 2023 14:46:46 GMT, Daniel Fuchs wrote:
>> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>>
>> Still haven't made the attributes set immutable but at least it is populated
>> before an entry is added to `entries` and it will never be modified later.
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote:
> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>
> Still haven't made the attributes set immutable but at least it is populated
> before an entry is added to `entries` and it will never be modified later.
>
>
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote:
> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
>
> Still haven't made the attributes set immutable but at least it is populated
> before an entry is added to `entries` and it will never be modified later.
>
>
A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
Still haven't made the attributes set immutable but at least it is populated
before an entry is added to `entries` and it will never be modified later.
I tried the newly added `AttributesMultiThread.java` test hundreds
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote:
>> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
>> modified and retrieved at the same time. Make it concurrent.
>>
>> The test uses some reflection to get this field and try updating it in
>> multiple threads.
>
>
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote:
>> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
>> modified and retrieved at the same time. Make it concurrent.
>>
>> The test uses some reflection to get this field and try updating it in
>> multiple threads.
>
>
On Fri, 16 Jun 2023 12:45:58 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 1438:
>>
>>> 1436:
>>> 1437: if (entry.attributes == null) {
>>> 1438: entry.attributes = ConcurrentHashMap.newKeySet();
>>
>> It seems that
On Fri, 16 Jun 2023 09:25:30 GMT, Daniel Fuchs wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more cases to cover
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1438:
>
>> 1436:
>>
On Fri, 16 Jun 2023 09:53:10 GMT, Daniel Jeliński wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more cases to cover
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1:
>
>> 1: /*
>
>
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Weijun Wang has updated the pull request incrementally with
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Weijun Wang has updated the pull request incrementally with
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Would
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Nice
The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
modified and retrieved at the same time. Make it concurrent.
The test uses some reflection to get this field and try updating it in multiple
threads.
-
Commit messages:
- chmod a-x
- the fix
Changes:
19 matches
Mail list logo
