Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v4]

2024-08-02 Thread Hai-May Chao
On Tue, 30 Jul 2024 22:24:04 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-08-02 Thread Hai-May Chao
On Tue, 30 Jul 2024 22:13:08 GMT, Weijun Wang wrote: >> Thanks to verify the exit code is not 32. Is it doable to have a test for >> aliasNotInStore which is not emitting a non-zero exit code? > > There is a chainNotValidated error here. But I can add the check in an > earlier check. See my nex

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v4]

2024-07-30 Thread Weijun Wang
> There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-30 Thread Weijun Wang
On Tue, 30 Jul 2024 21:32:34 GMT, Hai-May Chao wrote: >> Good idea. New commit pushed. > > Thanks to verify the exit code is not 32. Is it doable to have a test for > aliasNotInStore which is not emitting a non-zero exit code? There is a chainNotValidated error here. But I can add the check in

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-30 Thread Hai-May Chao
On Tue, 30 Jul 2024 15:07:39 GMT, Weijun Wang wrote: >> test/jdk/sun/security/tools/jarsigner/ByAlias.java line 91: >> >>> 89: kt("-delete -alias ee"); >>> 90: js("-verify a.jar") >>> 91: .shouldContain("not signed by alias in this keystore"); >> >> As this PR ch

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v3]

2024-07-30 Thread Hai-May Chao
On Tue, 30 Jul 2024 15:10:50 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-30 Thread Weijun Wang
On Tue, 30 Jul 2024 19:25:28 GMT, Hai-May Chao wrote: >> The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release >> note](https://bugs.openjdk.org/browse/JDK-8334262) have been updated as well. > >> The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release >> note](https:/

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-30 Thread Hai-May Chao
On Wed, 24 Jul 2024 20:43:48 GMT, Weijun Wang wrote: > The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release > note](https://bugs.openjdk.org/browse/JDK-8334262) have been updated as well. The CSR and release note look good. Just one small suggestion for CSR: changing `Only detec

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-30 Thread Weijun Wang
On Tue, 30 Jul 2024 00:48:36 GMT, Hai-May Chao wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v3]

2024-07-30 Thread Weijun Wang
> There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-29 Thread Hai-May Chao
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
> There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used

2024-06-13 Thread Anthony Scarpino
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote: > There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used

2024-06-13 Thread Weijun Wang
On Thu, 13 Jun 2024 15:45:41 GMT, Anthony Scarpino wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used

2024-06-13 Thread Anthony Scarpino
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote: > There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2

RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used

2024-06-13 Thread Weijun Wang
There is an error in `jarsigner` on the "This JAR contains signed entries that aren't signed by alias in this keystore" warning. The exit code is determined by [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/sun/secu