On Tue, 30 Jul 2024 22:24:04 GMT, Weijun Wang wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb
On Tue, 30 Jul 2024 22:13:08 GMT, Weijun Wang wrote:
>> Thanks to verify the exit code is not 32. Is it doable to have a test for
>> aliasNotInStore which is not emitting a non-zero exit code?
>
> There is a chainNotValidated error here. But I can add the check in an
> earlier check. See my nex
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/
On Tue, 30 Jul 2024 21:32:34 GMT, Hai-May Chao wrote:
>> Good idea. New commit pushed.
>
> Thanks to verify the exit code is not 32. Is it doable to have a test for
> aliasNotInStore which is not emitting a non-zero exit code?
There is a chainNotValidated error here. But I can add the check in
On Tue, 30 Jul 2024 15:07:39 GMT, Weijun Wang wrote:
>> test/jdk/sun/security/tools/jarsigner/ByAlias.java line 91:
>>
>>> 89: kt("-delete -alias ee");
>>> 90: js("-verify a.jar")
>>> 91: .shouldContain("not signed by alias in this keystore");
>>
>> As this PR ch
On Tue, 30 Jul 2024 15:10:50 GMT, Weijun Wang wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb
On Tue, 30 Jul 2024 19:25:28 GMT, Hai-May Chao wrote:
>> The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release
>> note](https://bugs.openjdk.org/browse/JDK-8334262) have been updated as well.
>
>> The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release
>> note](https:/
On Wed, 24 Jul 2024 20:43:48 GMT, Weijun Wang wrote:
> The [CSR](https://bugs.openjdk.org/browse/JDK-8334263) and [release
> note](https://bugs.openjdk.org/browse/JDK-8334262) have been updated as well.
The CSR and release note look good. Just one small suggestion for CSR: changing
`Only detec
On Tue, 30 Jul 2024 00:48:36 GMT, Hai-May Chao wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote:
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2
On Thu, 13 Jun 2024 15:45:41 GMT, Anthony Scarpino
wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote:
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2
There is an error in `jarsigner` on the "This JAR contains signed entries that
aren't signed by alias in this keystore" warning. The exit code is determined
by
[`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/sun/secu
18 matches
Mail list logo