svn commit: r1177179 - /james/app/trunk/src/assemble/app.xml

2011-09-28 Thread norman
Author: norman Date: Thu Sep 29 06:55:30 2011 New Revision: 1177179 URL: http://svn.apache.org/viewvc?rev=1177179&view=rev Log: Fix permissions of .sh files Modified: james/app/trunk/src/assemble/app.xml Modified: james/app/trunk/src/assemble/app.xml URL: http://svn.apache.org/viewvc/james/

Re: Prepare for new mailbox release

2011-09-28 Thread Norman Maurer
yes jpa need this... this is where derby or h2 comes to rescue bye norman Am Mittwoch, 28. September 2011 schrieb Ioan Eugen Stan < stan.ieu...@gmail.com>: > 2011/9/28 Norman Maurer : >> Hi Robert, >> >> I just fixed it. So it should now work again out of the box: >> >> http://svn.apache.org/vie

Re: Prepare for new mailbox release

2011-09-28 Thread Ioan Eugen Stan
2011/9/28 Norman Maurer : > Hi Robert, > > I just fixed it. So it should now work again out of the box: > > http://svn.apache.org/viewvc?rev=1176916&view=rev > > > Bye, > Norman >From what I can remember, there are some issues with [1] https://issues.apache.org/jira/browse/MAILBOX-133. It's abut t

Re: Hupa - Demo mode ?

2011-09-28 Thread Manuel Carrasco Moñino
I agree, we should use the same logging framework. - Manolo On Wed, Sep 28, 2011 at 8:15 AM, Norman Maurer wrote: > +1 to move to slf4j > > Bye, > Norman > > > 2011/9/28 Felix Knecht : > > IIRC at least James-Server uses slf4j and not commons-logging. Maybe hupa > > should also use slf4j to be

Re: Hupa - Demo mode ?

2011-09-28 Thread Manuel Carrasco Moñino
Hi Felix, Demo mode in Hupa does not use a dummy mail server, it uses guice and gin to inject mock implementations of imap and smtp client classes no dummy servers at all. There are no integration tests in Hupa needing a running server, all tests are unit tests (I love TDD and think that integrati

svn commit: r1177000 - in /james/mailbox/trunk: hbase/pom.xml pom.xml

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 18:16:57 2011 New Revision: 1177000 URL: http://svn.apache.org/viewvc?rev=1177000&view=rev Log: DependencyManagement definitions go to modules root pom.xml Modified: james/mailbox/trunk/hbase/pom.xml james/mailbox/trunk/pom.xml Modified: james/mailbox/trun

svn commit: r1176998 - /james/app/trunk/pom.xml

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 18:09:57 2011 New Revision: 1176998 URL: http://svn.apache.org/viewvc?rev=1176998&view=rev Log: Add file based queue to the mix Modified: james/app/trunk/pom.xml Modified: james/app/trunk/pom.xml URL: http://svn.apache.org/viewvc/james/app/trunk/pom.xml?rev=1

svn commit: r1176995 - /james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractChannelPipelineFactory.java

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 18:06:31 2011 New Revision: 1176995 URL: http://svn.apache.org/viewvc?rev=1176995&view=rev Log: cleanup Modified: james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractChannelPipelineFactory.java Modified: james/protocols/trunk/imp

svn commit: r1176991 - in /james/mailbox/trunk: pom.xml spring/src/main/resources/META-INF/org/apache/james/maildir.properties

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 17:58:07 2011 New Revision: 1176991 URL: http://svn.apache.org/viewvc?rev=1176991&view=rev Log: Add license header / add to exclude for rat check Modified: james/mailbox/trunk/pom.xml james/mailbox/trunk/spring/src/main/resources/META-INF/org/apache/james/

[jira] [Created] (MAILBOX-144) StoreMessageResultIterator$UnloadedMessageResult defines compareTo but not equals/hashCode

2011-09-28 Thread Felix Knecht (Created) (JIRA)
StoreMessageResultIterator$UnloadedMessageResult defines compareTo but not equals/hashCode -- Key: MAILBOX-144 URL: https://issues.apache.org/jira/browse/MAILBOX-144

svn commit: r1176953 - /james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/MessageResultImplTest.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 16:47:18 2011 New Revision: 1176953 URL: http://svn.apache.org/viewvc?rev=1176953&view=rev Log: Use a more intiuitive naming. Don't fall into the time trap when it comes to milliseconds gaps when creating the instances (might become a problem to test equality) Mod

[jira] [Resolved] (MAILBOX-143) MessageResultImpl defines compareTo but not equals/hashCode

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-143. -- Resolution: Fixed Fix Version/s: 0.4 equals, hashCode and test case implemented

svn commit: r1176950 - in /james/mailbox/trunk/store/src: main/java/org/apache/james/mailbox/store/MessageResultImpl.java test/java/org/apache/james/mailbox/store/MessageResultImplTest.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 16:36:29 2011 New Revision: 1176950 URL: http://svn.apache.org/viewvc?rev=1176950&view=rev Log: Implement equals and hashCode (MAILBOX-143) Added: james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/MessageResultImplTest.java (with props)

svn commit: r1176946 - /james/server/trunk/pom.xml

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 16:20:48 2011 New Revision: 1176946 URL: http://svn.apache.org/viewvc?rev=1176946&view=rev Log: Make sure we also build the file implementation of MailQueue Modified: james/server/trunk/pom.xml Modified: james/server/trunk/pom.xml URL: http://svn.apache.org/v

[jira] [Created] (MAILBOX-143) MessageResultImpl defines compareTo but not equals/hashCode

2011-09-28 Thread Felix Knecht (Created) (JIRA)
MessageResultImpl defines compareTo but not equals/hashCode --- Key: MAILBOX-143 URL: https://issues.apache.org/jira/browse/MAILBOX-143 Project: James Mailbox Issue Type: Bug

Re: Prepare for new mailbox release

2011-09-28 Thread Norman Maurer
Hi Robert, I just fixed it. So it should now work again out of the box: http://svn.apache.org/viewvc?rev=1176916&view=rev Bye, Norman 2011/9/28 Norman Maurer : > I will review later today.. > > Bye, > Norman > > > 2011/9/28 Robert Burrell Donkin : >> On Wed, Sep 28, 2011 at 8:45 AM, Norman Ma

[jira] [Resolved] (MAILBOX-142) Spring does get confused by creating the OpenJPAMailboxManager

2011-09-28 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved MAILBOX-142. --- Resolution: Fixed done > Spring does get confused by creating the OpenJPAMa

svn commit: r1176916 - /james/mailbox/trunk/spring/src/main/resources/META-INF/org/apache/james/spring-mailbox-jpa.xml

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 15:22:38 2011 New Revision: 1176916 URL: http://svn.apache.org/viewvc?rev=1176916&view=rev Log: Make sure spring does construct the OpenJPAMailboxManager without encryption enabled by default. See MAILBOX-142 Modified: james/mailbox/trunk/spring/src/main/reso

[jira] [Created] (MAILBOX-142) Spring does get confused by creating the OpenJPAMailboxManager

2011-09-28 Thread Norman Maurer (Created) (JIRA)
Spring does get confused by creating the OpenJPAMailboxManager -- Key: MAILBOX-142 URL: https://issues.apache.org/jira/browse/MAILBOX-142 Project: James Mailbox Issue Type: Bug

svn commit: r1176897 - /james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAMessageMapper.java

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 14:32:40 2011 New Revision: 1176897 URL: http://svn.apache.org/viewvc?rev=1176897&view=rev Log: Replace tabs with whitespaces Modified: james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAMessageMapper.java Modified: james/mailbox/trun

[jira] [Created] (HUPA-80) Use slf4j as log facade

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Use slf4j as log facade --- Key: HUPA-80 URL: https://issues.apache.org/jira/browse/HUPA-80 Project: JAMES Hupa Issue Type: Task Affects Versions: 0.1 Reporter: Felix Knecht -- This message is automati

[jira] [Resolved] (PROTOCOLS-33) Encoder/Decoder should be generic

2011-09-28 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-33. Resolution: Fixed done > Encoder/Decoder should be generic > ---

svn commit: r1176888 - in /james/server/trunk: lmtpserver/src/main/java/org/apache/james/lmtpserver/netty/ pop3server/src/main/java/org/apache/james/pop3server/ pop3server/src/main/java/org/apache/jam

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 14:07:58 2011 New Revision: 1176888 URL: http://svn.apache.org/viewvc?rev=1176888&view=rev Log: Adjustments for latest protocol changes Removed: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3ChannelUpstreamHandler.java

svn commit: r1176887 - /james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/BasicChannelUpstreamHandler.java

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 14:04:49 2011 New Revision: 1176887 URL: http://svn.apache.org/viewvc?rev=1176887&view=rev Log: Make sure all writes are done via the ProtocolTransport Modified: james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/BasicChannelUpstreamHandl

svn commit: r1176884 - in /james/protocols/trunk/smtp/src: main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java test/java/org/apache/james/protocols/smtp/core/fastfail/Max

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 13:52:52 2011 New Revision: 1176884 URL: http://svn.apache.org/viewvc?rev=1176884&view=rev Log: Add some fastfail handler which will disconnect the client after X unknown commands Added: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp

svn commit: r1176883 - in /james/protocols/trunk: api/src/main/java/org/apache/james/protocols/api/ impl/src/main/java/org/apache/james/protocols/impl/ smtp/src/main/java/org/apache/james/protocols/sm

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 13:51:14 2011 New Revision: 1176883 URL: http://svn.apache.org/viewvc?rev=1176883&view=rev Log: Move the encoding logic out of the netty code and place it in AbstractProtocolTransport which should be used as starting point when you implement your own ProtocolTrans

[jira] [Resolved] (JAMES-1322) The WAR file built from source does not build a functioning web app

2011-09-28 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1322. -- Resolution: Fixed fixed... See: http://svn.apache.org/viewvc/james/app/trunk/src/main/webapp/W

[jira] [Updated] (JAMES-1322) The WAR file built from source does not build a functioning web app

2011-09-28 Thread Norman Maurer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-1322: - Fix Version/s: 3.0-beta4 > The WAR file built from source does not build a functioning web ap

svn commit: r1176870 - /james/app/trunk/src/main/webapp/WEB-INF/web.xml

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 13:14:06 2011 New Revision: 1176870 URL: http://svn.apache.org/viewvc?rev=1176870&view=rev Log: Fix spring file location. See JAMES-1322 Modified: james/app/trunk/src/main/webapp/WEB-INF/web.xml Modified: james/app/trunk/src/main/webapp/WEB-INF/web.xml URL: h

svn commit: r1176843 - in /james/protocols/trunk: api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java impl/src/main/java/org/apache/james/protocols/impl/NettyProtocolTransp

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 12:25:59 2011 New Revision: 1176843 URL: http://svn.apache.org/viewvc?rev=1176843&view=rev Log: Factor out non netty specific stuff to AbstractProtocolTransport Added: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTrans

svn commit: r1176826 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 11:24:04 2011 New Revision: 1176826 URL: http://svn.apache.org/viewvc?rev=1176826&view=rev Log: Revert r1176817. It's possible since JDK 1.6 Modified: james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java Mo

Re: svn commit: r1176817 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread Felix Knecht
On 09/28/2011 01:09 PM, Norman Maurer wrote: But isn't this just the implementation of the interface method ? Or do I miss something ? I missunderstood would you meant by interface implementation. I thought about something like public interface MessageSearchIndex { Iterator search(Mailbo

Re: svn commit: r1176817 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread Norman Maurer
But isn't this just the implementation of the interface method ? Or do I miss something ? Bye, Norman 2011/9/28 Felix Knecht : > On 09/28/2011 12:59 PM, Norman Maurer wrote: >> >> Isn't this because of jdk 1.6 which also "supports" @override for >> interface implementations ? > > I don't now :-

Re: svn commit: r1176817 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread Felix Knecht
On 09/28/2011 12:59 PM, Norman Maurer wrote: Isn't this because of jdk 1.6 which also "supports" @override for interface implementations ? I don't now :-/ But there is not interface implementation I think: public interface MessageSearchIndex { /** * Return all uids of the previous i

Re: svn commit: r1176817 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread Norman Maurer
Isn't this because of jdk 1.6 which also "supports" @override for interface implementations ? Bye, Norman 2011/9/28 : > Author: felixk > Date: Wed Sep 28 10:54:06 2011 > New Revision: 1176817 > > URL: http://svn.apache.org/viewvc?rev=1176817&view=rev > Log: > Does not override anything from sup

[jira] [Created] (MAILBOX-141) Do not synchronize on objects that may be reused

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Do not synchronize on objects that may be reused Key: MAILBOX-141 URL: https://issues.apache.org/jira/browse/MAILBOX-141 Project: James Mailbox Issue Type: Bug Components: store

svn commit: r1176817 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 10:54:06 2011 New Revision: 1176817 URL: http://svn.apache.org/viewvc?rev=1176817&view=rev Log: Does not override anything from super class Modified: james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java Mod

[jira] [Resolved] (MAILBOX-140) Cleanup empty directories in the source tree

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-140. -- Resolution: Fixed > Cleanup empty directories in the source tree > ---

svn commit: r1176816 - in /james/mailbox/trunk: api/src/main/config/ api/src/main/resources/ api/src/test/config/ api/src/test/resources/ guice/src/main/resources/ guice/src/test/resources/ jpa/src/ma

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 10:47:22 2011 New Revision: 1176816 URL: http://svn.apache.org/viewvc?rev=1176816&view=rev Log: Cleanup empty directories (MAILBOX-140) Removed: james/mailbox/trunk/api/src/main/config/ james/mailbox/trunk/api/src/main/resources/ james/mailbox/trunk/api

[jira] [Created] (MAILBOX-140) Cleanup empty directories in the source tree

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Cleanup empty directories in the source tree Key: MAILBOX-140 URL: https://issues.apache.org/jira/browse/MAILBOX-140 Project: James Mailbox Issue Type: Task Affects Versions: 0.4 R

[jira] [Resolved] (MAILBOX-139) Make org.apache.james.mailbox.StandardMailboxMetaDataComparator serializable

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-139. -- Resolution: Fixed > Make org.apache.james.mailbox.StandardMailboxMetaDataComparator serial

svn commit: r1176815 - /james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/StandardMailboxMetaDataComparator.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 10:35:48 2011 New Revision: 1176815 URL: http://svn.apache.org/viewvc?rev=1176815&view=rev Log: Implement Serializable (MAILBOX-139) Modified: james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/StandardMailboxMetaDataComparator.java Modified: jam

[jira] [Created] (MAILBOX-139) Make org.apache.james.mailbox.StandardMailboxMetaDataComparator serializable

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Make org.apache.james.mailbox.StandardMailboxMetaDataComparator serializable Key: MAILBOX-139 URL: https://issues.apache.org/jira/browse/MAILBOX-139 Project: James Mailbox

[jira] [Resolved] (MAILBOX-138) Both, getter and setter should be synchronized for SearchContent

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-138. -- Resolution: Fixed Synchronized getter > Both, getter and setter should be syn

svn commit: r1176814 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/MessageSearcher.java

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 10:28:29 2011 New Revision: 1176814 URL: http://svn.apache.org/viewvc?rev=1176814&view=rev Log: Synchronize both, getter and setter (MAILBOX-138) Modified: james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/MessageSearcher.java Modi

[jira] [Created] (MAILBOX-138) Both, getter and setter should be synchronized for SearchContent

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Both, getter and setter should be synchronized for SearchContent Key: MAILBOX-138 URL: https://issues.apache.org/jira/browse/MAILBOX-138 Project: James Mailbox Issue Type: Bug

[jira] [Resolved] (MAILBOX-136) Respect return value of File.[createNewFile|delete|mkdir|renameTo]

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-136. -- Resolution: Fixed Fix Version/s: 0.4 Fixed what I've found > Respect r

svn commit: r1176812 - in /james/mailbox/trunk: maildir/src/main/java/org/apache/james/mailbox/maildir/ maildir/src/main/java/org/apache/james/mailbox/maildir/mail/ maildir/src/main/java/org/apache/ja

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 10:20:06 2011 New Revision: 1176812 URL: http://svn.apache.org/viewvc?rev=1176812&view=rev Log: Throw IOException if return value = false (MAILBOX-136) Modified: james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java

svn commit: r1176807 - /james/protocols/trunk/lmtp/

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 10:02:57 2011 New Revision: 1176807 URL: http://svn.apache.org/viewvc?rev=1176807&view=rev Log: update svn ignore Modified: james/protocols/trunk/lmtp/ (props changed) Propchange: james/protocols/trunk/lmtp/ --

Re: Mailet Development

2011-09-28 Thread Robert Burrell Donkin
On Wed, Sep 28, 2011 at 3:52 AM, Adam Gibson wrote: > Hello James Developers, Hello Adam > First, I would like to say I love the work you guys have done with this mail > server. It's one of the most customizable ones I've seen. I have been messing > with james since around 3.0-M2 now and want

[jira] [Resolved] (MAILBOX-137) Make sure opened streams are closed explicitly

2011-09-28 Thread Felix Knecht (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht resolved MAILBOX-137. -- Resolution: Fixed Close them finally > Make sure opened streams are closed ex

[jira] [Assigned] (MAILBOX-136) Respect return value of File.[createNewFile|delete|mkdir|renameTo]

2011-09-28 Thread Felix Knecht (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht reassigned MAILBOX-136: Assignee: Felix Knecht > Respect return value of File.[createNewFile|delete|mkdir|rena

svn commit: r1176795 - in /james/mailbox/trunk: hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMessageMapper.java maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.jav

2011-09-28 Thread felixk
Author: felixk Date: Wed Sep 28 09:24:39 2011 New Revision: 1176795 URL: http://svn.apache.org/viewvc?rev=1176795&view=rev Log: Finally close the streams (MAILBOX-137) Modified: james/mailbox/trunk/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMessageMapper.java james/mai

svn commit: r1176794 - /james/protocols/trunk/smtp/src/test/java/org/apache/james/smtpserver/

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 09:22:41 2011 New Revision: 1176794 URL: http://svn.apache.org/viewvc?rev=1176794&view=rev Log: Remove empty package Removed: james/protocols/trunk/smtp/src/test/java/org/apache/james/smtpserver/ ---

Re: Prepare for new mailbox release

2011-09-28 Thread Norman Maurer
I will review later today.. Bye, Norman 2011/9/28 Robert Burrell Donkin : > On Wed, Sep 28, 2011 at 8:45 AM, Norman Maurer wrote: >> Hi there, >> >> I think we should get ready for a new mailbox release. > > +1 :-) > >> This is the first step needed for the next james server release. >> So plea

Re: Prepare for new mailbox release

2011-09-28 Thread Norman Maurer
Well I think we should fix them before the release. Thanks for bringing this up! Bye, Norman Ps: I think empty directories can/should be removed 2011/9/28 Felix Knecht : > Hi Norman > > On 09/28/2011 09:45 AM, Norman Maurer wrote: >> >> Hi there, >> >> I think we should get ready for a new mail

Re: Prepare for new mailbox release

2011-09-28 Thread Robert Burrell Donkin
On Wed, Sep 28, 2011 at 8:45 AM, Norman Maurer wrote: > Hi there, > > I think we should get ready for a new mailbox release. +1 :-) > This is the first step needed for the next james server release. > So please let me know if you have any concerns .. JPAEncryptedMessage is still causing issues

[jira] [Assigned] (MAILBOX-137) Make sure opened streams are closed explicitly

2011-09-28 Thread Felix Knecht (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Knecht reassigned MAILBOX-137: Assignee: Felix Knecht > Make sure opened streams are closed explicitly >

[jira] [Commented] (MAILBOX-136) Respect return value of File.[createNewFile|delete|mkdir|renameTo]

2011-09-28 Thread Felix Knecht (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MAILBOX-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116292#comment-13116292 ] Felix Knecht commented on MAILBOX-136: -- https://builds.apache.org/view/G-L/view/Jame

[jira] [Created] (MAILBOX-137) Make sure opened streams are closed explicitly

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Make sure opened streams are closed explicitly -- Key: MAILBOX-137 URL: https://issues.apache.org/jira/browse/MAILBOX-137 Project: James Mailbox Issue Type: Bug Reporter: Felix Knecht

[jira] [Created] (MAILBOX-136) Respect return value of File.[createNewFile|delete|mkdir|renameTo]

2011-09-28 Thread Felix Knecht (Created) (JIRA)
Respect return value of File.[createNewFile|delete|mkdir|renameTo] -- Key: MAILBOX-136 URL: https://issues.apache.org/jira/browse/MAILBOX-136 Project: James Mailbox Issue Type:

Re: Prepare for new mailbox release

2011-09-28 Thread Felix Knecht
Hi Norman On 09/28/2011 09:45 AM, Norman Maurer wrote: Hi there, I think we should get ready for a new mailbox release. This is the first step needed for the next james server release. So please let me know if you have any concerns .. ( ... findbugs tells me ... ) IMO there are some 'missing

Prepare for new mailbox release

2011-09-28 Thread Norman Maurer
Hi there, I think we should get ready for a new mailbox release. This is the first step needed for the next james server release. So please let me know if you have any concerns .. Bye, Norman - To unsubscribe, e-mail: server-dev

svn commit: r1176759 - /james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataLineMessageHookHandler.java

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 07:25:18 2011 New Revision: 1176759 URL: http://svn.apache.org/viewvc?rev=1176759&view=rev Log: There is no need to check for FutureRequest here Modified: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataLineMessageHookHandler.

svn commit: r1176754 - /james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/NettyProtocolTransport.java

2011-09-28 Thread norman
Author: norman Date: Wed Sep 28 07:02:53 2011 New Revision: 1176754 URL: http://svn.apache.org/viewvc?rev=1176754&view=rev Log: Better use synchronized so we are 100 % sure the response order is not mixed in all cases. See PROTOCOLS-36 Modified: james/protocols/trunk/impl/src/main/java/org/