[mime4j] merge changes from streams-refactoring branch

2008-07-15 Thread Stefano Bagnara
I created a branch to commit the code I worked on in the last 2 days. The branch included commits to fix: MIME4J-50 - InputBuffer to extend FilterInputStream http://issues.apache.org/jira/browse/MIME4J-50 MIME4J-52 - Infinite loop when nested multipart is missing end boundary http://issues.apach

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-16 Thread Robert Burrell Donkin
On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > I created a branch to commit the code I worked on in the last 2 days. > > The branch included commits to fix: > > MIME4J-50 - InputBuffer to extend FilterInputStream > http://issues.apache.org/jira/browse/MIME4J-50 > MIM

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-17 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: I created a branch to commit the code I worked on in the last 2 days. The branch included commits to fix: MIME4J-50 - InputBuffer to extend FilterInputStream http://issues.apache.org/

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-17 Thread Robert Burrell Donkin
On Thu, Jul 17, 2008 at 8:21 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> >>> I created a branch to commit the code I worked on in the last 2 days. >>> >>> The branch include

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-17 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Thu, Jul 17, 2008 at 8:21 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: I created a branch to commit the code I worked on in the last 2 days. Th

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-17 Thread Robert Burrell Donkin
On Thu, Jul 17, 2008 at 7:39 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Thu, Jul 17, 2008 at 8:21 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >> IMO excessive use of branching lies at the heart of many of community >> issues experience by JAMES

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-18 Thread Serge Knystautas
On Thu, Jul 17, 2008 at 1:57 PM, Robert Burrell Donkin <[EMAIL PROTECTED]> wrote: > breaking trunk and then taking a branch without discussion is > annoying. it's bound to lead to conflicts as soon as anyone needs to > have a working trunk and so dives in. it's inevitable that your branch > will be

Re: [mime4j] merge changes from streams-refactoring branch

2008-07-18 Thread Stefano Bagnara
Serge Knystautas ha scritto: On Thu, Jul 17, 2008 at 1:57 PM, Robert Burrell Donkin IMO excessive use of branching lies at the heart of many of community issues experience by JAMES. when branches are used in this way, there tends to be a lack of community engagement and involvement in the branch

collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-17 Thread Stefano Bagnara
Stefano Bagnara ha scritto: Robert Burrell Donkin ha scritto: On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: I created a branch to commit the code I worked on in the last 2 days. The branch included commits to fix: MIME4J-50 - InputBuffer to extend FilterInputStr

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Robert Burrell Donkin
On 7/17/08, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Stefano Bagnara ha scritto: >> Robert Burrell Donkin ha scritto: >>> On Tue, Jul 15, 2008 at 10:31 AM, Stefano Bagnara <[EMAIL PROTECTED]> >>> wrote: I created a branch to commit the code I worked on in the last 2 days. The bra

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: I don't think you did anything particularly wrong (except leaving trunk with a broken test which I suspect was not done intentionally). Well, it was intentional. We never agreed if a failing test proving a bug should be something to be committed ASAP or only c

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Robert Burrell Donkin
On Fri, Jul 18, 2008 at 8:39 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> I don't think you did anything particularly wrong (except leaving >> trunk with a broken test which I suspect was not done intentionally). > > Well, it was intentional. We never agr

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Fri, Jul 18, 2008 at 8:39 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: I don't think you did anything particularly wrong (except leaving trunk with a broken test which I suspect was not done intentionally). Well, it was i

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Robert Burrell Donkin
On 7/18/08, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> On Fri, Jul 18, 2008 at 8:39 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> Robert Burrell Donkin ha scritto: I don't think you did anything particularly wrong (except leaving trunk with a br

Re: collaboration & branches (Was: [mime4j] merge changes from streams-refactoring branch)

2008-07-18 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On 7/18/08, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Fri, Jul 18, 2008 at 8:39 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: I don't think you did anything particularly wrong (except le