Noel,
thank you for noticing this.
I added a testcase and fixed it.
Should we add another try/catch level for the second mx so that an
exception to the second lookup would result in the A record? (otherwise
null)
Stefano
Noel J. Bergman wrote:
I was just looking over the fix ...
I was just looking over the fix ...
Shouldn't the return of the CNAME's MX records follow the pattern, and be:
return Collections.unmodifiableCollection(cnameMXrecords);
Have we discussed this before? The try { return } finally { return } code
there is an ugly pattern, and I seem to
FYI, I compared our codes and while functionally equivalent, I must admit that
your fix was cleaner and simpler ;-(
So let us stick to that.
--Søren
On Wednesday 07 September 2005 09:25, Stefano Bagnara wrote:
You move fast Stefano! I was about to commit my fix for it,
when I ran into the
You move fast Stefano! I was about to commit my fix for it, when I ran into
the SpoolManager issues.
I will compare our fixes :-)
--Søren
On Wednesday 07 September 2005 00:34, Stefano Bagnara (JIRA) wrote:
[ http://issues.apache.org/jira/browse/JAMES-413?page=all ]
Stefano Bagnara
You move fast Stefano! I was about to commit my fix for it,
when I ran into the SpoolManager issues.
I will compare our fixes :-)
Feel free to overwrite my changes with yours! Mine has been a really fast
fix.
I will run my test against your code, eventually!
Stefano
PS: sorry, I've seen you
[ http://issues.apache.org/jira/browse/JAMES-413?page=all ]
Stefano Bagnara resolved JAMES-413:
---
Resolution: Fixed
I was working on DNSServer so I fixed this: Soren, please review the patch.
James does not resolve CNAME DNS registrations
