Re: Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

Hi Dan, On 10 Sep 2010, at 15:22, Daniel D. Daugherty wrote: >> The new webrev with above changes is here: >> > > Thumbs up on the latest webrev. Thanks for the review. Bye, -- Tomas Hurka NetBeans Profiler ht

hg: jdk7/tl/jdk: 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs

Changeset: 73872b992aab Author:lancea Date: 2010-09-10 18:51 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73872b992aab 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs Reviewed-by: darcy ! src/share/classes/java/sql/DatabaseMetaData.java

hg: jdk7/tl/jdk: 6589685: JDBC 4.1 updates

Changeset: c786a9c927fd Author:lancea Date: 2010-09-10 15:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c786a9c927fd 6589685: JDBC 4.1 updates Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.ja

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 55eb9f25bf7a Author:alanb Date: 2010-09-10 16:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/55eb9f25bf7a 6881498: (file) Re-examine DirectoryStream exception handling Reviewed-by: forax ! make/java/nio/FILES_java.gmk + src/share/classes/java/nio/file/Directory

hg: jdk7/tl/jdk: 6980517: TEST_BUG sun\net\www\http\ChunkedInputStream\ChunkedEncodingTest.java NullPointerException

Changeset: 6960b4f07bf9 Author:chegar Date: 2010-09-10 15:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6960b4f07bf9 6980517: TEST_BUG sun\net\www\http\ChunkedInputStream\ChunkedEncodingTest.java NullPointerException Reviewed-by: michaelm ! test/sun/net/www/http/Chunked

Re: Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

On 9/10/2010 7:08 AM, Tomas Hurka wrote: src/share/vm/services/heapDumper.hpp Any particular reason for changing the one HeapDumper ctr from public to private? Just curious... According to the comment from Mandy, the second constructor HeapDumper(bool gc_before_heap_dump, bool print_t

Re: Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

Hi Dan, > Thanks for taking care of this RFE! You are welcome. > src/share/vm/services/heapDumper.cpp > > line 1309 - please line up _oome_constructor with the rest since that's > the style that in use in this part of the file Done. > line 1902 - typo 'out-of-memorry' -> 'out-of-memory' Done.