On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spit...@oracle.com wrote:
> I forgot to mention another AI:
> 5. Submit a CCC request and get an approval
>
> I'll do this as a background work.
> Mark, are you Ok with that?
Sure, please do. As far as I understood it, this CCC is just an intern
On Wed, May 23, 2012 at 10:25:10AM -0700, serguei.spit...@oracle.com wrote:
> Other action items for this integration:
> 1. Test that the HS DTrace are not broken on Solaris
If someone who has access to a solaris setup could do that, that
would be appreciated.
> 2. Find or setup a Linux machi
On 24/05/2012 7:02 AM, Alan Bateman wrote:
On 23/05/2012 20:37, Rob McKenna wrote:
Hi Alan,
Sorry, you've picked me up on that "if (" space a number of times.
Thanks for pointing it out again.
What should I be checking w.r.t. the ProcessIdToSessionId? It returns
a 0 on failure so once the sess
On 23/05/2012 20:37, Rob McKenna wrote:
Hi Alan,
Sorry, you've picked me up on that "if (" space a number of times.
Thanks for pointing it out again.
What should I be checking w.r.t. the ProcessIdToSessionId? It returns
a 0 on failure so once the session id's are unequal or we've
encountere
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was reviewed using bug 7165060
and that fixed the dtrace test failures.
The gobjcopy utility also crashes due to empty sect
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts the SUNW_* sections on objects. This has caused dtrace test
failures and Monitoring & Management test failures. The gobjcopy
utility crashes
Hi Alan,
Sorry, you've picked me up on that "if (" space a number of times.
Thanks for pointing it out again.
What should I be checking w.r.t. the ProcessIdToSessionId? It returns a
0 on failure so once the session id's are unequal or we've encountered
an ERROR_ACCESS_DENIED we should really
Hi Alan,
Sorry, you've picked me up on that "if (" space a number of times.
Thanks for pointing it out again.
What should I be checking w.r.t. the ProcessIdToSessionId? It returns a
0 on failure so once the session id's are unequal or we've encountered
an ERROR_ACCESS_DENIED we should really
On 23/05/2012 18:44, Rob McKenna wrote:
Hi folks,
David Holmes suggested a rewrite of the original bug (7168110) so I've
put together the following:
http://cr.openjdk.java.net/~robm/7171184/webrev.01/
It will narrow down the cause of the error and return a more specific
message when there i
Keith,
Thank you for reviewing at the fix!
I forgot to mention another AI:
5. Submit a CCC request and get an approval
I'll do this as a background work.
Mark, are you Ok with that?
Thanks,
Serguei
On 5/23/12 10:49 AM, Keith McGuigan wrote:
Serguei -
I think that all sounds fine.
--
-
Looks good!
/Staffan
On 23 maj 2012, at 19:44, Rob McKenna wrote:
> Hi folks,
>
> David Holmes suggested a rewrite of the original bug (7168110) so I've put
> together the following:
>
> http://cr.openjdk.java.net/~robm/7171184/webrev.01/
>
> It will narrow down the cause of the error and re
Serguei -
I think that all sounds fine.
--
- Keith
On 5/23/2012 1:25 PM, serguei.spit...@oracle.com wrote:
Keith,
I agree that it'd be nice to follow the rules.
But we also can do it in two stages:
- first integration to keep close to the original fix that was already
tested on Linux platf
Hi folks,
David Holmes suggested a rewrite of the original bug (7168110) so I've
put together the following:
http://cr.openjdk.java.net/~robm/7171184/webrev.01/
It will narrow down the cause of the error and return a more specific
message when there is a problem attaching jstack to a process
Changeset: 0c3d9050c918
Author:khazra
Date: 2012-05-23 10:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918
7170169: (props) System.getProperty("os.name") should return "Windows 8" when
run on Windows 8
Summary: Enable Windows Version 6.2 to be recognized as Win
Keith,
I agree that it'd be nice to follow the rules.
But we also can do it in two stages:
- first integration to keep close to the original fix that was already
tested on Linux platform (as Mark tells)
- separate refactoring to follow the platform separation rules (will
need to file another
On 5/23/12 9:47 AM, serguei.spit...@oracle.com wrote:
On 5/23/12 9:39 AM, Mark Wielaard wrote:
On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote:
On 5/23/2012 2:52 AM,serguei.spit...@oracle.com wrote:
In fact, we have the following question:
Q1: Do we have to submit a CCC request to enable
On 5/23/12 9:39 AM, Mark Wielaard wrote:
On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote:
On 5/23/2012 2:52 AM, serguei.spit...@oracle.com wrote:
In fact, we have the following question:
Q1: Do we have to submit a CCC request to enable the HotSpot DTrace
probes on Linux?
There isn't a lot
On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote:
> On 5/23/2012 2:52 AM, serguei.spit...@oracle.com wrote:
> > In fact, we have the following question:
> > Q1: Do we have to submit a CCC request to enable the HotSpot DTrace
> > probes on Linux?
>
> There isn't a lot of information in the 7149
Thanks!
Serguei
On 5/23/12 9:32 AM, Joe Darcy wrote:
Hi Serguei,
On 5/23/2012 2:52 AM, serguei.spit...@oracle.com wrote:
Hi Joe,
In fact, we have the following question:
Q1: Do we have to submit a CCC request to enable the HotSpot DTrace
probes on Linux?
There isn't a lot of information i
Hi Serguei,
On 5/23/2012 2:52 AM, serguei.spit...@oracle.com wrote:
Hi Joe,
In fact, we have the following question:
Q1: Do we have to submit a CCC request to enable the HotSpot DTrace
probes on Linux?
There isn't a lot of information in the 7149528 bug report to give a
final answer, but I
Hi Mark -
I'd prefer that it's done the "right" way (based on *my* definition of
"right", of course :) ), but I won't put up a fuss if whomever shepherds
this through agrees with you and wants to keep it in it's current form.
I expect that will be Serguei, or someone else from the serviceabi
On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote:
> On 5/23/2012 9:56 AM, Mark Wielaard wrote:
> >>It's (of course) just a style thing, but traditionally in hotspot
> >> we've wanted the os or arch specific code in os or arch specific
> >> directories, instead of littering the code with
Hi Mark,
On 5/23/2012 12:20 AM, Mark Wielaard wrote:
Hi Joe,
On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote:
This state
model is explained in the "process" link at the top of every ccc
page and was additionally explained in a tech talk I gave earlier
this year:
http://j2se.us.
On 5/23/2012 9:56 AM, Mark Wielaard wrote:
It's (of course) just a style thing, but traditionally in hotspot
we've wanted the os or arch specific code in os or arch specific
directories, instead of littering the code with #ifdefs. I know the OSX
stuff started violated this some, but I hope
Michael Fang skrev 2012-05-22 21:58:
Thanks Erik.
I have already downloaded the raw message.properties file from the
webrev on 5/16 to proceed with the 7u6 translation.
I performed a diff with current webrev, and it consists of mostly
deleted resources and 1 renamed key CONNECTION_LOST1 =>
On Wed, 2012-05-23 at 09:42 -0400, Keith McGuigan wrote:
> >> The first patch is just a consistency cleanup patch. The JNI Set and
> >> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N
> >> directly instead of just using DTRACE_PROBE[N] like all other JNI methods.
> >> Thi
On 5/23/2012 9:26 AM, Mark Wielaard wrote:
On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote:
Just a couple of quick comments/questions on the code:
Why did we get rid of a couple of the declarations in jni.cpp? Why
aren't they needed?
Could you say which ones you think we got rid of
On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote:
> Just a couple of quick comments/questions on the code:
>
> Why did we get rid of a couple of the declarations in jni.cpp? Why
> aren't they needed?
Could you say which ones you think we got rid of? It was not my
intention to get rid of
Just a couple of quick comments/questions on the code:
Why did we get rid of a couple of the declarations in jni.cpp? Why
aren't they needed?
dtrace.hpp should be refactored (if possible) into the os-specific
subdirectories, instead of using #ifdef macros in the header.
I.e., you might ha
I've generated the webrev (sorry it is not on the public domain yet):
http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/DTrace-Probes-Linux-HS.0/
Below is the patch related to the webrev above.
Thanks,
Serguei
diff -r 4b37c0dafe3a make/linux/makefiles/dtrace.make
--- a/make/linux/make
Changeset: 960a442eae91
Author:rbackman
Date: 2012-05-22 10:11 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/960a442eae91
7161732: Improve handling of thread_id in OSThread
Reviewed-by: dholmes, kamg
! src/os/bsd/vm/osThread_bsd.hpp
! src/os/linux/vm/osThread_lin
Hi Joe,
In fact, we have the following question:
Q1: Do we have to submit a CCC request to enable the HotSpot DTrace
probes on Linux?
The following is not completely clear to me:
Q2: Do we go through the CCC process when some interfaces are already
enabled on one platform and we want to ena
Changeset: a2fc04c2dfc8
Author:weijun
Date: 2012-05-23 15:51 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2fc04c2dfc8
7162687: enhance KDC server availability detection
Reviewed-by: valeriep
! src/share/classes/sun/security/krb5/KdcComm.java
! src/share/classes/sun/securi
Hi Joe,
On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote:
> This state
> model is explained in the "process" link at the top of every ccc
> page and was additionally explained in a tech talk I gave earlier
> this year:
>
> http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-y
34 matches
Mail list logo
