Changeset: 85696e57d447
Author:youdwei
Date: 2012-05-25 14:32 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85696e57d447
7171028: dots are missed in the datetime for Slovanian
Reviewed-by: yhuang
! src/share/classes/sun/text/resources/FormatData_sl.java
! test/sun/text/reso
Changeset: 71cf74329a9e
Author:youdwei
Date: 2012-05-25 13:28 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71cf74329a9e
7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled
Reviewed-by: okutsu
! src/windows/native/java/util/TimeZone_md.c
+ test/
Changeset: 7c4eed4b6c19
Author:bae
Date: 2012-05-21 14:04 +0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c4eed4b6c19
7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to
member (does not copy configs)
Reviewed-by: anthony, kizune
! src/macosx/c
Changeset: f2072b164b05
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/f2072b164b05
Added tag jdk8-b40 for changeset 09a0ddda03cb
! .hgtags
Changeset: 6f5c0e17415d
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6f5c0e17415d
Added tag jdk8-b40 for changeset 9ecfdbd6aed4
! .hgtags
Changeset: 113f0d5f0a08
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/113f0d5f0a08
Added tag jdk8-b40 for changeset 56d030e5035f
! .hgtags
Changeset: 1a8c7c530f8a
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1a8c7c530f8a
Added tag jdk8-b40 for changeset a2b2d435f1d2
! .hgtags
Changeset: e309917fb9af
Author:dbhole
Date: 2012-05-24 19:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af
7117230: clean up warnings in java.text
Reviewed-by: jrose, smarks
! src/share/classes/java/text/AttributedCharacterIterator.java
! src/share/classes/java
I don't know these tests well.
But I see there is the jhelper/ smoke test there.
It does a fairly surface testing that checks that a simple d-script does
not fail
and that the jhelper.d (supporting DTrace jstack action) was installed
on the system.
I still have some old half-manual tests for j
Hi,
I made some jhelper.d changes for the permgen elimination repository.
I'm strictly pattern matching. Do the NSK dtrace tests test this code?
Is there a complicated setup for these tests or do I just need to be root?
thanks,
Coleen
Mandy Chung skrev 2012-05-24 19:00:
Thumbs up. Minor comment (no need for new webrev if you fix it):
Great! Thanks for taking the time doing the review, it was a lot of
files to go through,
Resources.java L46: the AssertionError is not needed since it can't
get there.
The constructor can be
Apologies, I mixed up the docs with what I was seeing in testing. You're
right, the sid might not always be 0. I've been speaking with Alan and
we agree that its not worth pursuing given the direction this is headed.
-Rob
On 24/05/12 00:58, David Holmes wrote:
On 24/05/2012 7:02 AM, Alan
Thumbs up. Minor comment (no need for new webrev if you fix it):
Resources.java L46: the AssertionError is not needed since it can't get
there.
L133: would it be better to throw an internal error here to catch any
regression e.g. if isWriteField is modified incorrectly for whatever reason?
M
Thanks for the review!
Dan
On 5/24/12 10:33 AM, Karen Kinnear wrote:
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy ut
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> This is a JDK code review request for a pair of Full Debug Symbols
> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
> corrupts the SUNW_* sections on objects. This
Here is an updated webrev:
http://cr.openjdk.java.net/~egahlin/7017818_6/
Changes from previous webrev:
- Removed all @SuppressWarning changes
- Moved the Messages class from sun.tools.jconsole.resource to
sun.tools.jconsole and updated the makefile
- Aligned parameters in the method calls.
-
On 5/24/12 8:28 AM, Karen Kinnear wrote:
Dan,
Code looks good.
Thanks!
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
SHF_ALLOC flag?
We know that gobjcopy crashes when running into empty ELF sections
where the SHF_ALLOC fla
Changeset: df84b4a3ebcb
Author:rbackman
Date: 2012-05-24 13:37 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df84b4a3ebcb
7171422: Change 7161732 breaks SA on Windows
Reviewed-by: dholmes, sla
! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp
The stack requirements (char message[BUFSIZE]) for this method increasing by
256 all the time seems
unnecessary, a fixed string plus two numerics doesn't need 256 characters
anyway, does it?
Not sure it matters that much in this case since it isn't in any kind of
recursive call situation.
Fixed
Dan,
Code looks good.
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
And I assume the windows/makefiles/defs.make change is because you determined
that the failing tests actually pre-dated the zipped debuginfo. Did you find
the ro
Changeset: 5ec5588c733d
Author:nloodin
Date: 2012-05-24 09:32 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d
7143353: -Xrunhprof fails in Java 7 due to bad switch
Reviewed-by: jrose, sspitsyn
! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c
! src/share/javav
Changeset: a11c964d1319
Author:jgish
Date: 2012-05-24 14:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a11c964d1319
7160725: Strange or obsolete @see tags in some exception java.lang javadoc
Summary: update javadoc for IllegalArgumentException and NumberFormatException
Re
Thanks Serguei!
Dan
On 5/24/12 1:52 AM, serguei.spit...@oracle.com wrote:
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols go
Thanks Staffan!
/R
On 05/24/2012 02:51 PM, Staffan Larsen wrote:
Looks good.
/Staffan
On 24 maj 2012, at 14:16, Rickard Bäckman wrote:
Hi,
my refactoring broke the SA on Windows, the only platform that didn't have a
declaration of the thread_id type in vmStructs.
This change adds the dec
Looks good.
/Staffan
On 24 maj 2012, at 14:16, Rickard Bäckman wrote:
> Hi,
>
> my refactoring broke the SA on Windows, the only platform that didn't have a
> declaration of the thread_id type in vmStructs.
>
> This change adds the declares the field as an unsigned integer.
> Tested by buildi
Changeset: 21703d431217
Author:alanb
Date: 2012-05-24 10:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21703d431217
7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE
and 0 events
Reviewed-by: chegar, coffeys
! src/solaris/classes/sun/nio/ch/De
Thank you for the quick review David.
/R
On 05/24/2012 02:28 PM, David Holmes wrote:
OK.
David
On 24/05/2012 10:16 PM, Rickard Bäckman wrote:
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds th
OK.
David
On 24/05/2012 10:16 PM, Rickard Bäckman wrote:
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds the declares the field as an unsigned integer.
Tested by building in JPRT and connecting w
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds the declares the field as an unsigned integer.
Tested by building in JPRT and connecting with jsadebugd.exe on Win64.
Bug: http://bugs.sun.com/bugd
Thanks Serguei!
Dan
On 5/24/12 1:50 AM, serguei.spit...@oracle.com wrote:
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
On Thu, 2012-05-24 at 00:55 -0700, serguei.spit...@oracle.com wrote:
> I wanted to say that I'll work on all 5 item actions in a background
> when get cycles.
> I'll ask you for help when needed.
Sure. Could you indicate if that means days or weeks? I am more than
willing to help polish the code a
Guess this could be mitigated by some form of testing… ;)
/Nisse
On May 24, 2012, at 10:01 , John Rose wrote:
> Looks good.
>
> (General rule: Adding constant pool types causes lots of ripples like this.)
>
> — John
>
> On May 24, 2012, at 12:46 AM, Nils Loodin wrote:
>
>> when the 'demo' j
Looks good.
Thanks,
Serguei
On 5/24/12 12:46 AM, Nils Loodin wrote:
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror
the constant pool of a class, a few of the constants introduced by
invokedynamic ins't recognized.
Fairly simple fix. For my simple repro, it seems to wor
Looks good.
/R
On 05/24/2012 09:46 AM, Nils Loodin wrote:
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
constant pool of a class, a few of the constants introduced by invokedynamic
ins't recognized.
Fairly simple fix. For my simple repro, it seems to work with thi
Looks good.
(General rule: Adding constant pool types causes lots of ripples like this.)
— John
On May 24, 2012, at 12:46 AM, Nils Loodin wrote:
> when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
> constant pool of a class, a few of the constants introduced by invoke
I wanted to say that I'll work on all 5 item actions in a background
when get cycles.
I'll ask you for help when needed.
Thanks,
Serguei
On 5/23/12 11:42 PM, Mark Wielaard wrote:
On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spit...@oracle.com wrote:
I forgot to mention another AI:
5.
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
constant pool of a class, a few of the constants introduced by invokedynamic
ins't recognized.
Fairly simple fix. For my simple repro, it seems to work with this patch.
Also slightly improved the error message for future
39 matches
Mail list logo
