On Wed, May 23, 2012 at 10:25:10AM -0700, serguei.spit...@oracle.com wrote:
Other action items for this integration:
1. Test that the HS DTrace are not broken on Solaris
If someone who has access to a solaris setup could do that, that
would be appreciated.
2. Find or setup a Linux machine
On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spit...@oracle.com wrote:
I forgot to mention another AI:
5. Submit a CCC request and get an approval
I'll do this as a background work.
Mark, are you Ok with that?
Sure, please do. As far as I understood it, this CCC is just an internal
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
constant pool of a class, a few of the constants introduced by invokedynamic
ins't recognized.
Fairly simple fix. For my simple repro, it seems to work with this patch.
Also slightly improved the error message for future
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around
I wanted to say that I'll work on all 5 item actions in a background
when get cycles.
I'll ask you for help when needed.
Thanks,
Serguei
On 5/23/12 11:42 PM, Mark Wielaard wrote:
On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spit...@oracle.com wrote:
I forgot to mention another AI:
5.
Looks good.
(General rule: Adding constant pool types causes lots of ripples like this.)
— John
On May 24, 2012, at 12:46 AM, Nils Loodin wrote:
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
constant pool of a class, a few of the constants introduced by
Looks good.
/R
On 05/24/2012 09:46 AM, Nils Loodin wrote:
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the
constant pool of a class, a few of the constants introduced by invokedynamic
ins't recognized.
Fairly simple fix. For my simple repro, it seems to work with
Looks good.
Thanks,
Serguei
On 5/24/12 12:46 AM, Nils Loodin wrote:
when the 'demo' java_crw_demo (which is used by hprof) tries to mirror
the constant pool of a class, a few of the constants introduced by
invokedynamic ins't recognized.
Fairly simple fix. For my simple repro, it seems to
Guess this could be mitigated by some form of testing… ;)
/Nisse
On May 24, 2012, at 10:01 , John Rose wrote:
Looks good.
(General rule: Adding constant pool types causes lots of ripples like this.)
— John
On May 24, 2012, at 12:46 AM, Nils Loodin wrote:
when the 'demo'
On Thu, 2012-05-24 at 00:55 -0700, serguei.spit...@oracle.com wrote:
I wanted to say that I'll work on all 5 item actions in a background
when get cycles.
I'll ask you for help when needed.
Sure. Could you indicate if that means days or weeks? I am more than
willing to help polish the code and
Thanks Serguei!
Dan
On 5/24/12 1:50 AM, serguei.spit...@oracle.com wrote:
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds the declares the field as an unsigned integer.
Tested by building in JPRT and connecting with jsadebugd.exe on Win64.
Bug:
OK.
David
On 24/05/2012 10:16 PM, Rickard Bäckman wrote:
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds the declares the field as an unsigned integer.
Tested by building in JPRT and connecting
Thank you for the quick review David.
/R
On 05/24/2012 02:28 PM, David Holmes wrote:
OK.
David
On 24/05/2012 10:16 PM, Rickard Bäckman wrote:
Hi,
my refactoring broke the SA on Windows, the only platform that didn't
have a declaration of the thread_id type in vmStructs.
This change adds
Changeset: 21703d431217
Author:alanb
Date: 2012-05-24 10:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21703d431217
7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE
and 0 events
Reviewed-by: chegar, coffeys
!
Thanks Serguei!
Dan
On 5/24/12 1:52 AM, serguei.spit...@oracle.com wrote:
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols
Changeset: 5ec5588c733d
Author:nloodin
Date: 2012-05-24 09:32 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d
7143353: -Xrunhprof fails in Java 7 due to bad switch
Reviewed-by: jrose, sspitsyn
! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c
!
Dan,
Code looks good.
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
And I assume the windows/makefiles/defs.make change is because you determined
that the failing tests actually pre-dated the zipped debuginfo. Did you find
the
The stack requirements (char message[BUFSIZE]) for this method increasing by
256 all the time seems
unnecessary, a fixed string plus two numerics doesn't need 256 characters
anyway, does it?
Not sure it matters that much in this case since it isn't in any kind of
recursive call situation.
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts the SUNW_* sections on objects. This has
Thanks for the review!
Dan
On 5/24/12 10:33 AM, Karen Kinnear wrote:
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy
Thumbs up. Minor comment (no need for new webrev if you fix it):
Resources.java L46: the AssertionError is not needed since it can't get
there.
L133: would it be better to throw an internal error here to catch any
regression e.g. if isWriteField is modified incorrectly for whatever reason?
Apologies, I mixed up the docs with what I was seeing in testing. You're
right, the sid might not always be 0. I've been speaking with Alan and
we agree that its not worth pursuing given the direction this is headed.
-Rob
On 24/05/12 00:58, David Holmes wrote:
On 24/05/2012 7:02 AM, Alan
Mandy Chung skrev 2012-05-24 19:00:
Thumbs up. Minor comment (no need for new webrev if you fix it):
Great! Thanks for taking the time doing the review, it was a lot of
files to go through,
Resources.java L46: the AssertionError is not needed since it can't
get there.
The constructor can be
Hi,
I made some jhelper.d changes for the permgen elimination repository.
I'm strictly pattern matching. Do the NSK dtrace tests test this code?
Is there a complicated setup for these tests or do I just need to be root?
thanks,
Coleen
I don't know these tests well.
But I see there is the jhelper/ smoke test there.
It does a fairly surface testing that checks that a simple d-script does
not fail
and that the jhelper.d (supporting DTrace jstack action) was installed
on the system.
I still have some old half-manual tests for
Changeset: e309917fb9af
Author:dbhole
Date: 2012-05-24 19:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af
7117230: clean up warnings in java.text
Reviewed-by: jrose, smarks
! src/share/classes/java/text/AttributedCharacterIterator.java
!
Changeset: 6f5c0e17415d
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6f5c0e17415d
Added tag jdk8-b40 for changeset 9ecfdbd6aed4
! .hgtags
Changeset: f2072b164b05
Author:katleman
Date: 2012-05-24 16:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/f2072b164b05
Added tag jdk8-b40 for changeset 09a0ddda03cb
! .hgtags
Changeset: 7c4eed4b6c19
Author:bae
Date: 2012-05-21 14:04 +0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c4eed4b6c19
7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to
member (does not copy configs)
Reviewed-by: anthony, kizune
!
Changeset: 71cf74329a9e
Author:youdwei
Date: 2012-05-25 13:28 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71cf74329a9e
7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled
Reviewed-by: okutsu
! src/windows/native/java/util/TimeZone_md.c
+
32 matches
Mail list logo
