hg: hsx/hotspot-rt/hotspot: 7199068: NPG: SharedSkipVerify is meaningless

2012-10-10 Thread coleen . phillimore
Changeset: bdb5f8c9978b Author:coleenp Date: 2012-10-10 17:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bdb5f8c9978b 7199068: NPG: SharedSkipVerify is meaningless Summary: Remove the SharedSkipVerify flag Reviewed-by: kamg, sspitsyn, coleenp Contributed-by: ha

hg: jdk8/tl/langtools: 8000310: Clean up use of StringBuffer in langtools

2012-10-10 Thread jonathan . gibbons
Changeset: c46e0c9940d6 Author:jjg Date: 2012-10-10 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c46e0c9940d6 8000310: Clean up use of StringBuffer in langtools Reviewed-by: bpatel ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes

hg: jdk8/tl/langtools: 8000418: javadoc should used a standard "generated by javadoc" string

2012-10-10 Thread jonathan . gibbons
Changeset: 6517bf8e50d0 Author:jjg Date: 2012-10-10 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6517bf8e50d0 8000418: javadoc should used a standard "generated by javadoc" string Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDo

hg: jdk8/tl/langtools: 8000743: docencoding not available to stylesheet

2012-10-10 Thread jonathan . gibbons
Changeset: 560d4a5d14e6 Author:jjg Date: 2012-10-10 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/560d4a5d14e6 8000743: docencoding not available to stylesheet Reviewed-by: jjg Contributed-by: jvisw...@linux.vnet.ibm.com ! src/share/classes/com/sun/tools/doclets

hg: jdk8/tl/langtools: 8000665: fix "internal API" comments on javadoc files

2012-10-10 Thread jonathan . gibbons
Changeset: 25e14ad23cef Author:jjg Date: 2012-10-10 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25e14ad23cef 8000665: fix "internal API" comments on javadoc files Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemb

hg: jdk8/tl/jdk: 8000712: Remove unused fields in SyncFactory

2012-10-10 Thread lance . andersen
Changeset: 734ca9f4719c Author:lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java

hg: jdk8/tl/jdk: 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods

2012-10-10 Thread alan . bateman
Changeset: 6455182d2797 Author:alanb Date: 2012-10-10 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6455182d2797 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods Reviewed-by: mchung, lancea, chegar ! src/share/classes/jav

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Jaroslav Bachorik
Thanks, could you update with this webrev? I've fixed the problem with hgmq <-> webrev where the file copy is mistakenly marked as a file move. Thanks, -JB- On 10/10/2012 08:32 PM, Dmitry Samersoff wrote: > Jaroslav, > > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Dmitry Samersoff
Jaroslav, The fix looks good for me. -Dmitry On 2012-10-10 22:25, Jaroslav Bachorik wrote: > On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >> Jaroslav, >> >> Not able to open it as a webrev - only list of files. >> >> E-mail me the webrev and I'll put it to >> file:///opt/src/jdks

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Dmitry Samersoff
Jaroslav, http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/ -Dmitry On 2012-10-10 22:25, Jaroslav Bachorik wrote: > On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >> Jaroslav, >> >> Not able to open it as a webrev - only list of files. >> >> E-mail me the w

Re: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-10-10 Thread Eamonn McManus
Hi Jaroslav, The patch looks correct and the test is ingenious. I do not understand why the previous SerializationTest needs to be deleted. It doesn't seem that the new test is covering the same things. Reviewed-by: emcmanus Incidentally I was not able to find a way to see the patch with the us

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Dmitry Samersoff
Jaroslav, Not able to open it as a webrev - only list of files. E-mail me the webrev and I'll put it to cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/N -Dmitry On 2012-10-10 18:39, Jaroslav Bachorik wrote: > I am sorry for the webrev URL - a stale clipboard :( > > The correct webrev U

hg: jdk8/tl/jdk: 8000687: Correct javadoc typo for getLogWriter and setLogWriter

2012-10-10 Thread lance . andersen
Changeset: 3c4be36de073 Author:lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Jaroslav Bachorik
I am sorry for the webrev URL - a stale clipboard :( The correct webrev URL is https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 -JB- On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: > I am looking for a review and a sponsor. > > The issue is about some javax.manageme

[PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-10 Thread Jaroslav Bachorik
I am looking for a review and a sponsor. The issue is about some javax.management.timer.Timer notifications not being received by the listeners if the notifications are generated rapidly. The problem is caused by ConcurrentModificationException being thrown - the exception itself is ignored but t

Re: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-10-10 Thread dmitry . samersoff
I'll sponsor the fix and will review it later today. -Dmitry -Original Message- From: Jaroslav Bachorik To: jmx-...@openjdk.java.net, serviceability-dev@openjdk.java.net Sent: Wed, 10 Oct 2012 12:48 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/

[PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-10-10 Thread Jaroslav Bachorik
I am looking for a review and a sponsor for this fix. The issue is about an empty array of descriptors being written as a part of the serialization process but not read when deserializing an MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream skips all unread custom written fi