Re: 答复: Errors when use universe command in CLHSDB

2013-01-18 Thread Mikael Gerdin
I saw an existing bug reported for this the other day: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005278 I cc:ed Yumin who currently owns the bug. /Mikael On 2013-01-18 04:54, 云达 wrote: Thanks Dan! Regards, Yunda *发件人:*Daniel D. Daugherty [mailto:daniel.daughe...@oracle.com]

hg: hsx/hotspot-rt/hotspot: 8006548: version wrong in new constantPool code

2013-01-18 Thread coleen . phillimore
Changeset: b5f6465019f6 Author:coleenp Date: 2013-01-17 22:11 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5f6465019f6 8006548: version wrong in new constantPool code Summary: fix increment problem with saved_version Reviewed-by: dholmes !

Re: RFR: 8003348: SA can not read core file on OS X

2013-01-18 Thread Staffan Larsen
Thanks for doing this Yumin! I tried to apply you patch and run it, but I can't get SA to open a core file. You can see the exception I get below. Is there some kind of setup I need to do? This is against a jvmg build of Hotspot. I also noticed that you forgot to update BugSpotAgent.java with

Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-18 Thread Rickard Bäckman
Hi all, would some please review the following change? With recent changes in hs24 the ProfileVM_lock is no longer in use. This small change set removes the lock. The changes that lead to this is also on their way into hsx, but are not yet there. If that change would go into hsx without this

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-18 Thread Aleksey Shipilev
On 01/18/2013 04:58 PM, Rickard Bäckman wrote: http://cr.openjdk.java.net/~rbackman/8006563/ Looks good to me (not a Reviewer), modulo: a) Are we sure this thing is not acquired in some weird way, i.e. through JVMTI, SA, or whatnot? b) The formatting of the predicate does not follow it's

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-18 Thread Rickard Bäckman
Aleksey, thanks for your review! a) It was before on of my own changes used in os_solaris.cpp (I think, for synchronization support for Suspend/Resume). I don't think we wanted something external to mess with that lock. b) I've changed the indentation slightly. Updated webrev at

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-18 Thread Aleksey Shipilev
On 01/18/2013 05:45 PM, Rickard Bäckman wrote: b) I've changed the indentation slightly. Updated webrev at http://cr.openjdk.java.net/~rbackman/8006563.2/ (or at least currently copying…) Thumbs up. -Aleksey.

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-18 Thread Staffan Larsen
Looks good! /Staffan On 18 jan 2013, at 14:45, Rickard Bäckman rickard.back...@oracle.com wrote: Aleksey, thanks for your review! a) It was before on of my own changes used in os_solaris.cpp (I think, for synchronization support for Suspend/Resume). I don't think we wanted something

hg: jdk8/tl/langtools: 8006561: Langtools test failure: missing diags/examples

2013-01-18 Thread maurizio . cimadamore
Changeset: 3d84ae209919 Author:mcimadamore Date: 2013-01-18 15:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg +

Re: RFR: 8003348: SA can not read core file on OS X

2013-01-18 Thread Yumin Qi
This should be essential change in the fix, let me check if I missed file in the list. Thanks Yumin On 1/18/2013 3:58 AM, Staffan Larsen wrote: Thanks for doing this Yumin! I tried to apply you patch and run it, but I can't get SA to open a core file. You can see the exception I get below.

hg: jdk8/tl/jdk: 8005120: Compiler warnings in socket transport native code

2013-01-18 Thread chris . hegarty
Changeset: f88e963960ae Author:jzavgren Date: 2013-01-18 17:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c !

hg: jdk8/tl/jdk: 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision

2013-01-18 Thread alan . bateman
Changeset: 06da8d0e Author:alanb Date: 2013-01-18 18:48 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06da8d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar !

Re: RFR: 8003348: SA can not read core file on OS X

2013-01-18 Thread Yumin Qi
Hi, Staffan and all I have updated the webrev to reflect the changes of BugSpotAgent.java. Staffan, possibly you did not copy sa-jdi.jar file to your binary to cause this exception. Thanks Yumin On 1/18/2013 3:58 AM, Staffan Larsen wrote: Thanks for doing this Yumin! I tried to apply