hg: jdk8/tl/jdk: 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification

Changeset: 470f19b6bfdd Author:jbachorik Date: 2013-05-02 13:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470f19b6bfdd 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Summary: RemoteServer.getClientHost is returning a String w

hg: jdk8/tl/jdk: 8013855: DigestMD5Client has not checked RealmChoiceCallback value

Changeset: 81be41c7323f Author:weijun Date: 2013-05-03 10:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81be41c7323f 8013855: DigestMD5Client has not checked RealmChoiceCallback value Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/security/sasl/digest/DigestMD5C

hg: jdk8/tl/jdk: 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name

Changeset: 3062bf908281 Author:khazra Date: 2013-05-02 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3062bf908281 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Summary: Remove buffer overruns in native code Reviewed-by: alanb, che

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

Staffan, Code looks good. Many thanks for fixing this - sorry we missed this when adding the default method handling. thanks, Karen On May 2, 2013, at 1:39 PM, serguei.spit...@oracle.com wrote: > On 5/2/13 8:26 AM, Staffan Larsen wrote: >> >> On 2 maj 2013, at 16:33, Robert Field wrote: >> >

Re: RFR: 7150256/8004095: Add back Remote Diagnostic Commands

Karen, Thank you for the review. 1. 2. and 3. have been fixed. Regarding 4. Most (all?) permissions have a name argument. However, if p._name is null, the string "(null)" is printed. This is not wrong, but not very pretty: Permission: MyPermission((null)). I've changed the code (both 105 and

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

On 5/2/13 8:26 AM, Staffan Larsen wrote: On 2 maj 2013, at 16:33, Robert Field > wrote: On 05/02/13 04:08, Staffan Larsen wrote: On 2 maj 2013, at 12:58, serguei.spit...@oracle.com wrote: If I understand correctly, the

Re: RFR: 7150256/8004095: Add back Remote Diagnostic Commands

Frederic, Code looks good - actually it looks very clean. Ship it. Couple of minor comments that don't require re-review: 1. nmtDCmd.hpp/cpp - copyrights 2012 -> 2012, 2013 2. jmm.h line 213: "True is" -> "True if" 3. diagnosticFramework.hpp Thank you for the comments! line 298 "rational

hg: jdk8/tl/jdk: 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile

Changeset: 5045eb04a579 Author:mduigou Date: 2013-05-02 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5045eb04a579 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Reviewed-by: mduigou, henryjen, alanb, martin, psandoz Contributed-by: akhil.ar...@o

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

On 2 maj 2013, at 16:33, Robert Field wrote: > On 05/02/13 04:08, Staffan Larsen wrote: >> >> On 2 maj 2013, at 12:58, serguei.spit...@oracle.com wrote: >> >>> >>> If I understand correctly, the default methods are generated by the VM and >>> have no presence in class file. >>> Is that right

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

On 05/02/13 04:08, Staffan Larsen wrote: On 2 maj 2013, at 12:58, serguei.spit...@oracle.com wrote: If I understand correctly, the default methods are generated by the VM and have no presence in class file. Is that right? Yes, that is my understanding

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

Hi Kirk, Now I understand you. The situation you mentioned happens in the "gc.log" file. My fix won't affect it because EnableTracing doesn't change things already there. It just adds event records. At least I think so. Regards, Yunda From: Kirk Pepperd

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

Staffan, Thanks! Regards, Yunda From: Staffan Larsen [staffan.lar...@oracle.com] Sent: Thursday, May 02, 2013 20:57 To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

Rickard, Thanks for the review! Regards, Yunda From: Rickard Bäckman [rickard.back...@oracle.com] Sent: Thursday, May 02, 2013 13:11 To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] EnableTrac

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

Hi Yunda, Sorry for not being clear about this. The CMS collector injects records into the middle of young gen (ParNew/DefNew) collections. Sorry for the noise but this is due to a different issue in how logging is performed. Regards, Kirk On 2013-05-02, at 3:42 PM, 云达(Yunda) wrote: > Kirk,

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

Kirk, I'm not quite clear what "the other mixed up log files" means, since when using EnableTracing the output uses stdout by default. Regards, Yunda From: Kirk Pepperdine [k...@kodewerk.com] Sent: Thursday, May 02, 2013 21:05 To: Staffan Larsen Cc: 云达(Y

Re: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException

Hi Kevin, Looks good! I've been looking into improving the quality of native stack traces on Windows using IDebugControl::GetStackTrace. This has the advantage of handling some FPO frames on x86 (a common source of these exceptions), as well as supporting AMD64 (walking the stack using RBP doe

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

What effect with this have on the other mixed up log files? Regards, Kirk On 2013-05-02, at 2:57 PM, Staffan Larsen wrote: > Looks good. (not a reviewer) > > /Staffan > > On 2 maj 2013, at 05:07, 云达(Yunda) wrote: > >> Could anyone review this for me, please? >> >> Regards, >> Yunda >> >

Re: [PATCH] EnableTracing: output from multiple threads may be mixed together

Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, 云达(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: 云达(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net > Subje

Re: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException

I think this looks good. Thanks for doing this. /Staffan On 30 apr 2013, at 19:02, Kevin Walls wrote: > Hi, > > I'd like some review of this suggestion to fix: > 6313816 SA windows unaligned address exception > > webrev: > http://cr.openjdk.java.net/~kevinw/6313816/webrev/ > > This bug is a

hg: jdk8/tl/jdk: 8013225: Refresh jdk's private ASM to the latest.

Changeset: 167d2dca Author:ksrini Date: 2013-05-01 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/167d2dca 8013225: Refresh jdk's private ASM to the latest. Reviewed-by: mduigou, sundar ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java !

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

On 2 maj 2013, at 12:58, serguei.spit...@oracle.com wrote: > > If I understand correctly, the default methods are generated by the VM and > have no presence in class file. > Is that right? Yes, that is my understanding. > Then the fix looks good. Thanks! > A typo - "be included": > 631 /

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

Thanks Serguei! I'll fix both of these before pushing. /Staffan On 2 maj 2013, at 12:24, serguei.spit...@oracle.com wrote: > This looks good. > Thank you for discovering and fixing it! > > A couple of cosmetic comments: > 352 //} >Indent for "}" is needed > > 376 u2 bootstrap_argu

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

If I understand correctly, the default methods are generated by the VM and have no presence in class file. Is that right? Then the fix looks good. A typo - "be included": 631 // and should not b included in the total count Thanks, Serguei On 5/2/13 1:51 AM, Staffan Larsen wrote: Jvmt

Re: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar

On 02/05/2013 11:52, Jaroslav Bachorik wrote: : Thanks Alan, the comments are addressed in http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.03 -JB- Looks good to me. -Alan

Re: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar

On Čt 2. květen 2013, 12:48:06 CEST, Alan Bateman wrote: > On 02/05/2013 11:39, Jaroslav Bachorik wrote: >> On Čt 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: >>> On 25/04/2013 15:35, Jaroslav Bachorik wrote: Reviving the review process. I still need an official openjdk reviewe

Re: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar

On 02/05/2013 11:39, Jaroslav Bachorik wrote: On Čt 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: On 25/04/2013 15:35, Jaroslav Bachorik wrote: Reviving the review process. I still need an official openjdk reviewer for this. Thanks, -JB- Just so I understand, the issue is that RemoteSe

Re: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar

On Čt 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: > On 25/04/2013 15:35, Jaroslav Bachorik wrote: >> Reviving the review process. >> >> I still need an official openjdk reviewer for this. >> >> Thanks, >> >> -JB- > Just so I understand, the issue is that RemoteServer.getClientHost is > retur

Re: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

This looks good. Thank you for discovering and fixing it! A couple of cosmetic comments: 352 //} Indent for "}" is needed 376 u2 bootstrap_arguments = cpool()->operand_argument_index_at(n, arg); It is about one argument. Should the variable name be: "bootstrap_argument" ? T

RE: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

Looks good Staffan (not a reviewer). Cheers Markus -Original Message- From: Staffan Larsen Sent: den 2 maj 2013 10:51 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: RFR: 8009615: JvmtiClassFileReconstituter does

RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't p

RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug: htt