This looks good. Thank you for discovering and fixing it!
A couple of cosmetic comments: 352 //} Indent for "}" is needed 376 u2 bootstrap_arguments = cpool()->operand_argument_index_at(n, arg); It is about one argument. Should the variable name be: "bootstrap_argument" ? Thanks, Serguei On 5/2/13 1:50 AM, Staffan Larsen wrote:
JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. Thanks, /Staffan
