Looks good.
I've overlooked it too. :(
Thanks,
Serguei
On 5/6/13 10:58 PM, Staffan Larsen wrote:
On 6 maj 2013, at 23:58, John Rose john.r.r...@oracle.com
mailto:john.r.r...@oracle.com wrote:
On May 2, 2013, at 1:50 AM, Staffan Larsen staffan.lar...@oracle.com
Please review this little fix to remove the _g support from the SA files.
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038
webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/
Thanks,
/Staffan
Changeset: 9c9b2385c1b0
Author:jfranck
Date: 2013-05-07 09:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c9b2385c1b0
8013541: Revise javadoc for Executable.getAnnotatedReturnType()
Reviewed-by: abuckley, darcy
! src/share/classes/java/lang/reflect/Executable.java
Staffan,
this looks good to me (not a Reviewer).
/R
On May 7, 2013, at 10:02 AM, Staffan Larsen wrote:
Please review this little fix to remove the _g support from the SA files.
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038
webrev:
Hi David,
Thanks for the review and I see your concern. Please see the updated change
below:
diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp
--- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700
+++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800
@@
David,
I've made a stupid mistake and please ignore it...
Regards,
Yunda
-Original Message-
From: 云达(Yunda)
Sent: Tuesday, May 07, 2013 5:44 PM
To: 'David Holmes'
Cc: hotspot-runtime-...@openjdk.java.net;
serviceability-dev@openjdk.java.net
Subject: RE: [PATCH] EnableTracing:
On 7/05/2013 7:43 PM, 云达(Yunda) wrote:
Hi David,
Thanks for the review and I see your concern. Please see the updated change
below:
diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp
--- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700
+++
Changeset: 452e1a182907
Author:dfuchs
Date: 2013-05-06 18:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/452e1a182907
8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes
some JCK tests to fail intermittently
Summary: Encodings.java sometimes
Changeset: 2602eab5f086
Author:dfuchs
Date: 2013-05-07 11:35 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2602eab5f086
8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes
some JCK tests to fail intermittently
Summary: Encodings.java sometimes
Hi Staffan,
I think this looks good.
Two minor comments about the @run commands.
Both of these will use the SerialOld collector and since the test really
only test the old generation I think one is enough:
* @run main/othervm -XX:+UseSerialGC -Xmn8m ResetPeakMemoryUsage
* @run
Thanks Bengt.
I'll make those changes before pushing the fix.
/Staffan
On 7 maj 2013, at 13:24, Bengt Rutisson bengt.rutis...@oracle.com wrote:
Hi Staffan,
I think this looks good.
Two minor comments about the @run commands.
Both of these will use the SerialOld collector and since
Hi -
I'd like to get another review from an openjdk user/reviewer/...
Thanks
Kevin
On 03/05/13 09:32, Kevin Walls wrote:
Thanks Staffan, thanks Peter!
On 02/05/13 14:11, Peter Allwin wrote:
Looks good.
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 7 maj 2013 10:03
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RFR(S): 8005038 remove crufty '_g' support from SA
Please review this
David,
Sorry about the stupid mistake. And please see the tested change below. Since I
don't find an elegant way to define a ttyLocker object, I use the static
methods of ttyLocker instead.
diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp
--- a/src/share/vm/runtime/globals.hpp Mon May 06
This is an old fix that fell between the cracks. Before JDK-7175133 was fixed,
jinfo/Basic.sh was modified so that it wouldn't use SA. Now that JDK-7175133 is
fixed, we can return to using SA.
webrev:
http://cr.openjdk.java.net/~sla/8004007/webrev.00/test/sun/tools/jinfo/Basic.sh.sdiff.html
On 07/05/2013 13:43, Staffan Larsen wrote:
This is an old fix that fell between the cracks. Before JDK-7175133 was fixed,
jinfo/Basic.sh was modified so that it wouldn't use SA. Now that JDK-7175133 is
fixed, we can return to using SA.
webrev:
Looks good for me.
On 2013-05-07 16:43, Staffan Larsen wrote:
This is an old fix that fell between the cracks. Before JDK-7175133 was
fixed, jinfo/Basic.sh was modified so that it wouldn't use SA. Now that
JDK-7175133 is fixed, we can return to using SA.
webrev:
Hi,
Please check with the serviceability team (CC:ed) before adding a flag to
control the threshold. I suspect that they would prefer some tracing specific
way to configure these thresholds.
/Jesper
Erik Helin skrev 7/5/13 2:58 PM:
Hi Bengt,
thanks for the review!
On 05/07/2013 11:42 AM,
Changeset: b5fef8013a95
Author:sla
Date: 2013-05-07 14:04 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
8014044: Spelling error in JDK-8009615: boostrapmethod
Reviewed-by: sspitsyn, coleenp
! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
!
Changeset: 7b40394ad944
Author:sla
Date: 2013-05-07 19:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b40394ad944
6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust
when getMax() returns -1
7181907: TEST_BUG:
Changeset: 100027950b05
Author:sla
Date: 2013-05-07 20:00 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/100027950b05
8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true
Reviewed-by: alanb, dsamersoff
! test/sun/tools/jinfo/Basic.sh
Changeset: e30396e22c6f
Author:naoto
Date: 2013-05-07 11:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e30396e22c6f
8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied
Reviewed-by: okutsu
!
Changeset: f6a055fcf47d
Author:sla
Date: 2013-05-07 14:33 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
8005038: remove crufty '_g' support from SA
Reviewed-by: coleenp, mgronlun, rbackman
! agent/src/os/bsd/ps_core.c
! agent/src/os/linux/ps_core.c
Changeset: fe4e9bc2186f
Author:mduigou
Date: 2013-05-07 12:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe4e9bc2186f
4802647: Throw required NPEs from removeAll()/retainAll()
Reviewed-by: mduigou, chegar, dholmes
Contributed-by: Brandon Passanisi
Jesper,
I've changed the flag to be an experimental flag instead of a product flag.
Please see new webrev at:
http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/
Thanks,
Erik
On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote:
Hi,
Please check with the serviceability team (CC:ed) before
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
I've changed the flag to be an experimental flag instead of a product flag.
Thanks!
Please see new webrev at:
http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/
If you want to change the description of the flag to say ... to generate a
trace
Hurrah, the wicked _g witch is dead!
If my review is worth anything, looks good.
I started the _g removal so long ago, glad to see this being done.
-kto
P.S. People probably thought I was run over by a truck or something, but I am
lurking around still. :)
On May 7, 2013, at 1:02 AM, Staffan
On 5/7/13 2:09 PM, Kelly O'Hair wrote:
Hurrah, the wicked _g witch is dead!
Close, but not quite there:
JDK-8005073 remove crufty '_g' support from HS tests
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005073
https://jbs.oracle.com/bugs/browse/JDK-8005073
Just one left to
Dan you are so correct, JDK-8005073 is not a hard one just needs to be done. A
good starter bug.
-Original Message-
From: Daniel D. Daugherty
Sent: Tuesday, May 07, 2013 2:28 PM
To: Kelly O'Hair
Cc: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net;
Changeset: 33bcd9ead1d5
Author:ctornqvi
Date: 2013-05-07 21:36 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/33bcd9ead1d5
8009577: Test test/closed/runtime/classunload broken
Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with
where
Changeset: 43c2f7cb9c76
Author:jjg
Date: 2013-05-07 14:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76
8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg
can't delete plugin.jar
Reviewed-by: vromero, mcimadamore
!
Changeset: 6feee75b0a8b
Author:briangoetz
Date: 2013-05-06 11:43 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6feee75b0a8b
8012664: Add tests for java.util.stream and lambda translation
Reviewed-by: mduigou, briangoetz
Contributed-by: Brian Goetz brian.go...@oracle.com,
Hi Jaroslav,
Great to see this shell test get rewritten!
Looks like you're avoiding multiple JVM processes as well, by loading the
different versions of the classes into different classloaders. It looks like a
bit of trouble, but probably less than the amount of trouble caused by the
shell
On 7/05/2013 10:33 PM, 云达(Yunda) wrote:
David,
Sorry about the stupid mistake. And please see the tested change below. Since I
don't find an elegant way to define a ttyLocker object, I use the static
methods of ttyLocker instead.
Yeah there's no elegant solution when you need to
Changeset: 58bb870a0cbd
Author:emc
Date: 2013-05-07 13:45 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/58bb870a0cbd
8009729: Refix hotspot jni_cpu.h JNIEXPORT and JNIIMPORT definitions to match
jdk version
Summary: Update JNIEXPORT and JNIIMPORT to work with
35 matches
Mail list logo
