Looks good.
I've overlooked it too. :(
Thanks,
Serguei
On 5/6/13 10:58 PM, Staffan Larsen wrote:
On 6 maj 2013, at 23:58, John Rose <john.r.r...@oracle.com
<mailto:john.r.r...@oracle.com>> wrote:
On May 2, 2013, at 1:50 AM, Staffan Larsen <staffan.lar...@oracle.com
<mailto:staffan.lar...@oracle.com>> wrote:
JvmtiClassFileReconstituter does not create BootstrapMethod
attributes when re-creating a class for retransformation. This fix
uses the operands in the constant pool to re-create the
BootstrapMethod attributes in the class file.
webrev:http://cr.openjdk.java.net/~sla/8009615/webrev.00/
<http://cr.openjdk.java.net/%7Esla/8009615/webrev.00/>
bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615
Testing done: java/lang/instrument, com/sun/jdi,
nsk.quick-jvmti.testlist
I have not written a regression test since this was found by running
the existing java/lang/instrument/IsModifiableClassAgent.java test.
Good. And I agree with Serguei's comments.
One more typo: write_boostrapmethod_attribute should
be write_bootstrapmethod_attribute. "Boostrap" sounds like it has to
do with astronaut rappers, or maybe ghost trappers.
Oops. I had already pushed the change. Here is an additional webrev
for the spelling error (found one more as well).
http://cr.openjdk.java.net/~sla/8014044/webrev.00/
<http://cr.openjdk.java.net/%7Esla/8014044/webrev.00/>
Thanks,
/Staffan
