Changeset: 712a1e9c91f3
Author:coleenp
Date: 2013-05-07 09:46 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/712a1e9c91f3
8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on
os::free
Summary: Clear out class_file_bytes so they aren't
One option could be to move the content of writeEvent() to its own method
(maybe writeEventContent()) and just do
if (UseLockedTracing) {
ttyLocker lock;
writeEventContent();
} else {
writeEventContent();
}
I think it makes it easier to read.
/R
On May 8, 2013, at 2:41 AM, David Holmes
Erik,
Looks good!
Bengt
On 5/7/13 9:28 PM, Erik Helin wrote:
Jesper,
I've changed the flag to be an experimental flag instead of a product
flag.
Please see new webrev at:
http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/
Thanks,
Erik
On 05/07/2013 03:54 PM, Jesper Wilhelmsson
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
I've changed the flag to be an experimental flag instead of a product
flag.
Thanks!
Please see new webrev at:
Looks good to me Staffan!
(Those methods should have been called getXXXCount not Counter though :( )
David
On 8/05/2013 6:17 PM, Staffan Larsen wrote:
When JDK-8010862 (Method counter fields used for profiling can be allocated
lazily) was fixed, SA was not updated to reflect this change.
On 8 maj 2013, at 10:46, David Holmes david.hol...@oracle.com wrote:
Looks good to me Staffan!
Thanks.
(Those methods should have been called getXXXCount not Counter though :( )
We can fix that at the same time:
http://cr.openjdk.java.net/~sla/8013591/webrev.01/
/Staffan
David
On
Jesper,
On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
I've changed the flag to be an experimental flag instead of a product
flag.
Thanks!
Please see
Hi,
please review this small change.
The change adds a check to see the result of a malloc() and aborts the VM with
an out of memory error.
Webrev: http://cr.openjdk.java.net/~rbackman/8008255/
Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255
Thanks
/R
Erik Helin skrev 8/5/13 1:00 PM:
Jesper,
On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
I've changed the flag to be an experimental flag instead of a
Changeset: 780014a234fa
Author:jfranck
Date: 2013-05-08 14:10 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/780014a234fa
8013485: javac can't handle annotations with a clinit from a previous
compilation unit
Reviewed-by: mcimadamore
!
Thank you, Staffan
/R
On May 8, 2013, at 2:17 PM, Staffan Larsen wrote:
Looks good.
/Staffan
On 8 maj 2013, at 13:08, Rickard Bäckman rickard.back...@oracle.com wrote:
Hi,
please review this small change.
The change adds a check to see the result of a malloc() and aborts the VM
Looks good.
/Staffan
On 8 maj 2013, at 13:08, Rickard Bäckman rickard.back...@oracle.com wrote:
Hi,
please review this small change.
The change adds a check to see the result of a malloc() and aborts the VM
with an out of memory error.
Webrev:
Change looks good, can tell me what tests were run?
Were able create a unit test that triggers the failure ?
Thx Ron
-Original Message-
From: Staffan Larsen
Sent: Wednesday, May 08, 2013 6:17 AM
To: Rickard Bäckman
Cc: serviceability-dev@openjdk.java.net
Ron,
Thanks for the review.
I ran the change through JPRT.
Creating a specific test for this seems rather problematic as we need to make
sure that a specific malloc() fails.
/R
On May 8, 2013, at 2:31 PM, Ron Durbin wrote:
Change looks good, can tell me what tests were run?
Were able
Looks fine to me. As we discussed in the bug report there's no
reasonable way to report the error so an abort is the only way out.
David
On 8/05/2013 9:08 PM, Rickard Bäckman wrote:
Hi,
please review this small change.
The change adds a check to see the result of a malloc() and aborts the VM
Ron,
On 8/05/2013 10:31 PM, Ron Durbin wrote:
Change looks good, can tell me what tests were run?
This kind of change requires very limited testing - JPRT testing will
suffice. Adding a NULL check with a vm_exit_out_of_memory is not
something that needs extensive testing applied.
Were
Rickard
I glad to hear that you did run it through JPRT.
The fixes for bugs like this one I have needed a test hook that forces the code
execution into the fixed
Code path.
Ron
-Original Message-
From: Rickard Bäckman
Sent: Wednesday, May 08, 2013 6:34 AM
To: Ron Durbin
Cc:
Thank you David
/R
On May 8, 2013, at 2:44 PM, David Holmes wrote:
Looks fine to me. As we discussed in the bug report there's no reasonable way
to report the error so an abort is the only way out.
David
On 8/05/2013 9:08 PM, Rickard Bäckman wrote:
Hi,
please review this small
On 5/8/13 5:08 AM, Rickard Bäckman wrote:
Hi,
please review this small change.
The change adds a check to see the result of a malloc() and aborts the VM with
an out of memory error.
Webrev: http://cr.openjdk.java.net/~rbackman/8008255/
Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255
Thanks!
Erik
On 05/08/2013 01:29 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 1:00 PM:
Jesper,
On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
Changeset: cbfe859bd244
Author:sla
Date: 2013-05-08 15:37 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
8013591: compiler/ciReplay/TestSA.sh fails in nightly
Reviewed-by: coleenp, rbackman, dholmes
!
Changeset: c8f47674d105
Author:alanb
Date: 2013-05-08 18:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8f47674d105
8013652: (profiles) Add javax.script to compact1
Reviewed-by: mchung, dholmes
! makefiles/profile-rtjar-includes.txt
Changeset: 39ead0411f07
Author:bharadwaj
Date: 2013-05-08 14:18 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39ead0411f07
8013875: Incorrect vtable index being set during methodHandle creation for
static
Summary: Set vtable index as appropriate for static
Changeset: 711016f146fd
Author:dholmes
Date: 2013-05-08 19:28 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/711016f146fd
8006997: ContendedPaddingWidth should be range-checked
Summary: Constrain between zero and 8K
Reviewed-by: dholmes, rbackman
Contributed-by:
24 matches
Mail list logo
