Changeset: e619a2766bcc
Author:rbackman
Date: 2013-06-12 11:17 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e619a2766bcc
8016131: nsk/sysdict/vm/stress/chain tests crash the VM in
'entry_frame_is_first()'
Reviewed-by: jrose, kvn, mgronlun
!
Hi again,
Trying again, could I please have a couple of reviews for this?
Many thanks
Markus
From: Markus Grönlund
Sent: den 16 juli 2013 17:48
To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: RFR(XS): 8020547 : Event based tracing needs a UNICODE
Hi Markus,
Looks reasonable.
Bengt
On 7/17/13 12:25 PM, Markus Grönlund wrote:
Hi again,
Trying again, could I please have a couple of reviews for this?
Many thanks
Markus
From: Markus Grönlund
Sent: den 16 juli 2013 17:48
To: serviceability-dev@openjdk.java.net;
Looks good! (not a Reviewer)
/Erik
Markus Grönlund skrev 7/16/13 5:48 PM:
Greetings,
Kindly asking for reviews for the following change in hsx24:
Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547
Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/
Looks good to me.
/R
On Jul 17, 2013, at 12:25 PM, Markus Grönlund wrote:
Hi again,
Trying again, could I please have a couple of reviews for this?
Many thanks
Markus
From: Markus Grönlund
Sent: den 16 juli 2013 17:48
To: serviceability-dev@openjdk.java.net;
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread using
different OS-specific methods.
Webrev: http://cr.openjdk.java.net/~rbackman/8020701/webrev/
Thanks
/R
Sorry everyone, wrong bugnr in the topic.
It should be 8020701.
/R
On Jul 17, 2013, at 1:58 PM, Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread
using different OS-specific
Thank you David.
/R
On Jul 17, 2013, at 2:56 PM, David Simms wrote:
Looks good to me.
On 17/07/2013 1:58 p.m., Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread
using
Looks good to me.
On 17/07/2013 1:58 p.m., Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread using
different OS-specific methods.
Webrev:
On 7/16/13 9:48 AM, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following change in hsx24:
Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547
Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/
http://cr.openjdk.java.net/%7Emgronlun/8020547/webrev01/
Changeset: 44e27378f523
Author:mcimadamore
Date: 2013-07-17 14:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523
8012242: Lambda compatibility and checked exceptions
Summary: Inference variables in 'throws' clause with no constraints should be
inferred as
Changeset: 10711bd8bb2d
Author:jlahoda
Date: 2013-07-17 15:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d
8020586: Warning produced for an incorrect file
Summary: Always using DeferredLintHandler.immediateHandler when processing
import classes
Markus,
Looks good.
(Ok, I miss the comment about j.l.Thread :-)
ship it!
Karen
On Jul 16, 2013, at 11:48 AM, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following change in hsx24:
Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547
Webrev:
Code looks good. Thank you for the assertions and comments.
Cleanly done, as usual for your changes Rickard.
thanks,
Karen
On Jul 17, 2013, at 8:22 AM, Rickard Bäckman wrote:
Sorry everyone, wrong bugnr in the topic.
It should be 8020701.
/R
On Jul 17, 2013, at 1:58 PM, Rickard Bäckman
Thank you for the review Karen!
/R
On Jul 17, 2013, at 5:00 PM, Karen Kinnear wrote:
Code looks good. Thank you for the assertions and comments.
Cleanly done, as usual for your changes Rickard.
thanks,
Karen
On Jul 17, 2013, at 8:22 AM, Rickard Bäckman wrote:
Sorry everyone, wrong
- Original Message -
Thanks for the patch, I think it sounds like a good idea. For consistency,
however, we need to do the same modifications to the other platforms
(solaris, windows) and preferably add tests for this functionality as well.
The patch makes sense to me.
While a very
Thanks Dan!
No technical reason for the *(star) placements in this file, it might be more
readable for a human with a space added or something, I don't know, one of
those human aspects again called preferences or something.
Cheers
Markus
From: Daniel D. Daugherty
Sent: den 17 juli
Many thanks for your reviews!
Markus
From: Karen Kinnear
Sent: den 17 juli 2013 17:06
To: Markus Grönlund
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type
(hsx24)
Markus,
On 7/17/13 5:58 AM, Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread using
different OS-specific methods.
Webrev: http://cr.openjdk.java.net/~rbackman/8020701/webrev/
Thanks
/R
On Jul 17, 2013, at 7:03 PM, Daniel D. Daugherty wrote:
On 7/17/13 5:58 AM, Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread
using different OS-specific methods.
Webrev:
Changeset: 10a1ab9e20a4
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10a1ab9e20a4
Added tag jdk8-b98 for changeset 542b7803f038
! .hgtags
Changeset: 81cbb18d558a
Author:lana
Date: 2013-07-17 00:36 -0700
URL:
Changeset: 8ef83d4b23c9
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8ef83d4b23c9
Added tag jdk8-b98 for changeset b1fb4612a2ca
! .hgtags
Changeset: 2c26ccf0a85b
Author:tbell
Date: 2013-07-08 07:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c26ccf0a85b
8012925: [parfait] Missing return value in
jdk/src/macosx/native/sun/awt/AWTEvent.m
Reviewed-by: katleman, leonidr
Contributed-by: petr.pche...@oracle.com
Changeset: 3f67804ab613
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3f67804ab613
Added tag jdk8-b98 for changeset 3370fb6146e4
! .hgtags
Changeset: 8c4424890028
Author:amurillo
Date: 2013-06-28 02:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c4424890028
8019302: new hotspot build - hs25-b40
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 8cff1de240de
Author:zgu
Date: 2013-06-25
Changeset: adf49c3ef83c
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/adf49c3ef83c
Added tag jdk8-b98 for changeset 15e5bb51bc0c
! .hgtags
Changeset: 74ec7b48e3be
Author:lana
Date: 2013-07-17 00:34 -0700
URL:
Changeset: 0d0c983a817b
Author:tbell
Date: 2013-07-09 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/0d0c983a817b
8009315: F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)
Reviewed-by: erikj
! common/autoconf/generated-configure.sh
!
Changeset: bdeef606be8e
Author:katleman
Date: 2013-07-11 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdeef606be8e
Added tag jdk8-b98 for changeset ce5a90df517b
! .hgtags
Changeset: 39ec5d8a691b
Author:mcimadamore
Date: 2013-07-11 14:07 +0100
URL:
Changeset: 732af649bc3a
Author:ccheung
Date: 2013-07-17 12:22 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/732af649bc3a
8017498: JVM crashes when native code calls sigaction(sig) where sig=0x20
Summary: Added (sig MAXSIGNUM) check in jsig.c
Reviewed-by:
Changeset: 80e75aa6a707
Author:jjg
Date: 2013-07-17 18:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/80e75aa6a707
8014636: TestLiteralCodeInPre fails on windows
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
!
Changeset: 1476d54fdc61
Author:jjg
Date: 2013-07-17 19:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61
8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/doclint/DocLint.java
Changeset: 1e533c1bfb01
Author:jjg
Date: 2013-07-17 19:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01
8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/doclint/Checker.java
+
Changeset: 825e6cb66923
Author:jiangli
Date: 2013-07-17 18:06 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/825e6cb66923
8020309: Eliminate InstanceKlass::_cached_class_file_len.
Summary: Use JvmtiCachedClassFileData.
Reviewed-by: iklam, sspitsyn, dcubed
!
33 matches
Mail list logo
