Changeset: a0896634ab46
Author:sla
Date: 2013-08-22 08:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0896634ab46
8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails
Reviewed-by: ysr
! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.jav
Changeset: ec827a62070a
Author:xuelei
Date: 2013-08-21 19:44 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec827a62070a
808: Intermittent test failures in sun/security/ssl/javax/net/ssl/NewAPIs
Reviewed-by: weijun
! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionCac
Changeset: eebb29618f50
Author:emc
Date: 2013-08-21 20:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eebb29618f50
8023520: Add missing test for JDK-7118412
Summary: The test for JDK-7118412 was dropped from the changeset in a merging
accident.
Reviewed-by: jjg
+ t
Changeset: 57e1266527dd
Author:jjg
Date: 2013-08-21 17:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd
8022287: javac.sym.Profiles uses a static Map when it should not
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/sym/Profiles.java
+ test/t
Changeset: 2068190f8ac2
Author:emc
Date: 2013-08-21 20:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2068190f8ac2
7118412: Shadowing of type-variables vs. member types
4987840: What is the scope of an annotation?
Summary: Fixed issue with shadowing of type names.
Re
Thx Staffan. This looks fine for now, but I suggest a CR to keep track of the
G1 failure and to fix it. That CR probably belongs in the GC category, and is
low priority because it's a quality of implementation issue rathe than a
correctness issue wrt spec.
Thanks.
--Ramki
ysr1729
On Aug 21,
Changeset: 7de231613e4a
Author:jjg
Date: 2013-08-21 16:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a
8023515: import type-annotations updates
Reviewed-by: jjg
Contributed-by: wdi...@gmail.com
! src/share/classes/com/sun/source/tree/MethodTree.java
! sr
Changeset: fad3b6673159
Author:mduigou
Date: 2013-08-21 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad3b6673159
8023306: Add replace() implementations to TreeMap
Reviewed-by: psandoz, alanb, chegar, bpb
! src/share/classes/java/util/TreeMap.java
Changeset: 91a31c7
Changeset: 60891d90327f
Author:henryjen
Date: 2013-08-20 14:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60891d90327f
8016846: Pattern.splitAsStream tests required
Reviewed-by: alanb, psandoz
Contributed-by: Ben Evans
+ test/java/util/regex/PatternTest.java
On 8/21/13 11:22 AM, Ioi Lam wrote:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
Thumbs up.
make/windows/build_vm_def.sh
No comments.
make/windows/makefiles/debug.ma
On 08/21/13 12:34 PM, Tim Bell wrote:
Hello Ioi:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
make/windows/build_vm_def.sh
Seems as if line 86:
86 "$CAT" vm1.def vm2.d
Hello Ioi:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
make/windows/build_vm_def.sh
Seems as if line 86:
86 "$CAT" vm1.def vm2.def > vm.def
Will clobber the friendly
A couple of more comments:
- It was a little too hard to figure out exactly how the tests worked: who is
sending JDP packets? who is listening for them? who is launching the tests?
Perhaps it would make sense to add a small readme which explains how it all
fits together?
- There are already so
Looks good!
/Staffan
On 21 aug 2013, at 18:18, Markus Grönlund wrote:
> Thanks Karen,
>
> Based on some feedback, I have updated the naming of this lock and grouped
> them all inside the INCLUDE_TRACE guard.
>
> Updated webrev:
> http://cr.openjdk.java.net/~mgronlun/8023457/webrev02/
>
>
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
Thanks
- Ioi
On 08/21/2013 09:57 AM, Ioi Lam wrote:
Good catch! I tried to sneak this in :-)
SKIP_GENERATED can be set as an
Good catch! I tried to sneak this in :-)
SKIP_GENERATED can be set as an environment variable to skip the
'generated' directory. I have an external script that checks if the file
generated/_build_pch_file.cpp already exists. If so, it will set
SKIP_GENERATED=1 before calling build.bat. This wo
Alex,
This looks a lot better than the previous version. Thanks for cleaning things
up. Below are a couple of comments:
- Use of "package" is discouraged for jtreg test:
http://openjdk.java.net/jtreg/faq.html#question4.9
- Maybe change name of SpecificLauncher.java to SpecificJdpAddressLaunche
Thanks Karen,
Based on some feedback, I have updated the naming of this lock and grouped them
all inside the INCLUDE_TRACE guard.
Updated webrev:
http://cr.openjdk.java.net/~mgronlun/8023457/webrev02/
Thanks
Markus
From: Karen Kinnear
Sent: den 21 augusti 2013 17:15
To: Markus G
Changeset: 8996f47f738d
Author:sla
Date: 2013-08-21 17:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8996f47f738d
8023485: Remove com/sun/jdi/DoubleAgentTest.java and
com/sun/jdi/FieldWatchpoints.java from ProblemList.txt
Reviewed-by: chegar, mgronlun
! test/ProblemList
Thanks Chris and Markus.
/Staffan
On 21 aug 2013, at 16:57, Chris Hegarty wrote:
> Looks good to me.
>
> -Chris
>
> On 21 Aug 2013, at 15:31, Markus Grönlund wrote:
>
>> Thanks for taking a look at these old bugs Staffan.
>>
>> Looks good (not a Reviewer).
>>
>> /Markus
>>
>>
>>
>> ---
Looks good.
thanks,
Karen
On Aug 21, 2013, at 7:11 AM, Markus Grönlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following:
>
> Bugid: http://bugs.sun.com/view_bug.do?bug_id=8023457
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8023457/webrev01/
>
> Thanks
> Markus
Looks good to me.
-Chris
On 21 Aug 2013, at 15:31, Markus Grönlund wrote:
> Thanks for taking a look at these old bugs Staffan.
>
> Looks good (not a Reviewer).
>
> /Markus
>
>
>
> -Original Message-
> From: Staffan Larsen
> Sent: den 21 augusti 2013 16:21
> To: core-libs-...@open
Thanks for taking a look at these old bugs Staffan.
Looks good (not a Reviewer).
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 21 augusti 2013 16:21
To: core-libs-...@openjdk.java.net; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net
Subject: RFR: R
I've had a look at these two old bugs:
http://bugs.sun.com/view_bug.do?bug_id=7020857
http://bugs.sun.com/view_bug.do?bug_id=6909804
They are both listed in ProblemList.txt and reported as intermittent failures
in 2011 and 2009 respectively.
I've been searching our test history for instances
Changeset: c6ec0a97b30a
Author:sla
Date: 2013-08-21 13:18 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c6ec0a97b30a
8022808: Kitchensink hangs on macos
Summary: Use pthread_mach_thread_np() instead of mach_thread_self() to avoid
leaking resources
Reviewed-by: dh
Staffan, do you think you can take another look this?
Thanks!
On 2013-07-04 14:26, Alex Schenkman wrote:
Thanks Staffan for your comments.
The indentation is corrected in all files, sorry about that.
About the racing condition in PortFinder.java, you are absolutely
right, there is no warranty
Greetings,
Kindly asking for reviews for the following:
Bugid: http://bugs.sun.com/view_bug.do?bug_id=8023457
Webrev: http://cr.openjdk.java.net/~mgronlun/8023457/webrev01/
Thanks
Markus
Approved for jdk7u-dev.
cheers,
dalibor topic
On 8/21/13 1:11 AM, Mandy Chung wrote:
> Looks okay to me.
>
> Mandy
>
> On 8/19/2013 11:16 AM, Erik Gahlin wrote:
>> Thanks Andreas,
>>
>> Here is an updated webrev with an updated copyright header.
>> http://cr.openjdk.java.net/~egahlin/7023754_2/
Reviewed!
Thanks,
David
On 21/08/2013 6:44 PM, Staffan Larsen wrote:
I still need a Reviewer to ok this.
Thanks,
/Staffan
On 19 aug 2013, at 11:08, Staffan Larsen wrote:
We are using the mach thread port name as the os thread identifier on OS X. We get this
value by calling mach_thread_se
Changeset: 3b8fed46b2a8
Author:dholmes
Date: 2013-08-21 05:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8
8023460: OPENJDK build fails due to missing jfr.jar
Reviewed-by: alanb
! makefiles/Profiles.gmk
Changeset: 68be998c2596
Author:egahlin
Date: 2013-08-19 12:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68be998c2596
6358357: Division by zero in Threads tab when shrinking jconsole window
Reviewed-by: mchung, leifs, jbachorik
! src/share/classes/sun/tools/jconsole/Plot
On 8/21/13 10:27 AM, shanliang wrote:
Jaroslav Bachorik wrote:
On 08/21/2013 12:00 AM, Daniel Fuchs wrote:
On 8/20/13 11:12 PM, shanliang wrote:
Thanks Daniel and Erik for the comments, here is new version:
http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/
This new version looks reaso
Looks good.
/Staffan
On 12 aug 2013, at 14:51, Peter Allwin wrote:
> Hello!
>
> This patch addresses several Nashorn compatibility issues with in sa.js and
> is a merge of my patch [0] and Kris' (kmo) [1] which were developed
> separately.
>
> The merged change is identical to [1] with exce
Changeset: eb18a483e772
Author:alanb
Date: 2013-08-21 09:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb18a483e772
8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile
Reviewed-by: lancea, mduigou
! test/TEST.ROOT
+ test/TEST.groups
We haven't seen this happen with CMS.
/Staffan
On 20 aug 2013, at 21:07, Srinivas Ramakrishna wrote:
> Hi Staffan --
>
> Thanks for the explanation. I see. Can you check if you can replicate
> that behaviour with CMS also? I submit that, as Shanliang states, this
> is not a best efforts behavi
I still need a Reviewer to ok this.
Thanks,
/Staffan
On 19 aug 2013, at 11:08, Staffan Larsen wrote:
> We are using the mach thread port name as the os thread identifier on OS X.
> We get this value by calling mach_thread_self(), but we (I) didn't realize
> that this "port" resource is refere
On 08/21/2013 10:27 AM, shanliang wrote:
> Jaroslav Bachorik wrote:
>> On 08/21/2013 12:00 AM, Daniel Fuchs wrote:
>>
>>> On 8/20/13 11:12 PM, shanliang wrote:
>>>
Thanks Daniel and Erik for the comments, here is new version:
http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/
>>>
Jaroslav Bachorik wrote:
On 08/21/2013 12:00 AM, Daniel Fuchs wrote:
On 8/20/13 11:12 PM, shanliang wrote:
Thanks Daniel and Erik for the comments, here is new version:
http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/
This new version looks reasonable. I guess you could dis
On 08/21/2013 12:00 AM, Daniel Fuchs wrote:
> On 8/20/13 11:12 PM, shanliang wrote:
>> Thanks Daniel and Erik for the comments, here is new version:
>>http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/
>
> This new version looks reasonable. I guess you could dispense of the new
> nullSubjectCo
39 matches
Mail list logo
