VisualVM issue when starting JMX agent with jcmd

2013-08-29 Thread Martin Traverso
I'm running into an issue when connecting to a process from VisualVM. First, let me describe the setup: - A Linux machine running jstatd configured with a "grant all permissions" policy file and a test java program that sleeps forever. The Java version is: java version "1.7.0_10" Java(TM) SE

hg: hsx/hotspot-rt/hotspot: 8021954: VM SIGSEGV during classloading on MacOS; hs_err_pid file produced

2013-08-29 Thread coleen . phillimore
Changeset: 9758d9f36299 Author:coleenp Date: 2013-08-29 18:56 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9758d9f36299 8021954: VM SIGSEGV during classloading on MacOS; hs_err_pid file produced Summary: declare all user-defined operator new()s within Hotspot cod

hg: jdk8/tl/jdk: 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII

2013-08-29 Thread xuelei . fan
Changeset: cdf68747b0fb Author:xuelei Date: 2013-08-29 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf68747b0fb 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Reviewed-by: michaelm ! src/share/classes/java/net/IDN.java + test/j

hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code

2013-08-29 Thread jonathan . gibbons
Changeset: 23f0f3c9c44a Author:jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/

hg: jdk8/tl: 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output.

2013-08-29 Thread mike . duigou
Changeset: 51a61778a99d Author:mduigou Date: 2013-08-29 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/51a61778a99d 8023892: test/Makefile shouldn't try to tell langtools/test/Makefile where to put output. Reviewed-by: erikj, vromero, henryjen ! test/Makefile

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-08-29 Thread dmitry . samersoff
Changeset: d8e99408faad Author:dsamersoff Date: 2013-08-29 21:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d8e99408faad 8009062: poor performance of JNI AttachCurrentThread after fix for 7017193 Summary: don't re-evaluate stack bounds for main thread before in

hg: hsx/hotspot-rt/jdk: 98 new changesets

2013-08-29 Thread john . coomes
Changeset: 2722f4000b65 Author:jgodinez Date: 2013-08-15 11:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2722f4000b65 8023045: [MacOSX] PrinterIOException when printing a JComponent Reviewed-by: bae, jchen ! src/share/classes/sun/print/PSPrinterJob.java Changese

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-29 Thread Yumin Qi
Hi, loise Thanks for your review. I will send out a new webrev soon. For your concern, see embedded answers. arguments.cpp - looks good, no comments I will add another functions, is_filename_valid, and in this functions, check if the given filename is 'legal' function name, currently we di

hg: hsx/hotspot-rt/langtools: 29 new changesets

2013-08-29 Thread john . coomes
Changeset: b8610a65fbf9 Author:vromero Date: 2013-08-08 11:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b8610a65fbf9 8019486: javac, generates erroneous LVT for a test case with lambda code Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/co

hg: hsx/hotspot-rt/nashorn: 23 new changesets

2013-08-29 Thread john . coomes
Changeset: 9a3e3bb30db3 Author:attila Date: 2013-08-07 16:38 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9a3e3bb30db3 8022509: Various Dynalink security enhancements Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/ChainedCallSite.java ! src/jdk/intern

Re: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

2013-08-29 Thread Mandy Chung
On 8/28/13 9:44 AM, Erik Gahlin wrote: Hi, It took sometime, but here is an updated webrev where the shell script has been modified. http://cr.openjdk.java.net/~egahlin/7172176_3/ Looks good. Happy for you to get this pushed as it has been sitting in your repo over a year :) Mandy Ch

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b105 for changeset 88390df7ed2c

2013-08-29 Thread john . coomes
Changeset: 01be6f93d0a4 Author:cl Date: 2013-08-29 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/01be6f93d0a4 Added tag jdk8-b105 for changeset 88390df7ed2c ! .hgtags

hg: hsx/hotspot-rt/jaxp: 5 new changesets

2013-08-29 Thread john . coomes
Changeset: 4e23bc205d9d Author:joehw Date: 2013-08-09 12:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/4e23bc205d9d 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguratio

hg: hsx/hotspot-rt/corba: Added tag jdk8-b105 for changeset 4e38de7c767e

2013-08-29 Thread john . coomes
Changeset: 2e3a056c84a7 Author:cl Date: 2013-08-29 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2e3a056c84a7 Added tag jdk8-b105 for changeset 4e38de7c767e ! .hgtags

hg: hsx/hotspot-rt: 6 new changesets

2013-08-29 Thread john . coomes
Changeset: 00dcfaa6bc01 Author:aefimov Date: 2013-08-16 18:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/00dcfaa6bc01 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks ! common/autoconf/generated-con

hg: hsx/hotspot-rt/hotspot: 8022407: sun/misc/CopyMemory.java fails with SIGSEGV in Unsafe_SetByte+0x35

2013-08-29 Thread harold . seigel
Changeset: dfc126b2f659 Author:hseigel Date: 2013-08-29 13:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dfc126b2f659 8022407: sun/misc/CopyMemory.java fails with SIGSEGV in Unsafe_SetByte+0x35 Summary: lower optimization level for unsafe.cpp due to MacOS Xcode

hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse

2013-08-29 Thread jonathan . gibbons
Changeset: 96b6865eda94 Author:jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-29 Thread Lois Foltan
Hi Yumin, I do have some follow on review comments: arguments.cpp - looks good, no comments ostream.hpp - looks good, no comments ostream.cpp - - Have you tried a file name that is 255 characters? It would seem that after you appended the pid + timestamp + .current + # you could overru

hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc

2013-08-29 Thread jonathan . gibbons
Changeset: 9c0e192c0926 Author:jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java

hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only

2013-08-29 Thread jonathan . gibbons
Changeset: b0b25c1f6cbd Author:jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy ! test/tools/javac/tree/TypeA

hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate

2013-08-29 Thread jonathan . gibbons
Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/

hg: jdk8/tl/jdk: 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links

2013-08-29 Thread dan . xu
Changeset: 5bf4f285 Author:dxu Date: 2013-08-29 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf4f285 4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links Summary: Exclude the possible usage of linked files or directories in the test Rev

hg: hsx/hotspot-rt/hotspot: 8016764: JVM does not prohibit invokespecial in c.f.v 51.0 that invokes default interface method in c.f.v 52.0

2013-08-29 Thread harold . seigel
Changeset: 76482cbba706 Author:hseigel Date: 2013-08-29 10:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/76482cbba706 8016764: JVM does not prohibit invokespecial in c.f.v 51.0 that invokes default interface method in c.f.v 52.0 Summary: Check cfv before allow

Re: Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-08-29 Thread Daniel Fuchs
On 8/29/13 4:11 PM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/jdk-8023669/01/ Indeed, calling Objects.hash(Object ...) is a good idea, which simplifies the code. I used also Arrays.hashCode() to simplify the code, now the fix likes really simple. I have

Re: Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-08-29 Thread shanliang
Here is the new version: http://cr.openjdk.java.net/~sjiang/jdk-8023669/01/ Indeed, calling Objects.hash(Object ...) is a good idea, which simplifies the code. I used also Arrays.hashCode() to simplify the code, now the fix likes really simple. I have passed JCK tests, unit tests of man

hg: hsx/hotspot-rt/hotspot: 8023720: (hotspot) setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread staffan . larsen
Changeset: cc56f122f3f7 Author:sla Date: 2013-08-29 11:05 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cc56f122f3f7 8023720: (hotspot) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes, rbackman ! src/os/posix/vm/os_posix.cpp

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

2013-08-29 Thread shanliang
Thanks David. Shanliang David Holmes wrote: Hi Shanliang, After our off-list discussion I've had a closer look at this and it looks okay to me too. Reviewed. Thanks, David On 26/08/2013 6:35 PM, shanliang wrote: Hi, Still need OK from a reviewer. Thanks Erik, Jaroslav and Daniel for the

Re: Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

2013-08-29 Thread David Holmes
Hi Shanliang, After our off-list discussion I've had a closer look at this and it looks okay to me too. Reviewed. Thanks, David On 26/08/2013 6:35 PM, shanliang wrote: Hi, Still need OK from a reviewer. Thanks Erik, Jaroslav and Daniel for the code review. Thanks, Shanliang Daniel Fuchs

Re: RFR 8019375: Internal symbol table size should be tunable.

2013-08-29 Thread Kevin Walls
On 23/08/13 19:54, Coleen Phillimore wrote: Hi Kevin, I'm sorry I didn't warn you but I think there are serviceability agent changes with this change. For some reason, I think the SA duplicates code in the JVM for the symbol table. You might get away with only changing this line in agent

hg: jdk8/tl/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread staffan . larsen
Changeset: 779ff9f3b2e3 Author:sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/779ff9f3b2e3 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_code.c

Re: Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-08-29 Thread Daniel Fuchs
On 8/29/13 9:34 AM, shanliang wrote: Hi, Please review following fix, it addresses the issue only in the method "hashCode": bug: https://bugs.openjdk.java.net/browse/JDK-8023669 webrev: http://cr.openjdk.java.net/~sjiang/jdk-8023669/00/ Thanks, Shanliang Hi Shanliang,

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread Rickard Bäckman
Looks good! /R On Aug 29, 2013, at 10:26 AM, Staffan Larsen wrote: > Can I have a second review for the Hotspot part of this change? > > Thanks, > /Staffan > > On 27 aug 2013, at 10:48, Staffan Larsen wrote: > >> I have also made a fix for hotspot. I messed up the link in the last email >>

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-29 Thread Staffan Larsen
Can I have a second review for the Hotspot part of this change? Thanks, /Staffan On 27 aug 2013, at 10:48, Staffan Larsen wrote: > I have also made a fix for hotspot. I messed up the link in the last email so > here are both webrevs. > > jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/

Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-08-29 Thread shanliang
Hi, Please review following fix, it addresses the issue only in the method "hashCode": bug: https://bugs.openjdk.java.net/browse/JDK-8023669 webrev: http://cr.openjdk.java.net/~sjiang/jdk-8023669/00/ Thanks, Shanliang