Looks good! /R
On Aug 29, 2013, at 10:26 AM, Staffan Larsen wrote: > Can I have a second review for the Hotspot part of this change? > > Thanks, > /Staffan > > On 27 aug 2013, at 10:48, Staffan Larsen <staffan.lar...@oracle.com> wrote: > >> I have also made a fix for hotspot. I messed up the link in the last email >> so here are both webrevs. >> >> jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ >> hotspot: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ >> >> Thanks, >> /Staffan >> >> On 27 aug 2013, at 10:41, Staffan Larsen <staffan.lar...@oracle.com> wrote: >> >>> The original conversation about this problem is here: >>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-August/011318.html >>> >>> >>> In short, setjmp/longjmp on OS X messes up the signal mask and we should >>> use _setjmp/_longjmp instead. >>> >>> This change fixes two occurences in the jdk. There are a couple more in the >>> client and hotspot areas which I will file followup bugs about. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ >>> >>> Thanks, >>> /Staffan >> >
