Changeset: 184c0d6698c3
Author:bpatel
Date: 2013-09-24 16:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/184c0d6698c3
8016328: Regression : Javadoc i18n regression caused by fix for 8012375
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/mark
Ivan,
I'm not sure this test adds anything to the current testing. As far as I
understand, the test checks if jdb is in a location that contains space and
then tries to start it. If the path does not contain space it does nothing. We
already have many tests that launch jdb, regardless of space
Looks good.
Thanks,
Serguei
On 9/24/13 12:20 PM, Dmitry Samersoff wrote:
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24 11:57, Dmitry Samersoff wrote:
Please review
Looks good!
Thanks,
/Staffan
On 24 sep 2013, at 12:20, Dmitry Samersoff wrote:
> Staffan and Yumin,
>
> Thank you for feedback.
>
> Fixed (in place, please press shift-reload)
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
>
> -Dmitry
>
> On 2013-09-24 11:57, Dmitry Sam
Changeset: 3ae62331a56f
Author:jjg
Date: 2013-09-24 13:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f
8002154: [doclint] doclint should check for issues which are errors in javadoc
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/Checker.ja
Dmitry,
Thank you for taking this action.
I did not know, the extra machine setup is needed though. :(
Thanks,
Serguei
On 9/24/13 12:38 PM, Dmitry Samersoff wrote:
Serguei,
Agree! Try to test it better tomorrow. Have to find MacOS X machine to
install UTE first.
-Dmitry
On 2013-09-24 23:3
Serguei,
Agree! Try to test it better tomorrow. Have to find MacOS X machine to
install UTE first.
-Dmitry
On 2013-09-24 23:34, serguei.spit...@oracle.com wrote:
> On 9/24/13 12:01 PM, Dmitry Samersoff wrote:
>> Sergey,
>>
>> I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
>
> I
On 9/24/13 12:01 PM, Dmitry Samersoff wrote:
Sergey,
I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
It should not be too hard to run the same subset of tests on Mac OS, right?
So if you think I should run extra tests, let me know which one, I'll
run it.
Actually the fix
Looks good.
On 9/24/2013 12:20 PM, Dmitry Samersoff wrote:
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24 11:57, Dmitry Samersoff wrote:
Please review changes:
http:
Staffan and Yumin,
Thank you for feedback.
Fixed (in place, please press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
-Dmitry
On 2013-09-24 11:57, Dmitry Samersoff wrote:
> Please review changes:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
Sergey,
I'm rely on JPRT in testing. Also I run some tests on FreeBSD.
So if you think I should run extra tests, let me know which one, I'll
run it.
Actually the fix doesn't change MacOS X implementation - just move a
call to ::pthread_mach_thread_np to different place so I don't expect
any pr
This fix looks Okay.
Thanks,
Serguei
On 9/24/13 3:11 AM, Dmitry Samersoff wrote:
Hi everyone please review the changes
http://cr.openjdk.java.net/~dsamersoff/JDK-8025283/webrev.01/
Minor issues in os_bsd.cpp cause compilation errors of openjdk hotspot
on BSD platforms other than Apple.
-Dmit
This looks good module Staffan comment on guarantee.
How do you test it?
Also, should it be tested on Mac OS as well?
Thanks,
Serguei
On 9/24/13 12:57 AM, Dmitry Samersoff wrote:
Please review changes:
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
Story:
Tracing framework e
Changeset: 6a05a713450d
Author:jjg
Date: 2013-09-24 11:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d
8025272: doclint needs to check for valid usage of @value tag
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/Checker.java
! src/share/cl
Changeset: 503338f16d2b
Author:jjg
Date: 2013-09-24 10:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b
8025246: [doclint] doclint is showing error on anchor already defined when it's
not
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/Chec
Changeset: 96dcb66e6b0a
Author:jjg
Date: 2013-09-24 10:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a
8025050: Doclint doesn't recognize tag
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/HtmlTag.java
! test/tools/doclint/html/InlineTags
Hello all!
Would you please help review a new regression test?
This is related to the fix for 8014676 (jdb could not run under Windows,
if its path contained a space).
The test simply checks, if the path to the tested jdk contains a space
and exits, if it does not.
Otherwise it tries to run t
Dmitry,
Looks good. Minor comments:
os_bsd.cpp:
+ #elif __APPLE__ //XNU kernel
+ // despite the fact mach port is actually not a thread id use it
+ // instead of syscall(SYS_thread_selfid) as it certenly fit to u4
Is it a typo for 'certainly' here?
certenly => certainly
fit => fits
Tha
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
! src/share/classes/sun/tools
Looks good!
Thanks,
/Staffan
On 24 sep 2013, at 03:11, Dmitry Samersoff wrote:
> Hi everyone please review the changes
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8025283/webrev.01/
>
> Minor issues in os_bsd.cpp cause compilation errors of openjdk hotspot
> on BSD platforms other than App
Looks good.
The only thing that is missing is the guarantee() that was present in the OS X
code before:
guarantee(thread_id != 0, "just checking");
Could you add it back?
Thanks,
/Staffan
On 24 sep 2013, at 00:57, Dmitry Samersoff wrote:
> Please review changes:
>
> http://cr.openjdk.j
Looks good.
Thanks
Markus
-Original Message-
From: Staffan Larsen
Sent: den 24 september 2013 00:43
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: [7u] RFR(S): 8024027 Test sun/misc/IoTrace/IoTraceSocketReadWrite.java
crashes VM
This test uses byte
Daniel Fuchs wrote:
On 9/23/13 8:27 PM, shanliang wrote:
Hi,
Please review this test fix, if the test continues failing, then we need
to investigate the Monitor implementation.
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8025207
Tha
Hi everyone please review the changes
http://cr.openjdk.java.net/~dsamersoff/JDK-8025283/webrev.01/
Minor issues in os_bsd.cpp cause compilation errors of openjdk hotspot
on BSD platforms other than Apple.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I w
On 9/23/13 8:27 PM, shanliang wrote:
Hi,
Please review this test fix, if the test continues failing, then we need
to investigate the Monitor implementation.
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8025207
Thanks,
Shanliang
Hi
Please review changes:
http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
Story:
Tracing framework expect u4 as an id of thread
pthread_t chosen as a tread id for variety of BSD platforms couldn't be
converted to u4 so it cause compilation failure on BSD x64
Solution:
Change thread
26 matches
Mail list logo
