Changeset: e8097e1e18a7
Author:sjiang
Date: 2013-10-10 08:49 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8097e1e18a7
8025206: Intermittent test failure:
javax/management/monitor/NullAttributeValueTest.java
Reviewed-by: dholmes, dfuchs, jbachorik
! test/javax/managem
Changeset: b4a4fdc1f464
Author:coleenp
Date: 2013-10-09 21:45 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b4a4fdc1f464
8025185: MethodHandleInError and MethodTypeInError not handled in
ConstantPool::compare_entry_to and copy_entry_to
Summary: Add missing cases.
Coleen,
I would suggest adding these sanity checks:
1063 } break;
1064
case JVM_CONSTANT_UnresolvedClassInError:
case JVM_CONSTANT_MethodHandleInError:
case JVM_CONSTANT_MethodTypeInError:
assert(0, "should have been eliminated by normalize_error_tag");
// fal
On 9/10/2013 9:31 PM, Jaroslav Bachorik wrote:
On 9.10.2013 12:23, David Holmes wrote:
Jaroslav,
Thanks for the details description of changes - much appreciated.
There is a lot to digest in there. :)
Yep, it started as a simple fix :/
It isn't obvious to me why these tests require a full
On 9/10/2013 9:26 PM, Jaroslav Bachorik wrote:
On 8.10.2013 23:46, David Holmes wrote:
On 8/10/2013 10:36 PM, Jaroslav Bachorik wrote:
On 8.10.2013 09:34, David Holmes wrote:
Jaroslav,
On 2/10/2013 6:47 PM, Jaroslav Bachorik wrote:
Hello,
currently the JVM uptime reported by the RuntimeMXBe
On 9/10/2013 6:19 PM, Aleksey Shipilev wrote:
Hi Mandy,
On 10/09/2013 11:46 AM, Mandy Chung wrote:
Like David said, -client/-server and -d32/-d64 are launcher option but
not VM options. RuntimeMXBean.getInputArguments() returns the arguments
passed to the VM which is created via the JNI_Create
Looks good.
Suggestion: Make normalize_error_tag be static, for namespace cleanliness.
Even better, move it into constantTag, as (say) constantTag::non_error_value().
— John
On Oct 9, 2013, at 7:04 PM, Coleen Phillimore
wrote:
>
> Thanks Dan!
> Coleen
>
> On 10/9/2013 6:39 PM, Daniel D.
On 9/10/2013 3:04 AM, Staffan Larsen wrote:
Thanks Serguei!
Still need an official Reviewer.
Reviewed!
Thanks for explaining the diff to the regex :) Hard to spot.
David
-
Thanks,
/Staffan
On 8 okt 2013, at 17:24, serguei.spit...@oracle.com wrote:
Looks good.
Thanks,
Serguei
On 10
On 10/10/2013 4:12 AM, Staffan Larsen wrote:
On 9 okt 2013, at 16:19, Jaroslav Bachorik wrote:
On 9.10.2013 16:10, Staffan Larsen wrote:
There is now an awful amount of different timestamps in the Management class.
Can they be consolidated somehow? At least _begin_vm_creation_time and the n
I missed the earlier println.
Reviewed.
Thanks,
David
On 9/10/2013 5:42 PM, shanliang wrote:
David Holmes wrote:
shanliang wrote:
Daniel Fuchs wrote:
On 9/23/13 8:27 PM, shanliang wrote:
Hi,
Please review this test fix, if the test continues failing, then we
need
to investigate the Monito
Thanks Dan!
Coleen
On 10/9/2013 6:39 PM, Daniel D. Daugherty wrote:
On 10/8/13 12:27 PM, Coleen Phillimore wrote:
Summary: Add missing cases.
I verified this with the test for
https://bugs.openjdk.java.net/browse/JDK-8022701 but don't want to
copy the test into with modifications the hotspo
Changeset: c13309f658e1
Author:darcy
Date: 2013-10-09 18:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1
8024354: Explicitly permit DoubleStream.sum()/average() implementations to use
higher precision summation
Reviewed-by: mduigou, briangoetz
! src/share/cla
Changeset: eab3c09745b6
Author:bchristi
Date: 2013-10-09 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab3c09745b6
8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position
Summary: Override remove() method in DescendingKeyIterator
Reviewed-by: alanb,
Changeset: 673f8045311e
Author:bpb
Date: 2013-10-09 17:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/673f8045311e
7189139: BigInteger's staticRandom field can be a source of bottlenecks.
Summary: Use ThreadLocalRandom instead of SecureRandom.
Reviewed-by: shade, psandoz
C
Changeset: d25557d03ec0
Author:acorn
Date: 2013-10-09 17:57 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d25557d03ec0
8026185: nsk/jvmit/GetMethodDeclaringClass/declcls001 failed
Summary: Missed initialization. Thanks Coleen.
Reviewed-by: coleenp, minqi
! src/sh
On 10/8/13 12:27 PM, Coleen Phillimore wrote:
Summary: Add missing cases.
I verified this with the test for
https://bugs.openjdk.java.net/browse/JDK-8022701 but don't want to
copy the test into with modifications the hotspot repository, still
working on refactoring the test for the JDK reposi
I think in SA, the command 'vmstructsdump' will trigger your code?
Thanks
Yumin
On 10/9/2013 1:59 PM, Dmitry Samersoff wrote:
Staffan,
I don't have specific test, but I rebuild vm testbase with -parameters
and then run nsk.sajdi.
-Dmitry
On 2013-10-09 22:04, Staffan Larsen wrote:
Dmitry,
Staffan,
I don't have specific test, but I rebuild vm testbase with -parameters
and then run nsk.sajdi.
-Dmitry
On 2013-10-09 22:04, Staffan Larsen wrote:
> Dmitry,
>
> Are there any tests that exercise this functionality?
>
> /Staffan
>
> On 9 okt 2013, at 17:35, Dmitry Samersoff wrote:
>
Changeset: 1597066b58ee
Author:valeriep
Date: 2013-10-08 11:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1597066b58ee
7196382: PKCS11 provider should support 2048-bit DH
Summary: Query and enforce range checking using the values from native PKCS11
library.
Reviewed-by:
I can absolutely see where Aleksey (and 99% of the Java users) is coming from.
From a user perspective there is no difference between the launcher arguments
and the JVM arguments. Unfortunately the implementation does make a difference
between them and it's not easy to hide this difference.
A s
Changeset: b86e6700266e
Author:bpb
Date: 2013-10-09 11:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b86e6700266e
8016252: More defensive HashSet.readObject
Summary: Add data validation checks in readObject().
Reviewed-by: alanb, mduigou, chegar
Contributed-by: Brian Burk
Changeset: d42fe440bda8
Author:rriggs
Date: 2013-10-09 13:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d42fe440bda8
8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter
Summary: Add appendValueReduced method based on a ChronoLocalDate to provide
co
On 9 okt 2013, at 16:19, Jaroslav Bachorik wrote:
> On 9.10.2013 16:10, Staffan Larsen wrote:
>> There is now an awful amount of different timestamps in the Management
>> class. Can they be consolidated somehow? At least _begin_vm_creation_time
>> and the new _begin_vm_creation_ns.
>>
>> This
Dmitry,
Are there any tests that exercise this functionality?
/Staffan
On 9 okt 2013, at 17:35, Dmitry Samersoff wrote:
> Hi Everybody,
>
> Please, review the changes for:
>
> JDK-8005810: Update Hotspot Serviceability Agent for Method Parameter
> Reflection and Generic Type Signature Data
On 9 okt 2013, at 18:06, Daniel D. Daugherty
wrote:
>
> On 10/9/13 9:03 AM, Daniel D. Daugherty wrote:
>> Replies also inline...
>>
>>
>> On 10/9/13 6:02 AM, David Holmes wrote:
>>> inline ...
>>>
>>> On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wro
Changeset: c070001c4f60
Author:henryjen
Date: 2013-10-09 09:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c070001c4f60
8023524: Mechanism to dump generated lambda classes / log lambda code generation
Reviewed-by: plevart, mchung, forax, jjb
Contributed-by: brian.go...@ora
Hi,
On 9.10.2013 17:56, Peter Allwin wrote:
Hi Jaroslav,
The "ERROR:" prefix is hard-coded in error_messages.c and is not subject to
localisation etc. so I think performing a case-sensitive compare seems reasonable -
although if you feel strongly about it I can definitely change it.
In that
On 10/9/13 9:03 AM, Daniel D. Daugherty wrote:
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- make/bsd/makefiles/universal.gmk
I did not understand the additional logic
Hi Jaroslav,
The "ERROR:" prefix is hard-coded in error_messages.c and is not subject to
localisation etc. so I think performing a case-sensitive compare seems
reasonable - although if you feel strongly about it I can definitely change it.
Thanks for the review!
/peter
On Oct 4, 2013, at 1:41
Hi Everybody,
Please, review the changes for:
JDK-8005810: Update Hotspot Serviceability Agent for Method Parameter
Reflection and Generic Type Signature Data
The fix contributed by Eric McCorkle.
http://cr.openjdk.java.net/~dsamersoff/JDK-8005810/webrev.01/
https://bugs.openjdk.java.net/brows
Changeset: e3b70e601c1c
Author:rriggs
Date: 2013-10-09 11:02 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3b70e601c1c
8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed
Summary: The test should be using the Locale.Category.FORMAT to verify the test
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- hotspot/make/Makefile
+ $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
EXPORT_CLIENT_DIR should be EXPORT_MINIMAL_
On 9.10.2013 16:10, Staffan Larsen wrote:
There is now an awful amount of different timestamps in the Management class.
Can they be consolidated somehow? At least _begin_vm_creation_time and the new
_begin_vm_creation_ns.
This discussion also implies that the "elapsed time" we print in the hs_
There is now an awful amount of different timestamps in the Management class.
Can they be consolidated somehow? At least _begin_vm_creation_time and the new
_begin_vm_creation_ns.
This discussion also implies that the "elapsed time" we print in the hs_err
file is also wrong. It uses os::elapsed
Changeset: cf6e39cfdf50
Author:mchung
Date: 2013-10-09 06:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf6e39cfdf50
8026027: Level.parse should return the custom Level instance instead of the
mirrored Level
Reviewed-by: dfuchs, chegar
! src/share/classes/java/util/logg
Changeset: 1cd20806fd5c
Author:psandoz
Date: 2013-10-09 15:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c
8020061: Clarify reporting characteristics between splits
Reviewed-by: alanb, chegar
! src/share/classes/java/util/Spliterator.java
Changeset: 8d29733ad609
Author:sundar
Date: 2013-10-09 10:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609
8026112: Function("with(x ? 1e81 : (x2.constructor = 0.1)){}") throws
AssertionError: double is not compatible with object
Reviewed-by: lagergren, han
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- hotspot/make/Makefile
+ $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
EXPORT_CLIENT_DIR should be EXPORT_MINIMAL_DIR.
For fun you can try building minimal on OSX, but I don't kno
On 9.10.2013 12:23, David Holmes wrote:
Jaroslav,
Thanks for the details description of changes - much appreciated.
There is a lot to digest in there. :)
Yep, it started as a simple fix :/
It isn't obvious to me why these tests require a full JDK?
IDK, LocalManagementTest.sh was listed a
On 8.10.2013 23:46, David Holmes wrote:
On 8/10/2013 10:36 PM, Jaroslav Bachorik wrote:
On 8.10.2013 09:34, David Holmes wrote:
Jaroslav,
On 2/10/2013 6:47 PM, Jaroslav Bachorik wrote:
Hello,
currently the JVM uptime reported by the RuntimeMXBean is based on
System.currentTimeMillis() which
Changeset: 0be3f1820e8b
Author:jlahoda
Date: 2013-10-09 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0be3f1820e8b
8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Summary: Should not generate non-public $assertionsDisabled field into
Changeset: 91a752e3d50b
Author:vinnie
Date: 2013-10-09 10:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91a752e3d50b
8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class
Reviewed-by: mullan, weijun
+ src/share/classes/java/security/DomainLoadStorePar
Jaroslav,
Thanks for the details description of changes - much appreciated.
There is a lot to digest in there. :)
It isn't obvious to me why these tests require a full JDK?
I don't quite follow the libjvm lookup logic - I would expect that you
would always want to test the libjvm that is curr
David Holmes wrote:
Shanliang writes:
Daniel Fuchs wrote:
Hi Shanliang,
Shouldn't 'messageReceived' be at least declared as volatile?
It looks as if this test is a multi-thread test which
is not MT-safe.
OK I am convinced:
http://cr.openjdk.java.net/~sjiang/JDK-8025206/02/
The volatile
On 10/09/2013 01:03 PM, Mandy Chung wrote:
>> Do you see any better option?
>
> I no longer work in this area and don't have any suggestion at the
> moment. Although parsing of VM name is not ideal, I suggest it as a
> workaround for now and give the serviceability team time to look into
> this
On 10/9/2013 1:19 AM, Aleksey Shipilev wrote:
Hi Mandy,
On 10/09/2013 11:46 AM, Mandy Chung wrote:
Like David said, -client/-server and -d32/-d64 are launcher option but
not VM options. RuntimeMXBean.getInputArguments() returns the arguments
passed to the VM which is created via the JNI_Create
Changeset: 2ea162b2ff55
Author:alanb
Date: 2013-10-09 09:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55
8008662: Add @jdk.Exported to JDK-specific/exported APIs
Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy
! src/share/classes/com/sun/jdi/AbsentI
Hi Mandy,
On 10/09/2013 11:46 AM, Mandy Chung wrote:
> Like David said, -client/-server and -d32/-d64 are launcher option but
> not VM options. RuntimeMXBean.getInputArguments() returns the arguments
> passed to the VM which is created via the JNI_CreateJavaVM API.
Hm, this is the first time I
David Holmes wrote:
! // no deadline here, let's wait till either the
connId is removed
! // or the test timeout (jprt kills the test)!
! // see 8025204
The comment loses context if you don't know what the code previously
did. I suggest using the
Hi Aleksey,
Like David said, -client/-server and -d32/-d64 are launcher option but
not VM options. RuntimeMXBean.getInputArguments() returns the arguments
passed to the VM which is created via the JNI_CreateJavaVM API.
-client/-server is the java launcher option that determines which VM to
David Holmes wrote:
shanliang wrote:
Daniel Fuchs wrote:
On 9/23/13 8:27 PM, shanliang wrote:
Hi,
Please review this test fix, if the test continues failing, then we
need
to investigate the Monitor implementation.
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
bug: https://bugs
Changeset: ea000904db62
Author:alundblad
Date: 2013-10-08 15:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea000904db62
8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Summary: Fixed precedence and associativity issues with pretty printing of
Looks good to me, but I'd like Thomas' opinion as well.
Thanks,
/Staffan
On 9 okt 2013, at 00:14, aleksey.timof...@oracle.com wrote:
> Hello.
>
> I prepared a little fix to JDK-8025925. Find webrev here please:
> http://cr.openjdk.java.net/~iignatyev/atimofeev/8025925/webrev.00/index.html
> (
53 matches
Mail list logo
