hg: jdk8/tl/jdk: 96 new changesets

Changeset: 529cd4de1823 Author:prr Date: 2013-09-26 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/529cd4de1823 7092764: java.awt.font.TransformAttribute.equals(null) throws NPE Reviewed-by: jgodinez, jchen ! src/share/classes/java/awt/font/TransformAttribute.java + te

Re: RR(S): JDK-8004213 jdp packet need pid, broadcast interval and rmi server hostname fields.

Dmitry, This looks good, just two small nits: test/sun/management/jdp/JdpClient.java: 56: "Packet error fileld " -> "Packet error: field " test/sun/management/jdp/JdpClient.java: 68-74: missing space after the comma Thanks, /Staffan On 10 okt 2013, at 20:33, Dmitry Samersoff wrote: > Hi Ev

hg: jdk8/tl/langtools: 8012557: Implement lambda methods on interfaces as private; ...

Changeset: 1ce8405af5fe Author:rfield Date: 2013-10-10 23:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ce8405af5fe 8012557: Implement lambda methods on interfaces as private 8016320: Method reference in subinterface of type I.super::foo produces exception at runt

hg: jdk8/tl/hotspot: 82 new changesets

Changeset: 8a6a85321d3a Author:amurillo Date: 2013-09-20 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a6a85321d3a 8025127: new hotspot build - hs25-b52 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 63147986a428 Author:dcubed Date: 2013-09-18 0

hg: jdk8/tl/langtools: 5 new changesets

Changeset: 41541097533a Author:lana Date: 2013-09-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41541097533a Merge Changeset: af6244ba81b6 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af624

hg: jdk8/tl/jaxws: 4 new changesets

Changeset: 32edc7a2c866 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/32edc7a2c866 Added tag jdk8-b110 for changeset cc682329886b ! .hgtags Changeset: da77e343f458 Author:lana Date: 2013-10-10 10:03 -0700 URL: http://

hg: jdk8/tl: 12 new changesets

Changeset: 5ec3c4948863 Author:ksrini Date: 2013-09-27 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5ec3c4948863 8023495: [infra] create 64-bit solaris bits with symlinks Reviewed-by: ihse, tbell, erikj ! common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk Changeset:

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: d49a8c2173f5 Author:lana Date: 2013-09-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d49a8c2173f5 Merge Changeset: 75fd3486e584 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/75fd3486e

hg: jdk8/tl/jaxp: 5 new changesets

Changeset: 17ee0d3e97fd Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/17ee0d3e97fd Added tag jdk8-b110 for changeset 4c84c5b447b0 ! .hgtags Changeset: 2107c9baa457 Author:lana Date: 2013-10-10 10:03 -0700 URL: http://h

hg: jdk8/tl/corba: 2 new changesets

Changeset: 85c1c94e7235 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/85c1c94e7235 Added tag jdk8-b110 for changeset 3d2b7ce93c5c ! .hgtags Changeset: d7e478820c56 Author:cl Date: 2013-10-10 10:08 -0700 URL: http://hg

hg: jdk8/tl/jaxp: 8003262: reverse translation required changes in xalan resource bundles

Changeset: b76629725522 Author:joehw Date: 2013-10-10 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b76629725522 8003262: reverse translation required changes in xalan resource bundles Reviewed-by: lancea, dfuchs ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorR

hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java

Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/

hg: jdk8/tl/langtools: 8008762: Type annotation on inner class in anonymous class show up as regular type annotations; ...

Changeset: b1b4a6dcc282 Author:emc Date: 2013-10-10 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1b4a6dcc282 8008762: Type annotation on inner class in anonymous class show up as regular type annotations 8015257: type annotation with TYPE_USE and FIELD attribu

hg: jdk8/tl/jdk: 8026011: java.lang.reflect.MalformedParametersException introduces doclint warnings

Changeset: 4abfcbac1cb6 Author:emc Date: 2013-10-10 18:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4abfcbac1cb6 8026011: java.lang.reflect.MalformedParametersException introduces doclint warnings Summary: Add javadoc comments to members of MalformedParametersException

RR(S): JDK-8004213 jdp packet need pid, broadcast interval and rmi server hostname fields.

Hi Everyone, This fix covers JDK JDK-8004213 JDP packets should contain PID JDK-8004215 JDP packets should contain the configured broadcast interval JDK-8007071 JDP does not work well with java.rmi.server.hostname overrides. and add three extra fields to JDP packet: PID, rmi server name, broadca

hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b111 for changeset 75fd3486e584

Changeset: fc2b6885e60e Author:cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fc2b6885e60e Added tag jdk8-b111 for changeset 75fd3486e584 ! .hgtags

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b111 for changeset af6244ba81b6

Changeset: a0e8fd2464d6 Author:cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a0e8fd2464d6 Added tag jdk8-b111 for changeset af6244ba81b6 ! .hgtags

hg: hsx/hotspot-rt/jdk: 4 new changesets

Changeset: 88597d465e48 Author:ihse Date: 2013-10-01 15:13 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88597d465e48 8016024: Remove solaris path from FillCacheFind Reviewed-by: erikj ! makefiles/Tools.gmk Changeset: 760af86b3f3f Author:erikj Date: 2013-10

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b111 for changeset 32edc7a2c866

Changeset: fc94ce4b899e Author:cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/fc94ce4b899e Added tag jdk8-b111 for changeset 32edc7a2c866 ! .hgtags

hg: hsx/hotspot-rt/corba: Added tag jdk8-b111 for changeset 85c1c94e7235

Changeset: d7e478820c56 Author:cl Date: 2013-10-10 10:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d7e478820c56 Added tag jdk8-b111 for changeset 85c1c94e7235 ! .hgtags

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b111 for changeset 17ee0d3e97fd

Changeset: a4622ff1462b Author:cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a4622ff1462b Added tag jdk8-b111 for changeset 17ee0d3e97fd ! .hgtags

hg: hsx/hotspot-rt: 5 new changesets

Changeset: feb4f2d97042 Author:ihse Date: 2013-10-03 11:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/feb4f2d97042 8008944: Correct typos Reviewed-by: tbell, erikj ! NewMakefile.gmk ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/mak

hg: jdk8/tl/langtools: 8019461: Clean up javac diagnostics; ...

Changeset: 6dcf94e32a3a Author:emc Date: 2013-10-10 13:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6dcf94e32a3a 8019461: Clean up javac diagnostics 7196553: Review error messages for repeating annotations Summary: Changes to the diagnostic messages to improve clar

hg: jdk8/tl/langtools: 8025633: Fix javadoc to generate valid anchor names

Changeset: 933ba3f81a87 Author:bpatel Date: 2013-10-10 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/933ba3f81a87 8025633: Fix javadoc to generate valid anchor names Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMembe

hg: jdk8/tl/jdk: 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays

Changeset: f25d9d8811ca Author:jfranck Date: 2013-10-10 18:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f25d9d8811ca 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays Reviewed-by: darcy, psandoz ! src/share/classe

hg: jdk8/tl/jdk: 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java

Changeset: cab80088c671 Author:sjiang Date: 2013-10-10 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cab80088c671 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java Reviewed-by: dholmes, jbachorik ! test/javax/manage

Re: RFR (XXS) 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed

Looks good. -JB- On 10.10.2013 16:58, Fredrik Arvidsson wrote: Hi Jira: https://bugs.openjdk.java.net/browse/JDK-8026199 Webrev : http://cr.openjdk.java.net/~allwin/farvidss/8026199/webrev.00/ About this fix: This fixes a comp

Re: RFR (XXS) 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed

Looks good to me. Thanks, /Staffan - Original Message - From: fredrik.arvids...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Thursday, October 10, 2013 4:58:58 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: RFR (XXS) 8026199: serviceability/sa/j

RFR (XXS) 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed

Hi Jira: https://bugs.openjdk.java.net/browse/JDK-8026199 Webrev : http://cr.openjdk.java.net/~allwin/farvidss/8026199/webrev.00/ About this fix: This fixes a compilation error in a JTReg test. This issue was a result of some

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Hi, Yes the removal of System.exit didn't take the error value into account. 8010278 removed the System.exit so these Tool classes were usable by other tools. I suppose we can use it in main() as if we're there we should be running as a standalone app. The execute method seems like a nice

Re: RFR 8025185: MethodHandleInError and MethodTypeInError not handled in ConstantPool::,compare_entry_to and copy_entry_to

Thanks John, I didn't realize that I forgot static keyword on the normalize function and I like the suggestion to move it to constantTag even better. Unfortunately, I've already checked it in. I'll make this cleanup with my next (related) bug fix. Thanks, Coleen On 10/10/2013 12:15 AM, J

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Thanks for confirmation. Dan On 10/10/13 3:09 AM, David Holmes wrote: I'm fine with not adding untestable minimal VM support. Thanks, David On 10/10/2013 1:03 AM, Daniel D. Daugherty wrote: Replies also inline... On 10/9/13 6:02 AM, David Holmes wrote: inline ... On 9/10/2013 8:59 AM, D

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Yes, you are right. Still, a default value of 1 would make the code more obvious. Reviewed. /Staffan On 10 okt 2013, at 14:57, Fredrik Arvidsson wrote: > Thanks for reviewing. > > Regarding default value of returnstatus. If start() throws an unhandled > exception, would not the Java runtim

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Thanks for reviewing. Regarding default value of returnstatus. If start() throws an unhandled exception, would not the Java runtime return 1 for us? The try {} clause does not catch anything, it just calls stop() on finally. /F On 2013-10-10 13:49, Staffan Larsen wrote: Thanks for doing this

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Ooh, how embarrassing. Thanks Staffan for adding the correct link. /F On 2013-10-10 13:38, Staffan Larsen wrote: Clicking on the link in this email takes me to the wrong webrev. The correct URL is in the text: http://cr.openjdk.java.net/~allwin/farvidss/8025638/webrev.00/

RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump - Corrected links

Hi again... Please forgive me for messing up the links in the previous mail. This should be ok I hope. Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8024425 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.00/

hg: jdk8/tl/langtools: 8021237: clean up JavacAnnotatedConstruct

Changeset: 1e7ad879f15e Author:alundblad Date: 2013-10-10 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e7ad879f15e 8021237: clean up JavacAnnotatedConstruct Summary: Refactored the static helper methods in JavacAnnoConstructs into ordinary methods and put them

Re: Codereview request: 8025204 Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java

Ship it! Thanks, David On 9/10/2013 5:56 PM, shanliang wrote: David Holmes wrote: ! // no deadline here, let's wait till either the connId is removed ! // or the test timeout (jprt kills the test)! ! // see 8025204 The comment loses context if y

Re: RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

Fredrik, On 10/10/2013 8:24 PM, Fredrik Arvidsson wrote: Hi Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8024425 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.00/

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 03a68e7ca1d5 Author:lagergren Date: 2013-10-09 17:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03a68e7ca1d5 8026137: Fix Issues with Binary Evaluation Order Reviewed-by: hannesw, jlaskey Contributed-by: marcus.lagerg...@oracle.com, attila.szeg...@oracle.co

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Thanks for doing this! Tool.java:116 - shouldn't the default return value be 1? In case start() throws an exception for some reason. Tool.java: I find the start(String[] args), start(), startInternal() methods confusing in naming and usage. Not directly related to your change of course, just a

hg: jdk8/tl/jdk: 7076487: (sctp) SCTP API classes does not exist in JDK for Mac

Changeset: 8294c49d23b3 Author:michaelm Date: 2013-10-10 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8294c49d23b3 7076487: (sctp) SCTP API classes does not exist in JDK for Mac Reviewed-by: alanb, chegar ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk

Re: RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Clicking on the link in this email takes me to the wrong webrev. The correct URL is in the text: http://cr.openjdk.java.net/~allwin/farvidss/8025638/webrev.00/ /Staffan On 10 okt 2013, at 12:42, Fredrik Arvidsson wrote: > Hi > > Please help me to review the changes below: > > Jira case: ht

Re: RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

instanceKlass.cpp:2318 - should use jio_snprintf() instead of sprintf() I'm also wondering if this method should be re-written to use jio_snprintf() as the method for concatenating the strings? /Staffan On 10 okt 2013, at 12:24, Fredrik Arvidsson wrote: > Hi > > Please help me to review the

Re: jmx-dev RFR 6523160: RuntimeMXBean.getUptime() returns negative values

On 10 okt 2013, at 13:02, Jaroslav Bachorik wrote: > On 10.10.2013 05:44, David Holmes wrote: >> On 10/10/2013 4:12 AM, Staffan Larsen wrote: >>> >>> On 9 okt 2013, at 16:19, Jaroslav Bachorik >>> wrote: >>> On 9.10.2013 16:10, Staffan Larsen wrote: > There is now an awful amount of

Re: jmx-dev RFR 6523160: RuntimeMXBean.getUptime() returns negative values

On 10.10.2013 05:44, David Holmes wrote: On 10/10/2013 4:12 AM, Staffan Larsen wrote: On 9 okt 2013, at 16:19, Jaroslav Bachorik wrote: On 9.10.2013 16:10, Staffan Larsen wrote: There is now an awful amount of different timestamps in the Management class. Can they be consolidated somehow? A

RFR (S) 8025638: jmap returns 0 instead of 1 when it fails.

Hi Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8025638 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8025638/webrev.00/

RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

Hi Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8024425 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.00/

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

I'm fine with not adding untestable minimal VM support. Thanks, David On 10/10/2013 1:03 AM, Daniel D. Daugherty wrote: Replies also inline... On 10/9/13 6:02 AM, David Holmes wrote: inline ... On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote: On 10/1/13 8:52 PM, David Holmes wrote: - hots

hg: jdk8/tl/jdk: 8026232: Move libnpt from profile compact1 to compact3

Changeset: 254173b48dcb Author:dholmes Date: 2013-10-10 04:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/254173b48dcb 8026232: Move libnpt from profile compact1 to compact3 Reviewed-by: mchung, alanb ! makefiles/profile-includes.txt

hg: jdk8/tl/jdk: 7011859: java/util/concurrent/Semaphore/RacingReleases.java failing

Changeset: 99b7bbe0474f Author:dl Date: 2013-10-10 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99b7bbe0474f 7011859: java/util/concurrent/Semaphore/RacingReleases.java failing Reviewed-by: alanb, dholmes ! src/share/classes/java/util/concurrent/locks/AbstractQueued

hg: jdk8/tl/jdk: 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java

Changeset: 998560cccefc Author:allwin Date: 2013-10-10 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998560cccefc 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar ! tes

Re: RR(S): JDK-8005810: SA: Update Hotspot Serviceability Agent for Method Parameter Reflection and Generic Type Signature Data

Ok. I would have preferred an explicit test, but this seems to cover it. Reviewed! /Staffan On 9 okt 2013, at 22:59, Dmitry Samersoff wrote: > Staffan, > > I don't have specific test, but I rebuild vm testbase with -parameters > and then run nsk.sajdi. > > -Dmitry > > On 2013-10-09 22:04, S

hg: jdk8/tl/jdk: 8026235: keytool NSS test should use 64 bit lib on Solaris

Changeset: 74b4d20769fd Author:weijun Date: 2013-10-10 15:24 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74b4d20769fd 8026235: keytool NSS test should use 64 bit lib on Solaris Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh

Re: RFR (S) JDK-8025700: RuntimeMXBean.getInputArguments() should include -server/-client/-d32/-d64

On 10/9/2013 11:53 AM, Staffan Larsen wrote: I can absolutely see where Aleksey (and 99% of the Java users) is coming from. From a user perspective there is no difference between the launcher arguments and the JVM arguments. Unfortunately the implementation does make a difference between them

hg: jdk8/tl/jdk: 8025427: jstat tests fails on 32-bit platforms

Changeset: 6aa637dde16e Author:sla Date: 2013-10-10 09:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6aa637dde16e 8025427: jstat tests fails on 32-bit platforms Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn ! src/share/classes/sun/tools/jstat/RowClosure.java ! test/

hg: jdk8/tl/jdk: 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java

Changeset: a30f6fd581b3 Author:sjiang Date: 2013-10-10 09:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a30f6fd581b3 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test

hg: jdk8/tl/jdk: 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java

Changeset: e901a618dcff Author:sjiang Date: 2013-10-10 08:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e901a618dcff 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java Reviewed-by: dfuchs, dholmes ! test/javax/management/monito